* [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data
@ 2014-05-27 12:03 Tobias Klauser
2014-05-28 19:35 ` Chris Metcalf
2014-05-31 0:06 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Tobias Klauser @ 2014-05-27 12:03 UTC (permalink / raw)
To: Chris Metcalf; +Cc: netdev
The memory for private data is allocated using kzalloc/vzalloc in
alloc_netdev_mqs, thus there is no need to zero it again in the driver.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/ethernet/tile/tilegx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/tile/tilegx.c b/drivers/net/ethernet/tile/tilegx.c
index 449011b..0db40de 100644
--- a/drivers/net/ethernet/tile/tilegx.c
+++ b/drivers/net/ethernet/tile/tilegx.c
@@ -2212,7 +2212,6 @@ static void tile_net_dev_init(const char *name, const uint8_t *mac)
/* Initialize "priv". */
priv = netdev_priv(dev);
- memset(priv, 0, sizeof(*priv));
priv->dev = dev;
priv->channel = -1;
priv->loopify_channel = -1;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data
2014-05-27 12:03 [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data Tobias Klauser
@ 2014-05-28 19:35 ` Chris Metcalf
2014-05-31 0:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Chris Metcalf @ 2014-05-28 19:35 UTC (permalink / raw)
To: Tobias Klauser; +Cc: netdev
On 5/27/2014 8:03 AM, Tobias Klauser wrote:
> The memory for private data is allocated using kzalloc/vzalloc in
> alloc_netdev_mqs, thus there is no need to zero it again in the driver.
>
> Signed-off-by: Tobias Klauser<tklauser@distanz.ch>
> ---
> drivers/net/ethernet/tile/tilegx.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data
2014-05-27 12:03 [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data Tobias Klauser
2014-05-28 19:35 ` Chris Metcalf
@ 2014-05-31 0:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-31 0:06 UTC (permalink / raw)
To: tklauser; +Cc: cmetcalf, netdev
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 27 May 2014 14:03:51 +0200
> The memory for private data is allocated using kzalloc/vzalloc in
> alloc_netdev_mqs, thus there is no need to zero it again in the driver.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-31 0:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-27 12:03 [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data Tobias Klauser
2014-05-28 19:35 ` Chris Metcalf
2014-05-31 0:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).