[PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data

[PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data

[Tobias Klauser]

The memory for private data is allocated using kzalloc/vzalloc in
alloc_netdev_mqs, thus there is no need to zero it again in the driver.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/net/ethernet/tile/tilegx.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/tile/tilegx.c b/drivers/net/ethernet/tile/tilegx.c
index 449011b..0db40de 100644
--- a/drivers/net/ethernet/tile/tilegx.c
+++ b/drivers/net/ethernet/tile/tilegx.c
@@ -2212,7 +2212,6 @@ static void tile_net_dev_init(const char *name, const uint8_t *mac)
 
 	/* Initialize "priv". */
 	priv = netdev_priv(dev);
-	memset(priv, 0, sizeof(*priv));
 	priv->dev = dev;
 	priv->channel = -1;
 	priv->loopify_channel = -1;
-- 
1.7.9.5

Re: [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data

[Chris Metcalf]

On 5/27/2014 8:03 AM, Tobias Klauser wrote:
> The memory for private data is allocated using kzalloc/vzalloc in
> alloc_netdev_mqs, thus there is no need to zero it again in the driver.
>
> Signed-off-by: Tobias Klauser<tklauser@distanz.ch>
> ---
>   drivers/net/ethernet/tile/tilegx.c |    1 -
>   1 file changed, 1 deletion(-)

Acked-by: Chris Metcalf <cmetcalf@tilera.com>

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

Re: [PATCH 1/2] net: tile: Remove unnecessary memset of netdev private data

[David Miller]

From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 27 May 2014 14:03:51 +0200

> The memory for private data is allocated using kzalloc/vzalloc in
> alloc_netdev_mqs, thus there is no need to zero it again in the driver.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Applied.