* [patch net 0/2] mlxsw: Couple of fixes
@ 2017-08-04 12:12 Jiri Pirko
2017-08-04 12:12 ` [patch net 1/2] mlxsw: spectrum_switchdev: Don't warn about valid situations Jiri Pirko
` (2 more replies)
0 siblings, 3 replies; 42+ messages in thread
From: Jiri Pirko @ 2017-08-04 12:12 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
Ido says:
The first patch prevents us from warning about valid situations that can
happen due to the fact that some operations in switchdev are deferred.
Second patch fixes a long standing problem in which we didn't correctly
free resources upon module removal, resulting in a memory leak.
Ido Schimmel (2):
mlxsw: spectrum_switchdev: Don't warn about valid situations
mlxsw: spectrum_switchdev: Release multicast groups during fini
.../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 37 ++++++++++++++--------
1 file changed, 24 insertions(+), 13 deletions(-)
--
2.9.3
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 1/2] mlxsw: spectrum_switchdev: Don't warn about valid situations
2017-08-04 12:12 [patch net 0/2] mlxsw: Couple of fixes Jiri Pirko
@ 2017-08-04 12:12 ` Jiri Pirko
2017-08-04 12:12 ` [patch net 2/2] mlxsw: spectrum_switchdev: Release multicast groups during fini Jiri Pirko
2017-08-04 18:17 ` [patch net 0/2] mlxsw: Couple of fixes David Miller
2 siblings, 0 replies; 42+ messages in thread
From: Jiri Pirko @ 2017-08-04 12:12 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, mlxsw
From: Ido Schimmel <idosch@mellanox.com>
Some operations in the bridge driver such as MDB deletion are preformed
in an atomic context and thus deferred to a process context by the
switchdev infrastructure.
Therefore, by the time the operation is performed by the underlying
device driver it's possible the bridge port context is already gone.
This is especially true for removal flows, but theoretically can also be
invoked during addition.
Remove the warnings in such situations and return normally.
Fixes: c57529e1d5d8 ("mlxsw: spectrum: Replace vPorts with Port-VLAN")
Fixes: 3922285d96e7 ("net: bridge: Add support for offloading port attributes")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
.../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 24 +++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
index 656b2d3..73d54df 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
@@ -626,8 +626,8 @@ static int mlxsw_sp_port_attr_br_flags_set(struct mlxsw_sp_port *mlxsw_sp_port,
bridge_port = mlxsw_sp_bridge_port_find(mlxsw_sp_port->mlxsw_sp->bridge,
orig_dev);
- if (WARN_ON(!bridge_port))
- return -EINVAL;
+ if (!bridge_port)
+ return 0;
err = mlxsw_sp_bridge_port_flood_table_set(mlxsw_sp_port, bridge_port,
MLXSW_SP_FLOOD_TYPE_UC,
@@ -711,8 +711,8 @@ static int mlxsw_sp_port_attr_mc_router_set(struct mlxsw_sp_port *mlxsw_sp_port,
bridge_port = mlxsw_sp_bridge_port_find(mlxsw_sp_port->mlxsw_sp->bridge,
orig_dev);
- if (WARN_ON(!bridge_port))
- return -EINVAL;
+ if (!bridge_port)
+ return 0;
if (!bridge_port->bridge_device->multicast_enabled)
return 0;
@@ -1283,15 +1283,15 @@ static int mlxsw_sp_port_mdb_add(struct mlxsw_sp_port *mlxsw_sp_port,
return 0;
bridge_port = mlxsw_sp_bridge_port_find(mlxsw_sp->bridge, orig_dev);
- if (WARN_ON(!bridge_port))
- return -EINVAL;
+ if (!bridge_port)
+ return 0;
bridge_device = bridge_port->bridge_device;
mlxsw_sp_port_vlan = mlxsw_sp_port_vlan_find_by_bridge(mlxsw_sp_port,
bridge_device,
mdb->vid);
- if (WARN_ON(!mlxsw_sp_port_vlan))
- return -EINVAL;
+ if (!mlxsw_sp_port_vlan)
+ return 0;
fid_index = mlxsw_sp_fid_index(mlxsw_sp_port_vlan->fid);
@@ -1407,15 +1407,15 @@ static int mlxsw_sp_port_mdb_del(struct mlxsw_sp_port *mlxsw_sp_port,
int err = 0;
bridge_port = mlxsw_sp_bridge_port_find(mlxsw_sp->bridge, orig_dev);
- if (WARN_ON(!bridge_port))
- return -EINVAL;
+ if (!bridge_port)
+ return 0;
bridge_device = bridge_port->bridge_device;
mlxsw_sp_port_vlan = mlxsw_sp_port_vlan_find_by_bridge(mlxsw_sp_port,
bridge_device,
mdb->vid);
- if (WARN_ON(!mlxsw_sp_port_vlan))
- return -EINVAL;
+ if (!mlxsw_sp_port_vlan)
+ return 0;
fid_index = mlxsw_sp_fid_index(mlxsw_sp_port_vlan->fid);
--
2.9.3
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [patch net 2/2] mlxsw: spectrum_switchdev: Release multicast groups during fini
2017-08-04 12:12 [patch net 0/2] mlxsw: Couple of fixes Jiri Pirko
2017-08-04 12:12 ` [patch net 1/2] mlxsw: spectrum_switchdev: Don't warn about valid situations Jiri Pirko
@ 2017-08-04 12:12 ` Jiri Pirko
2017-08-04 18:17 ` [patch net 0/2] mlxsw: Couple of fixes David Miller
2 siblings, 0 replies; 42+ messages in thread
From: Jiri Pirko @ 2017-08-04 12:12 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, mlxsw
From: Ido Schimmel <idosch@mellanox.com>
Each multicast group (MID) stores a bitmap of ports to which a packet
should be forwarded to in case an MDB entry associated with the MID is
hit.
Since the initial introduction of IGMP snooping in commit 3a49b4fde2a1
("mlxsw: Adding layer 2 multicast support") the driver didn't correctly
free these multicast groups upon ungraceful situations such as the
removal of the upper bridge device or module removal.
The correct way to fix this is to associate each MID with the bridge
ports member in it and then drop the reference in case the bridge port
is destroyed, but this will result in a lot more code and will be fixed
in net-next.
For now, upon module removal, traverse the MID list and release each
one.
Fixes: 3a49b4fde2a1 ("mlxsw: Adding layer 2 multicast support")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
index 73d54df..5eb1606 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
@@ -1974,6 +1974,17 @@ static void mlxsw_sp_fdb_fini(struct mlxsw_sp *mlxsw_sp)
}
+static void mlxsw_sp_mids_fini(struct mlxsw_sp *mlxsw_sp)
+{
+ struct mlxsw_sp_mid *mid, *tmp;
+
+ list_for_each_entry_safe(mid, tmp, &mlxsw_sp->bridge->mids_list, list) {
+ list_del(&mid->list);
+ clear_bit(mid->mid, mlxsw_sp->bridge->mids_bitmap);
+ kfree(mid);
+ }
+}
+
int mlxsw_sp_switchdev_init(struct mlxsw_sp *mlxsw_sp)
{
struct mlxsw_sp_bridge *bridge;
@@ -1996,7 +2007,7 @@ int mlxsw_sp_switchdev_init(struct mlxsw_sp *mlxsw_sp)
void mlxsw_sp_switchdev_fini(struct mlxsw_sp *mlxsw_sp)
{
mlxsw_sp_fdb_fini(mlxsw_sp);
- WARN_ON(!list_empty(&mlxsw_sp->bridge->mids_list));
+ mlxsw_sp_mids_fini(mlxsw_sp);
WARN_ON(!list_empty(&mlxsw_sp->bridge->bridges_list));
kfree(mlxsw_sp->bridge);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: Couple of fixes
2017-08-04 12:12 [patch net 0/2] mlxsw: Couple of fixes Jiri Pirko
2017-08-04 12:12 ` [patch net 1/2] mlxsw: spectrum_switchdev: Don't warn about valid situations Jiri Pirko
2017-08-04 12:12 ` [patch net 2/2] mlxsw: spectrum_switchdev: Release multicast groups during fini Jiri Pirko
@ 2017-08-04 18:17 ` David Miller
2 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2017-08-04 18:17 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 4 Aug 2017 14:12:28 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Ido says:
>
> The first patch prevents us from warning about valid situations that can
> happen due to the fact that some operations in switchdev are deferred.
>
> Second patch fixes a long standing problem in which we didn't correctly
> free resources upon module removal, resulting in a memory leak.
Series applied, thanks!
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH net 0/2] mlxsw: Couple of fixes
2020-11-17 17:33 [PATCH " Ido Schimmel
@ 2020-11-18 19:09 ` Jakub Kicinski
0 siblings, 0 replies; 42+ messages in thread
From: Jakub Kicinski @ 2020-11-18 19:09 UTC (permalink / raw)
To: Ido Schimmel; +Cc: netdev, davem, jiri, mlxsw, Ido Schimmel
On Tue, 17 Nov 2020 19:33:50 +0200 Ido Schimmel wrote:
> This patch set contains two fixes for mlxsw.
>
> Patch #1 fixes firmware flashing when CONFIG_MLXSW_CORE=y and
> CONFIG_MLXFW=m.
>
> Patch #2 prevents EMAD transactions from needlessly failing when the
> system is under heavy load by using exponential backoff.
>
> Please consider patch #2 for stable.
Applied, and queued, thanks!
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH net 0/2] mlxsw: Couple of fixes
@ 2020-11-17 17:33 Ido Schimmel
2020-11-18 19:09 ` Jakub Kicinski
0 siblings, 1 reply; 42+ messages in thread
From: Ido Schimmel @ 2020-11-17 17:33 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, jiri, mlxsw, Ido Schimmel
From: Ido Schimmel <idosch@nvidia.com>
This patch set contains two fixes for mlxsw.
Patch #1 fixes firmware flashing when CONFIG_MLXSW_CORE=y and
CONFIG_MLXFW=m.
Patch #2 prevents EMAD transactions from needlessly failing when the
system is under heavy load by using exponential backoff.
Please consider patch #2 for stable.
Ido Schimmel (2):
mlxsw: Fix firmware flashing
mlxsw: core: Use variable timeout for EMAD retries
drivers/net/ethernet/mellanox/mlxsw/Kconfig | 2 +-
drivers/net/ethernet/mellanox/mlxsw/core.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
--
2.28.0
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH net 0/2] mlxsw: Couple of fixes
2019-12-29 11:40 Ido Schimmel
@ 2019-12-29 20:30 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2019-12-29 20:30 UTC (permalink / raw)
To: idosch; +Cc: netdev, jiri, mlxsw, idosch
From: Ido Schimmel <idosch@idosch.org>
Date: Sun, 29 Dec 2019 13:40:21 +0200
> From: Ido Schimmel <idosch@mellanox.com>
>
> This patch set contains two fixes for mlxsw. Please consider both for
> stable.
>
> Patch #1 from Amit fixes a wrong check during MAC validation when
> creating router interfaces (RIFs). Given a particular order of
> configuration this can result in the driver refusing to create new RIFs.
>
> Patch #2 fixes a wrong trap configuration in which VRRP packets and
> routing exceptions were policed by the same policer towards the CPU. In
> certain situations this can prevent VRRP packets from reaching the CPU.
Series applied and queued up for -stable.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH net 0/2] mlxsw: Couple of fixes
@ 2019-12-29 11:40 Ido Schimmel
2019-12-29 20:30 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Ido Schimmel @ 2019-12-29 11:40 UTC (permalink / raw)
To: netdev; +Cc: davem, jiri, mlxsw, Ido Schimmel
From: Ido Schimmel <idosch@mellanox.com>
This patch set contains two fixes for mlxsw. Please consider both for
stable.
Patch #1 from Amit fixes a wrong check during MAC validation when
creating router interfaces (RIFs). Given a particular order of
configuration this can result in the driver refusing to create new RIFs.
Patch #2 fixes a wrong trap configuration in which VRRP packets and
routing exceptions were policed by the same policer towards the CPU. In
certain situations this can prevent VRRP packets from reaching the CPU.
Amit Cohen (1):
mlxsw: spectrum_router: Skip loopback RIFs during MAC validation
Ido Schimmel (1):
mlxsw: spectrum: Use dedicated policer for VRRP packets
drivers/net/ethernet/mellanox/mlxsw/reg.h | 1 +
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 9 +++++++--
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 +++
3 files changed, 11 insertions(+), 2 deletions(-)
--
2.24.1
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH net 0/2] mlxsw: Couple of fixes
2018-10-29 14:26 Ido Schimmel
@ 2018-10-30 3:48 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2018-10-30 3:48 UTC (permalink / raw)
To: idosch; +Cc: netdev, jiri, petrm, shalomt, alexpe, mlxsw
From: Ido Schimmel <idosch@mellanox.com>
Date: Mon, 29 Oct 2018 14:26:13 +0000
> First patch makes sure mlxsw does not ignore user requests to delete FDB
> entries that were learned by the device.
>
> Second patch fixes a use-after-free that can be triggered by requesting
> a reload via devlink when the previous reload failed.
>
> Please consider both patches for stable. They apply cleanly to both
> 4.18.y and 4.19.y.
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH net 0/2] mlxsw: Couple of fixes
@ 2018-10-29 14:26 Ido Schimmel
2018-10-30 3:48 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Ido Schimmel @ 2018-10-29 14:26 UTC (permalink / raw)
To: netdev
Cc: davem, Jiri Pirko, Petr Machata, Shalom Toledo,
Alexander Petrovskiy, mlxsw, Ido Schimmel
First patch makes sure mlxsw does not ignore user requests to delete FDB
entries that were learned by the device.
Second patch fixes a use-after-free that can be triggered by requesting
a reload via devlink when the previous reload failed.
Please consider both patches for stable. They apply cleanly to both
4.18.y and 4.19.y.
Petr Machata (1):
mlxsw: spectrum_switchdev: Don't ignore deletions of learned MACs
Shalom Toledo (1):
mlxsw: core: Fix devlink unregister flow
drivers/net/ethernet/mellanox/mlxsw/core.c | 24 +++++++++++++------
.../mellanox/mlxsw/spectrum_switchdev.c | 2 --
2 files changed, 17 insertions(+), 9 deletions(-)
--
2.17.2
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH net 0/2] mlxsw: Couple of fixes
2018-10-04 16:56 ` David Miller
@ 2018-10-04 17:05 ` Ido Schimmel
0 siblings, 0 replies; 42+ messages in thread
From: Ido Schimmel @ 2018-10-04 17:05 UTC (permalink / raw)
To: David Miller; +Cc: netdev, jiri, mlxsw
On Thu, Oct 04, 2018 at 09:56:54AM -0700, David Miller wrote:
> Series applied, and patch #2 queued up for -stable.
>
> I was thinking about Fixes tags for the situation in patch #2 a bit,
> and it's probably best to list two Fixes tags. One for the original
> bug that wasn't fixed properly, and one for the incomplete fix.
>
> It's nice that you mentioned the incomplete fix in the commit message
> but a backporter might miss this chain of commits and dependencies it
> if it isn't in the Fixes: tags.
Noted. Will do so in future submissions.
Thanks, David.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH net 0/2] mlxsw: Couple of fixes
2018-10-04 15:48 Ido Schimmel
@ 2018-10-04 16:56 ` David Miller
2018-10-04 17:05 ` Ido Schimmel
0 siblings, 1 reply; 42+ messages in thread
From: David Miller @ 2018-10-04 16:56 UTC (permalink / raw)
To: idosch; +Cc: netdev, jiri, mlxsw
From: Ido Schimmel <idosch@mellanox.com>
Date: Thu, 4 Oct 2018 15:48:00 +0000
> First patch works around an hardware issue in Spectrum-2 where a field
> indicating the event type is always set to the same value. Since there
> are only two event types and they are reported using different queues,
> we can use the queue number to derive the event type.
>
> Second patch prevents a router interface (RIF) leakage when a VLAN
> device is deleted from on top a bridge device.
Series applied, and patch #2 queued up for -stable.
I was thinking about Fixes tags for the situation in patch #2 a bit,
and it's probably best to list two Fixes tags. One for the original
bug that wasn't fixed properly, and one for the incomplete fix.
It's nice that you mentioned the incomplete fix in the commit message
but a backporter might miss this chain of commits and dependencies it
if it isn't in the Fixes: tags.
Thanks.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH net 0/2] mlxsw: Couple of fixes
@ 2018-10-04 15:48 Ido Schimmel
2018-10-04 16:56 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Ido Schimmel @ 2018-10-04 15:48 UTC (permalink / raw)
To: netdev; +Cc: davem, Jiri Pirko, mlxsw, Ido Schimmel
First patch works around an hardware issue in Spectrum-2 where a field
indicating the event type is always set to the same value. Since there
are only two event types and they are reported using different queues,
we can use the queue number to derive the event type.
Second patch prevents a router interface (RIF) leakage when a VLAN
device is deleted from on top a bridge device.
Ido Schimmel (1):
mlxsw: spectrum: Delete RIF when VLAN device is removed
Nir Dotan (1):
mlxsw: pci: Derive event type from event queue number
drivers/net/ethernet/mellanox/mlxsw/pci.c | 11 +++++++----
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 ++
2 files changed, 9 insertions(+), 4 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2018-02-27 19:39 ` David Miller
@ 2018-02-28 7:09 ` Jiri Pirko
0 siblings, 0 replies; 42+ messages in thread
From: Jiri Pirko @ 2018-02-28 7:09 UTC (permalink / raw)
To: David Miller; +Cc: netdev, idosch, mlxsw
Tue, Feb 27, 2018 at 08:39:06PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Tue, 27 Feb 2018 12:56:12 +0100
>
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Couple of unrelated fixes for mlxsw.
>>
>> ---
>> Please consider the first patch for -stable.
>> Thanks!
>
>Patch #2 doesn't apply cleanly, please respin.
Okay.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2018-02-27 11:56 [patch net 0/2] mlxsw: couple " Jiri Pirko
@ 2018-02-27 19:39 ` David Miller
2018-02-28 7:09 ` Jiri Pirko
0 siblings, 1 reply; 42+ messages in thread
From: David Miller @ 2018-02-27 19:39 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 27 Feb 2018 12:56:12 +0100
> From: Jiri Pirko <jiri@mellanox.com>
>
> Couple of unrelated fixes for mlxsw.
>
> ---
> Please consider the first patch for -stable.
> Thanks!
Patch #2 doesn't apply cleanly, please respin.
Thank you.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2018-02-27 11:56 Jiri Pirko
2018-02-27 19:39 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2018-02-27 11:56 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
Couple of unrelated fixes for mlxsw.
---
Please consider the first patch for -stable.
Thanks!
Jiri Pirko (2):
mlxsw: core: Fix flex keys scratchpad offset conflict
mlxsw: spectrum: Fix handling of resource_size_param
.../ethernet/mellanox/mlxsw/core_acl_flex_keys.h | 20 +++---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 76 +++++++++++-----------
include/net/devlink.h | 18 ++++-
net/core/devlink.c | 7 +-
4 files changed, 68 insertions(+), 53 deletions(-)
--
2.14.3
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2018-01-10 10:42 Jiri Pirko
@ 2018-01-10 20:58 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2018-01-10 20:58 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, yuvalm, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 10 Jan 2018 11:42:42 +0100
> From: Jiri Pirko <jiri@mellanox.com>
>
> Couple of small fixes for mlxsw driver.
Series applied, thanks.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2018-01-10 10:42 Jiri Pirko
2018-01-10 20:58 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2018-01-10 10:42 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, yuvalm, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
Couple of small fixes for mlxsw driver.
Jiri Pirko (1):
mlxsw: spectrum_qdisc: Don't use variable array in
mlxsw_sp_tclass_congestion_enable
Yuval Mintz (1):
mlxsw: pci: Wait after reset before accessing HW
drivers/net/ethernet/mellanox/mlxsw/pci.c | 7 ++++++-
drivers/net/ethernet/mellanox/mlxsw/pci_hw.h | 1 +
drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c | 7 ++++---
3 files changed, 11 insertions(+), 4 deletions(-)
--
2.14.3
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2017-05-18 7:18 Jiri Pirko
@ 2017-05-18 15:05 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2017-05-18 15:05 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, arkadis, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 18 May 2017 09:18:51 +0200
> Couple of fixes from Arkadi
Series applied.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2017-05-18 7:18 Jiri Pirko
2017-05-18 15:05 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2017-05-18 7:18 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, arkadis, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
Cuple of fixes from Arkadi
Arkadi Sharshevsky (2):
mlxsw: spectrum_dpipe: Fix incorrect entry index
mlxsw: spectrum_router: Fix rif counter freeing routine
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 3 ++-
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)
--
2.9.3
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: Couple of fixes
2017-03-14 12:59 [patch net 0/2] mlxsw: Couple " Jiri Pirko
@ 2017-03-14 18:35 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2017-03-14 18:35 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 14 Mar 2017 13:59:59 +0100
> Couple or small fixes.
Series applied, thanks Jiri.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: Couple of fixes
@ 2017-03-14 12:59 Jiri Pirko
2017-03-14 18:35 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2017-03-14 12:59 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
Couple or small fixes.
Jiri Pirko (2):
mlxsw: reg: Fix SPVM max record count
mlxsw: reg: Fix SPVMLR max record count
drivers/net/ethernet/mellanox/mlxsw/reg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: Couple of fixes
2016-11-11 10:20 Jiri Pirko
@ 2016-11-13 17:48 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2016-11-13 17:48 UTC (permalink / raw)
To: jiri; +Cc: netdev, yotamg, arkadis, idosch, eladr, nogahf, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 11 Nov 2016 11:20:40 +0100
> Please, queue-up both for stable. Thanks!
Series applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: Couple of fixes
@ 2016-11-11 10:20 Jiri Pirko
2016-11-13 17:48 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-11-11 10:20 UTC (permalink / raw)
To: netdev; +Cc: davem, yotamg, arkadis, idosch, eladr, nogahf, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Please, queue-up both for stable. Thanks!
Arkadi Sharshevsky (1):
mlxsw: spectrum_router: Correctly dump neighbour activity
Yotam Gigi (1):
mlxsw: spectrum: Fix refcount bug on span entries
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 11 ++++++-----
.../net/ethernet/mellanox/mlxsw/spectrum_router.c | 22 +++++++++++++++++++++-
2 files changed, 27 insertions(+), 6 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: Couple of fixes
2016-10-25 9:25 Jiri Pirko
@ 2016-10-28 17:44 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2016-10-28 17:44 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 25 Oct 2016 11:25:55 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Couple of LPM tree management fixes.
Series applied, thanks Jiri.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: Couple of fixes
@ 2016-10-25 9:25 Jiri Pirko
2016-10-28 17:44 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-10-25 9:25 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Couple of LPM tree management fixes.
Jiri Pirko (2):
mlxsw: spectrum_router: Save requested prefix bitlist when creating
tree
mlxsw: spectrum_router: Compare only trees which are in use during
tree get
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.5.5
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: Couple of fixes
2016-10-05 0:29 ` David Miller
@ 2016-10-05 11:14 ` Jiri Pirko
0 siblings, 0 replies; 42+ messages in thread
From: Jiri Pirko @ 2016-10-05 11:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev, yotamg, idosch, eladr, nogahf, ogerlitz
Wed, Oct 05, 2016 at 02:29:27AM CEST, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Tue, 4 Oct 2016 09:46:03 +0200
>
>> Couple of fixes from Yotam.
>
>Series applied, thanks.
>
>Note that needed_headroom is a request, rather than a guarantee, so you
>may in some rare cases need to realloc your headroom if the kernel was
>not able to meet your request.
We already do that:
if (unlikely(skb_headroom(skb) < MLXSW_TXHDR_LEN)) {
struct sk_buff *skb_orig = skb;
skb = skb_realloc_headroom(skb, MLXSW_TXHDR_LEN);
if (!skb) {
this_cpu_inc(mlxsw_sp_port->pcpu_stats->tx_dropped);
dev_kfree_skb_any(skb_orig);
return NETDEV_TX_OK;
}
}
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: Couple of fixes
2016-10-04 7:46 Jiri Pirko
@ 2016-10-05 0:29 ` David Miller
2016-10-05 11:14 ` Jiri Pirko
0 siblings, 1 reply; 42+ messages in thread
From: David Miller @ 2016-10-05 0:29 UTC (permalink / raw)
To: jiri; +Cc: netdev, yotamg, idosch, eladr, nogahf, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 4 Oct 2016 09:46:03 +0200
> Couple of fixes from Yotam.
Series applied, thanks.
Note that needed_headroom is a request, rather than a guarantee, so you
may in some rare cases need to realloc your headroom if the kernel was
not able to meet your request.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: Couple of fixes
@ 2016-10-04 7:46 Jiri Pirko
2016-10-05 0:29 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-10-04 7:46 UTC (permalink / raw)
To: netdev; +Cc: davem, yotamg, idosch, eladr, nogahf, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Couple of fixes from Yotam.
Yotam Gigi (2):
mlxsw: spectrum: Fix misuse of hard_header_len
mlxsw: switchx2: Fix misuse of hard_header_len
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +-
drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2016-09-08 6:16 [patch net 0/2] mlxsw: couple " Jiri Pirko
@ 2016-09-09 23:57 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2016-09-09 23:57 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 8 Sep 2016 08:16:00 +0200
> Couple of fixes from Ido and myself.
Series applied, thanks Jiri.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2016-09-08 6:16 Jiri Pirko
2016-09-09 23:57 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-09-08 6:16 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Couple of fixes from Ido and myself.
Ido Schimmel (1):
mlxsw: spectrum: Set port type before setting its address
Jiri Pirko (1):
mlxsw: spectrum_router: Fix error path in mlxsw_sp_router_init
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 18 +++++++++---------
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 9 ++++++++-
2 files changed, 17 insertions(+), 10 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2016-08-24 9:18 Jiri Pirko
@ 2016-08-24 16:39 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2016-08-24 16:39 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 24 Aug 2016 11:18:50 +0200
> Ido Schimmel (1):
> mlxsw: spectrum: Add missing flood to router port
>
> Yotam Gigi (1):
> mlxsw: router: Enable neighbors to be created on stacked devices
Both applied, thanks Jiri.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2016-08-24 9:18 Jiri Pirko
2016-08-24 16:39 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-08-24 9:18 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Ido Schimmel (1):
mlxsw: spectrum: Add missing flood to router port
Yotam Gigi (1):
mlxsw: router: Enable neighbors to be created on stacked devices
drivers/net/ethernet/mellanox/mlxsw/port.h | 1 +
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 43 +++++++++++++++++++++-
.../net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
3 files changed, 44 insertions(+), 2 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2016-06-17 13:09 Jiri Pirko
@ 2016-06-18 4:58 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2016-06-18 4:58 UTC (permalink / raw)
To: jiri; +Cc: netdev, nogahf, idosch, eladr, yotamg, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 17 Jun 2016 15:09:04 +0200
> Couple of slowpath tx stats fixes for Spectrum and SwitchX-2.
Series applied, thanks Jiri.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2016-06-17 13:09 Jiri Pirko
2016-06-18 4:58 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-06-17 13:09 UTC (permalink / raw)
To: netdev; +Cc: davem, nogahf, idosch, eladr, yotamg, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Couple of slowpath tx stats fixes for Spectrum and SwitchX-2.
Nogah Frankel (2):
mlxsw: spectrum: Don't count internal TX header bytes to stats
mlxsw: switchx2: Don't count internal TX header bytes to stats
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 6 +++++-
drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 5 ++++-
2 files changed, 9 insertions(+), 2 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2016-06-09 7:51 Jiri Pirko
@ 2016-06-09 18:21 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2016-06-09 18:21 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 9 Jun 2016 09:51:38 +0200
> Couple of fixes from Ido.
Series applied, thanks.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2016-06-09 7:51 Jiri Pirko
2016-06-09 18:21 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-06-09 7:51 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, eladr, yotamg, nogahf, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Couple of fixes from Ido.
Ido Schimmel (2):
mlxsw: spectrum: Make split flow match firmware requirements
mlxsw: spectrum: Don't sleep during ndo_get_phys_port_name()
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 203 ++++++++++++++-----------
drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 5 +
2 files changed, 117 insertions(+), 91 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: Couple of fixes
2016-05-06 20:18 [patch net 0/2] mlxsw: Couple " Jiri Pirko
@ 2016-05-06 22:33 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2016-05-06 22:33 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, eladr, yotamg, ogerlitz
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 6 May 2016 22:18:38 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Ido Schimmel (2):
> mlxsw: spectrum: Fix rollback order in LAG join failure
> mlxsw: spectrum: Add missing rollback in flood configuration
Applied.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: Couple of fixes
@ 2016-05-06 20:18 Jiri Pirko
2016-05-06 22:33 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2016-05-06 20:18 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, eladr, yotamg, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Ido Schimmel (2):
mlxsw: spectrum: Fix rollback order in LAG join failure
mlxsw: spectrum: Add missing rollback in flood configuration
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++--
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 8 ++++++++
2 files changed, 10 insertions(+), 2 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2016-03-07 8:24 Jiri Pirko
0 siblings, 0 replies; 42+ messages in thread
From: Jiri Pirko @ 2016-03-07 8:24 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, eladr, yotamg, ogerlitz
From: Jiri Pirko <jiri@mellanox.com>
Couple of fixes from Ido.
Ido Schimmel (2):
mlxsw: spectrum: Always decrement bridge's ref count
mlxsw: pci: Correctly determine if descriptor queue is full
drivers/net/ethernet/mellanox/mlxsw/pci.c | 2 +-
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
--
2.5.0
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [patch net 0/2] mlxsw: couple of fixes
2015-10-08 13:17 Jiri Pirko
@ 2015-10-11 12:08 ` David Miller
0 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2015-10-11 12:08 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, eladr
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 8 Oct 2015 15:17:36 +0200
> Just a couple of small fixes.
Series applied, thanks Jiri.
^ permalink raw reply [flat|nested] 42+ messages in thread
* [patch net 0/2] mlxsw: couple of fixes
@ 2015-10-08 13:17 Jiri Pirko
2015-10-11 12:08 ` David Miller
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Pirko @ 2015-10-08 13:17 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, eladr
From: Jiri Pirko <jiri@mellanox.com>
Just a couple of small fixes.
Elad Raz (1):
mlxsw: switchx2: changing order of exit fallbacks
Ido Schimmel (1):
mlxsw: Fix bug in __mlxsw_item_bit_array_offset
drivers/net/ethernet/mellanox/mlxsw/item.h | 4 +++-
drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
--
1.9.3
^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2020-11-18 19:09 UTC | newest]
Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04 12:12 [patch net 0/2] mlxsw: Couple of fixes Jiri Pirko
2017-08-04 12:12 ` [patch net 1/2] mlxsw: spectrum_switchdev: Don't warn about valid situations Jiri Pirko
2017-08-04 12:12 ` [patch net 2/2] mlxsw: spectrum_switchdev: Release multicast groups during fini Jiri Pirko
2017-08-04 18:17 ` [patch net 0/2] mlxsw: Couple of fixes David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 17:33 [PATCH " Ido Schimmel
2020-11-18 19:09 ` Jakub Kicinski
2019-12-29 11:40 Ido Schimmel
2019-12-29 20:30 ` David Miller
2018-10-29 14:26 Ido Schimmel
2018-10-30 3:48 ` David Miller
2018-10-04 15:48 Ido Schimmel
2018-10-04 16:56 ` David Miller
2018-10-04 17:05 ` Ido Schimmel
2018-02-27 11:56 [patch net 0/2] mlxsw: couple " Jiri Pirko
2018-02-27 19:39 ` David Miller
2018-02-28 7:09 ` Jiri Pirko
2018-01-10 10:42 Jiri Pirko
2018-01-10 20:58 ` David Miller
2017-05-18 7:18 Jiri Pirko
2017-05-18 15:05 ` David Miller
2017-03-14 12:59 [patch net 0/2] mlxsw: Couple " Jiri Pirko
2017-03-14 18:35 ` David Miller
2016-11-11 10:20 Jiri Pirko
2016-11-13 17:48 ` David Miller
2016-10-25 9:25 Jiri Pirko
2016-10-28 17:44 ` David Miller
2016-10-04 7:46 Jiri Pirko
2016-10-05 0:29 ` David Miller
2016-10-05 11:14 ` Jiri Pirko
2016-09-08 6:16 [patch net 0/2] mlxsw: couple " Jiri Pirko
2016-09-09 23:57 ` David Miller
2016-08-24 9:18 Jiri Pirko
2016-08-24 16:39 ` David Miller
2016-06-17 13:09 Jiri Pirko
2016-06-18 4:58 ` David Miller
2016-06-09 7:51 Jiri Pirko
2016-06-09 18:21 ` David Miller
2016-05-06 20:18 [patch net 0/2] mlxsw: Couple " Jiri Pirko
2016-05-06 22:33 ` David Miller
2016-03-07 8:24 [patch net 0/2] mlxsw: couple " Jiri Pirko
2015-10-08 13:17 Jiri Pirko
2015-10-11 12:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).