From: Andrew Lunn <andrew@lunn.ch>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: netdev@vger.kernel.org, grygorii.strashko@ti.com,
ivan.khoronzhuk@linaro.org, nsekhar@ti.com, jiri@resnulli.us,
ivecera@redhat.com, francois.ozog@linaro.org, yogeshs@ti.com,
spatton@ti.com
Subject: Re: [PATCH 4/4] cpsw: add switchdev support
Date: Thu, 24 May 2018 15:12:29 +0200 [thread overview]
Message-ID: <20180524131229.GC24557@lunn.ch> (raw)
In-Reply-To: <1527144984-31236-5-git-send-email-ilias.apalodimas@linaro.org>
> @@ -2626,7 +2750,11 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
> data->mac_control = prop;
>
> if (of_property_read_bool(node, "dual_emac"))
> - data->dual_emac = 1;
> + data->switch_mode = CPSW_DUAL_EMAC;
> +
> + /* switchdev overrides DTS */
> + if (IS_ENABLED(CONFIG_TI_CPSW_SWITCHDEV))
> + data->switch_mode = CPSW_SWITCHDEV;
Device tree is supposed to describe the hardware. Using that hardware
in different ways is not something you should describe in DT.
There are also a lot of IS_ENABLED() here, which i don't like. It is a
lot better than #ifdef, but we should try to do better. It would be
good to split this cleanly into three parts. A generic library, which
does not care about DUAL_MAC or SWITCHDEV. A driver which implements
legacy DUAL MAC etc. And a driver which implements SWITCHDEV. We can
then give this new switchdev driver a different compatible. It i still
encoding in device tree how to use the hardware, but it is more
implicit, rather than explicit.
Andrew
next prev parent reply other threads:[~2018-05-24 13:12 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 6:56 [PATCH 0/4] RFC CPSW switchdev mode Ilias Apalodimas
2018-05-24 6:56 ` [PATCH 1/4] cpsw: move common headers definitions to cpsw_priv.h Ilias Apalodimas
2018-05-24 6:56 ` [PATCH 2/4] cpsw_ale: add support functions for switchdev Ilias Apalodimas
2018-05-24 6:56 ` [PATCH 3/4] cpsw_switchdev: add switchdev support files Ilias Apalodimas
2018-05-24 10:00 ` Maxim Uvarov
2018-05-27 4:39 ` kbuild test robot
2018-05-24 6:56 ` [PATCH 4/4] cpsw: add switchdev support Ilias Apalodimas
2018-05-24 13:12 ` Andrew Lunn [this message]
2018-05-24 13:32 ` Ilias Apalodimas
2018-05-24 16:39 ` Andrew Lunn
2018-05-25 4:56 ` Ilias Apalodimas
2018-06-01 21:48 ` Florian Fainelli
2018-06-02 10:34 ` Ilias Apalodimas
2018-06-02 16:10 ` Florian Fainelli
2018-06-02 16:52 ` Ilias Apalodimas
2018-06-05 21:03 ` Grygorii Strashko
2018-06-05 21:37 ` Florian Fainelli
2018-05-24 8:05 ` [PATCH 0/4] RFC CPSW switchdev mode Jiri Pirko
2018-05-24 8:48 ` Ilias Apalodimas
2018-05-24 12:54 ` Andrew Lunn
2018-05-24 13:44 ` Ivan Vecera
2018-05-24 14:08 ` Ilias Apalodimas
2018-05-24 14:54 ` Andrew Lunn
2018-05-24 15:07 ` Ilias Apalodimas
2018-05-24 15:25 ` Andrew Lunn
2018-05-24 16:02 ` Ilias Apalodimas
2018-05-24 16:33 ` Andrew Lunn
2018-05-25 6:29 ` Ilias Apalodimas
2018-05-25 10:28 ` Ilias Apalodimas
2018-05-25 11:59 ` Andrew Lunn
2018-05-25 12:09 ` Andrew Lunn
2018-05-31 15:27 ` Ilias Apalodimas
2018-06-02 23:28 ` Grygorii Strashko
2018-06-03 0:08 ` Andrew Lunn
2018-06-05 21:18 ` Grygorii Strashko
2018-06-05 21:28 ` Andrew Lunn
2018-06-05 21:42 ` Grygorii Strashko
2018-06-05 21:55 ` Andrew Lunn
2018-06-03 0:26 ` Andrew Lunn
2018-06-05 23:23 ` Grygorii Strashko
2018-06-05 23:49 ` Andrew Lunn
2018-06-06 8:23 ` Ivan Khoronzhuk
2018-06-03 0:37 ` Andrew Lunn
2018-06-05 21:31 ` Grygorii Strashko
2018-06-05 21:37 ` Andrew Lunn
2018-06-03 0:49 ` Andrew Lunn
2018-06-05 22:45 ` Grygorii Strashko
2018-06-05 23:40 ` Andrew Lunn
2018-06-01 21:29 ` Grygorii Strashko
2018-06-02 14:08 ` Andrew Lunn
2018-06-05 22:59 ` Grygorii Strashko
2018-06-05 23:53 ` Andrew Lunn
2018-06-06 6:42 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524131229.GC24557@lunn.ch \
--to=andrew@lunn.ch \
--cc=francois.ozog@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=spatton@ti.com \
--cc=yogeshs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).