* [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt
@ 2019-08-27 11:29 Colin King
2019-08-28 9:14 ` Sergei Shtylyov
2019-08-28 21:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-08-27 11:29 UTC (permalink / raw)
To: Michael Grzeschik, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer pkt is being initialized with a value that is never read
and pkg is being re-assigned a little later on. The assignment is
redundant and hence can be removed.
Addresses-Coverity: ("Ununsed value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/arcnet/capmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/arcnet/capmode.c b/drivers/net/arcnet/capmode.c
index b780be6f41ff..c09b567845e1 100644
--- a/drivers/net/arcnet/capmode.c
+++ b/drivers/net/arcnet/capmode.c
@@ -44,7 +44,7 @@ static void rx(struct net_device *dev, int bufnum,
{
struct arcnet_local *lp = netdev_priv(dev);
struct sk_buff *skb;
- struct archdr *pkt = pkthdr;
+ struct archdr *pkt;
char *pktbuf, *pkthdrbuf;
int ofs;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt
2019-08-27 11:29 [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt Colin King
@ 2019-08-28 9:14 ` Sergei Shtylyov
2019-08-28 21:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2019-08-28 9:14 UTC (permalink / raw)
To: Colin King, Michael Grzeschik, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
Hello!
On 27.08.2019 14:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer pkt is being initialized with a value that is never read
> and pkg is being re-assigned a little later on. The assignment is
^^^ pkt
> redundant and hence can be removed.
>
> Addresses-Coverity: ("Ununsed value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt
2019-08-27 11:29 [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt Colin King
2019-08-28 9:14 ` Sergei Shtylyov
@ 2019-08-28 21:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-08-28 21:49 UTC (permalink / raw)
To: colin.king; +Cc: m.grzeschik, netdev, kernel-janitors, linux-kernel
Please fix the typo spotted by Sergei.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-28 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-27 11:29 [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt Colin King
2019-08-28 9:14 ` Sergei Shtylyov
2019-08-28 21:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).