From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, parav@mellanox.com,
yuvalav@mellanox.com, jgg@ziepe.ca, saeedm@mellanox.com,
leon@kernel.org, andrew.gospodarek@broadcom.com,
michael.chan@broadcom.com, moshe@mellanox.com, ayal@mellanox.com,
eranbe@mellanox.com, vladbu@mellanox.com, kliteyn@mellanox.com,
dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
tariqt@mellanox.com, oss-drivers@netronome.com,
snelson@pensando.io, drivers@pensando.io, aelior@marvell.com,
GR-everest-linux-l2@marvell.com, grygorii.strashko@ti.com,
mlxsw@mellanox.com, idosch@mellanox.com, markz@mellanox.com,
jacob.e.keller@intel.com, valex@mellanox.com,
linyunsheng@huawei.com, lihong.yang@intel.com,
vikas.gupta@broadcom.com, magnus.karlsson@intel.com
Subject: Re: [RFC] current devlink extension plan for NICs
Date: Fri, 27 Mar 2020 08:47:36 +0100 [thread overview]
Message-ID: <20200327074736.GJ11304@nanopsycho.orion> (raw)
In-Reply-To: <20200326133001.1b2694c9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Thu, Mar 26, 2020 at 09:30:01PM CET, kuba@kernel.org wrote:
>On Thu, 26 Mar 2020 15:51:46 +0100 Jiri Pirko wrote:
>> Thu, Mar 26, 2020 at 03:47:09PM CET, jiri@resnulli.us wrote:
>> >>> >> >> $ devlink slice show
>> >>> >> >> pci/0000:06:00.0/0: flavour physical pfnum 0 port 0 state active
>> >>> >> >> pci/0000:06:00.0/1: flavour physical pfnum 1 port 1 state active
>> >>> >> >> pci/0000:06:00.0/2: flavour pcivf pfnum 0 vfnum 0 port 2 hw_addr 10:22:33:44:55:66 state active
>> >>> >> >> pci/0000:06:00.0/3: flavour pcivf pfnum 0 vfnum 1 port 3 hw_addr aa:bb:cc:dd:ee:ff state active
>> >>> >> >> pci/0000:06:00.0/4: flavour pcivf pfnum 1 vfnum 0 port 4 hw_addr 10:22:33:44:55:88 state active
>> >>> >> >> pci/0000:06:00.0/5: flavour pcivf pfnum 1 vfnum 1 port 5 hw_addr 10:22:33:44:55:99 state active
>> >>> >> >> pci/0000:06:00.0/6: flavour pcivf pfnum 1 vfnum 2
>> >>> >> >
>> >>> >> >What are slices?
>> >>> >>
>> >>> >> Slice is basically a piece of ASIC. pf/vf/sf. They serve for
>> >>> >> configuration of the "other side of the wire". Like the mac. Hypervizor
>> >>> >> admin can use the slite to set the mac address of a VF which is in the
>> >>> >> virtual machine. Basically this should be a replacement of "ip vf"
>> >>> >> command.
>> >>> >
>> >>> >I lost my mail archive but didn't we already have a long thread with
>> >>> >Parav about this?
>> >>>
>> >>> I believe so.
>> >>
>> >>Oh, well. I still don't see the need for it :( If it's one to one with
>> >>ports why add another API, and have to do some cross linking to get
>> >>from one to the other?
>> >>
>> >>I'd much rather resources hanging off the port.
>> >
>> >Yeah, I was originally saying exactly the same as you do. However, there
>> >might be slices that are not related to any port. Like NVE. Port does
>> >not make sense in that world. It is just a slice of device.
>> >Do we want to model those as "ports" too? Maybe. What do you think?
>>
>> Also, the slice is to model "the other side of the wire":
>>
>> eswitch - devlink_port ...... slice
>>
>> If we have it under devlink port, it would probably
>> have to be nested object to have the clean cut.
>
>So the queues, interrupts, and other resources are also part
>of the slice then?
Yep, that seems to make sense.
>
>How do slice parameters like rate apply to NVMe?
Not really.
>
>Are ports always ethernet? and slices also cover endpoints with
>transport stack offloaded to the NIC?
devlink_port now can be either "ethernet" or "infiniband". Perhaps,
there can be port type "nve" which would contain only some of the
config options and would not have a representor "netdev/ibdev" linked.
I don't know.
next prev parent reply other threads:[~2020-03-27 7:47 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 19:27 [RFC] current devlink extension plan for NICs Jiri Pirko
2020-03-20 3:32 ` Jakub Kicinski
2020-03-20 7:35 ` Jiri Pirko
2020-03-20 21:25 ` Jakub Kicinski
2020-03-21 9:07 ` Parav Pandit
2020-03-23 19:31 ` Jakub Kicinski
2020-03-23 22:50 ` Jason Gunthorpe
2020-03-24 3:41 ` Jakub Kicinski
2020-03-24 13:43 ` Jason Gunthorpe
2020-03-24 5:36 ` Parav Pandit
2020-03-21 9:35 ` Jiri Pirko
2020-03-23 19:21 ` Jakub Kicinski
2020-03-23 22:06 ` Jason Gunthorpe
2020-03-24 3:56 ` Jakub Kicinski
2020-03-24 13:20 ` Jason Gunthorpe
2020-03-26 14:37 ` Jiri Pirko
2020-03-26 14:43 ` Jiri Pirko
2020-03-26 14:47 ` Jiri Pirko
2020-03-26 14:51 ` Jiri Pirko
2020-03-26 20:30 ` Jakub Kicinski
2020-03-27 7:47 ` Jiri Pirko [this message]
2020-03-27 16:38 ` Jakub Kicinski
2020-03-27 18:49 ` Samudrala, Sridhar
2020-03-27 19:10 ` Jakub Kicinski
2020-03-27 19:45 ` Saeed Mahameed
2020-03-27 20:42 ` Jakub Kicinski
2020-03-30 9:07 ` Parav Pandit
2020-04-08 6:10 ` Parav Pandit
2020-03-27 20:47 ` Samudrala, Sridhar
2020-03-27 20:59 ` Jakub Kicinski
2020-03-30 7:09 ` Parav Pandit
2020-03-30 7:48 ` Parav Pandit
2020-03-30 19:36 ` Jakub Kicinski
2020-03-31 7:45 ` Parav Pandit
2020-03-31 17:32 ` Jakub Kicinski
2020-04-01 7:32 ` Parav Pandit
2020-04-01 20:12 ` Jakub Kicinski
2020-04-02 6:16 ` Jiri Pirko
2020-04-08 5:10 ` Parav Pandit
2020-04-08 5:07 ` Parav Pandit
2020-04-08 16:59 ` Jakub Kicinski
2020-04-08 18:13 ` Parav Pandit
2020-04-09 2:07 ` Jakub Kicinski
2020-04-09 6:43 ` Parav Pandit
2020-03-30 5:30 ` Parav Pandit
2020-03-26 14:59 ` Jiri Pirko
2020-03-23 23:32 ` Andy Gospodarek
2020-03-24 0:11 ` Jason Gunthorpe
2020-03-24 5:53 ` Parav Pandit
2020-03-23 21:32 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327074736.GJ11304@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=ayal@mellanox.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=drivers@pensando.io \
--cc=eranbe@mellanox.com \
--cc=fmanlunas@marvell.com \
--cc=grygorii.strashko@ti.com \
--cc=idosch@mellanox.com \
--cc=jacob.e.keller@intel.com \
--cc=jgg@ziepe.ca \
--cc=kliteyn@mellanox.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=lihong.yang@intel.com \
--cc=linyunsheng@huawei.com \
--cc=magnus.karlsson@intel.com \
--cc=markz@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=parav@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=sburla@marvell.com \
--cc=snelson@pensando.io \
--cc=tariqt@mellanox.com \
--cc=valex@mellanox.com \
--cc=vikas.gupta@broadcom.com \
--cc=vladbu@mellanox.com \
--cc=yuvalav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).