From: David Miller <davem@davemloft.net>
To: vee.khee.wong@intel.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, boon.leong.ong@intel.com,
weifeng.voon@intel.com
Subject: Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable
Date: Thu, 23 Apr 2020 15:53:29 -0700 (PDT) [thread overview]
Message-ID: <20200423.155329.1710757370582804428.davem@davemloft.net> (raw)
In-Reply-To: <20200423070026.26200-1-vee.khee.wong@intel.com>
From: Wong Vee Khee <vee.khee.wong@intel.com>
Date: Thu, 23 Apr 2020 15:00:26 +0800
> From: "Chuah, Kim Tatt" <kim.tatt.chuah@intel.com>
>
> Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail
> Queuing. This option allows packets that fail VLAN filter to be routed
> to a specific Rx queue when Receive All is also set.
>
> When this option is enabled:
> - Enable VFFQ only when entering promiscuous mode, because Receive All
> will pass up all rx packets that failed address filtering (similar to
> promiscuous mode).
> - VLAN-promiscuous mode is never entered to allow rx packet to fail VLAN
> filters and get routed to selected VFFQ Rx queue.
>
> Reviewed-by: Voon Weifeng <weifeng.voon@intel.com>
> Reviewed-by: Ong Boon Leong <boon.leong.ong@intel.com>
> Signed-off-by: Chuah, Kim Tatt <kim.tatt.chuah@intel.com>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
Why would you be setting this with a platform attribute? Even if the
capability exists, wouldn't you want the user to be able to choose
to opt out?
next prev parent reply other threads:[~2020-04-23 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 7:00 [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable Wong Vee Khee
2020-04-23 22:53 ` David Miller [this message]
2020-05-06 3:31 ` Wong, Vee Khee
2020-09-25 9:40 [PATCH net-next 0/1] net: stmmac: Enable VLAN filter fail queue for Intel platform data Wong Vee Khee
2020-09-25 9:40 ` [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable Wong Vee Khee
2020-09-25 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423.155329.1710757370582804428.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=boon.leong.ong@intel.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).