From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Doug Berger <opendmb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting
Date: Wed, 13 May 2020 15:49:25 +0200 [thread overview]
Message-ID: <20200513134925.GE499265@lunn.ch> (raw)
In-Reply-To: <20200513092050.GB1605@shell.armlinux.org.uk>
> So, I think consistency of implementation is more important than fixing
> this; the current behaviour has been established for many years now.
Hi Russell, Doug
With netlink ethtool we have the possibility of adding a new API to
control this. And we can leave the IOCTL API alone, and the current
ethtool commands. We can add a new command to ethtool which uses the new API.
Question is, do we want to do this? Would we be introducing yet more
confusion, rather than making the situation better?
Andrew
next prev parent reply other threads:[~2020-05-13 13:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 0:24 [PATCH net-next 0/4] Extend phylib implementation of pause support Doug Berger
2020-05-12 0:24 ` [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting Doug Berger
2020-05-12 0:47 ` Andrew Lunn
2020-05-12 18:31 ` Doug Berger
2020-05-12 18:37 ` Andrew Lunn
2020-05-12 18:55 ` Russell King - ARM Linux admin
2020-05-13 3:48 ` Doug Berger
2020-05-13 5:34 ` Russell King - ARM Linux admin
2020-05-13 9:20 ` Russell King - ARM Linux admin
2020-05-13 13:49 ` Andrew Lunn [this message]
2020-05-13 14:59 ` Michal Kubecek
2020-05-13 17:14 ` Russell King - ARM Linux admin
2020-05-13 22:09 ` Doug Berger
2020-05-13 21:31 ` Doug Berger
2020-05-13 21:27 ` Doug Berger
2020-05-12 19:08 ` Michal Kubecek
2020-05-13 2:37 ` Doug Berger
2020-05-12 3:16 ` Florian Fainelli
2020-05-12 0:24 ` [PATCH net-next 2/4] net: add autoneg parameter to linkmode_set_pause Doug Berger
2020-05-12 0:24 ` [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause Doug Berger
2020-05-12 0:51 ` Andrew Lunn
2020-05-12 18:46 ` Doug Berger
2020-05-12 3:22 ` Florian Fainelli
2020-05-13 9:42 ` Russell King - ARM Linux admin
2020-05-13 21:39 ` Doug Berger
2020-05-12 0:24 ` [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control Doug Berger
2020-05-12 3:24 ` Florian Fainelli
2020-05-13 9:52 ` Russell King - ARM Linux admin
2020-05-13 22:00 ` Doug Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513134925.GE499265@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).