From: kernel test robot <lkp@intel.com>
To: David Thompson <dthompson@mellanox.com>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, davem@davemloft.net, kuba@kernel.org,
jiri@mellanox.com, David Thompson <dthompson@mellanox.com>,
Asmaa Mnebhi <asmaa@mellanox.com>
Subject: Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver
Date: Thu, 30 Jul 2020 12:03:48 +0800 [thread overview]
Message-ID: <202007301113.u2cZbVCv%lkp@intel.com> (raw)
In-Reply-To: <1596047355-28777-1-git-send-email-dthompson@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 2036 bytes --]
Hi David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/David-Thompson/Add-Mellanox-BlueField-Gigabit-Ethernet-driver/20200730-023011
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 490ed0b908d371cd9ab63fc142213e5d02d810ee
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c: In function 'mlxbf_gige_initial_mac':
>> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:1093:6: warning: variable 'status' set but not used [-Wunused-but-set-variable]
1093 | int status;
| ^~~~~~
vim +/status +1093 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
1088
1089 static void mlxbf_gige_initial_mac(struct mlxbf_gige *priv)
1090 {
1091 u8 mac[ETH_ALEN];
1092 u64 local_mac;
> 1093 int status;
1094
1095 status = mlxbf_gige_get_mac_rx_filter(priv, MLXBF_GIGE_LOCAL_MAC_FILTER_IDX,
1096 &local_mac);
1097 mlxbf_gige_u64_to_mac(mac, local_mac);
1098
1099 if (is_valid_ether_addr(mac)) {
1100 ether_addr_copy(priv->netdev->dev_addr, mac);
1101 } else {
1102 /* Provide a random MAC if for some reason the device has
1103 * not been configured with a valid MAC address already.
1104 */
1105 eth_hw_addr_random(priv->netdev);
1106 }
1107
1108 local_mac = mlxbf_gige_mac_to_u64(priv->netdev->dev_addr);
1109 mlxbf_gige_set_mac_rx_filter(priv, MLXBF_GIGE_LOCAL_MAC_FILTER_IDX,
1110 local_mac);
1111 }
1112
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74148 bytes --]
next prev parent reply other threads:[~2020-07-30 4:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 18:29 [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver David Thompson
2020-07-29 19:41 ` David Thompson
2020-07-29 20:31 ` David Miller
2020-07-29 20:49 ` Jakub Kicinski
2020-07-30 4:03 ` kernel test robot [this message]
2020-07-31 17:42 ` Andrew Lunn
[not found] ` <VI1PR05MB4110070900CF42CB3E18983EDA4E0@VI1PR05MB4110.eurprd05.prod.outlook.com>
2020-07-31 19:54 ` Andrew Lunn
2020-07-31 21:38 ` Asmaa Mnebhi
2020-08-01 1:14 ` Andrew Lunn
2020-08-03 14:23 ` Asmaa Mnebhi
2020-08-11 19:53 ` Asmaa Mnebhi
2020-08-11 20:06 ` Andrew Lunn
2020-08-12 20:37 ` Asmaa Mnebhi
2020-08-12 21:34 ` Andrew Lunn
2020-07-31 18:37 ` Andrew Lunn
2020-08-28 14:29 ` Asmaa Mnebhi
2020-07-31 18:38 ` Andrew Lunn
2020-08-28 14:24 ` Asmaa Mnebhi
2020-08-28 14:36 ` Andrew Lunn
2020-07-31 18:41 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007301113.u2cZbVCv%lkp@intel.com \
--to=lkp@intel.com \
--cc=asmaa@mellanox.com \
--cc=davem@davemloft.net \
--cc=dthompson@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).