* [PATCH v1] qed: Use %pM format specifier for MAC addresses
@ 2020-07-30 15:59 Andy Shevchenko
2020-07-31 23:48 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-07-30 15:59 UTC (permalink / raw)
To: Ariel Elior, GR-everest-linux-l2, Alexander Lobakin, netdev,
David S. Miller, Jakub Kicinski
Cc: Andy Shevchenko
Convert to %pM instead of using custom code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ethernet/qlogic/qed/qed_mcp.c | 5 ++---
drivers/net/ethernet/qlogic/qed/qed_sriov.c | 6 ++----
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
index 988d84564849..5be08f83e0aa 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
@@ -2518,11 +2518,10 @@ int qed_mcp_fill_shmem_func_info(struct qed_hwfn *p_hwfn,
}
DP_VERBOSE(p_hwfn, (QED_MSG_SP | NETIF_MSG_IFUP),
- "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %02x:%02x:%02x:%02x:%02x:%02x wwn port %llx node %llx ovlan %04x wol %02x\n",
+ "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %pM wwn port %llx node %llx ovlan %04x wol %02x\n",
info->pause_on_host, info->protocol,
info->bandwidth_min, info->bandwidth_max,
- info->mac[0], info->mac[1], info->mac[2],
- info->mac[3], info->mac[4], info->mac[5],
+ info->mac,
info->wwn_port, info->wwn_node,
info->ovlan, (u8)p_hwfn->hw_info.b_wol_support);
diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
index aa215eeeb4df..9489089706fe 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
@@ -3276,14 +3276,12 @@ static void qed_iov_vf_mbx_ucast_filter(struct qed_hwfn *p_hwfn,
DP_VERBOSE(p_hwfn,
QED_MSG_IOV,
- "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %02x:%02x:%02x:%02x:%02x:%02x, vlan 0x%04x\n",
+ "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %pM, vlan 0x%04x\n",
vf->abs_vf_id, params.opcode, params.type,
params.is_rx_filter ? "RX" : "",
params.is_tx_filter ? "TX" : "",
params.vport_to_add_to,
- params.mac[0], params.mac[1],
- params.mac[2], params.mac[3],
- params.mac[4], params.mac[5], params.vlan);
+ params.mac, params.vlan);
if (!vf->vport_instance) {
DP_VERBOSE(p_hwfn,
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] qed: Use %pM format specifier for MAC addresses
2020-07-30 15:59 [PATCH v1] qed: Use %pM format specifier for MAC addresses Andy Shevchenko
@ 2020-07-31 23:48 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-07-31 23:48 UTC (permalink / raw)
To: andriy.shevchenko; +Cc: aelior, GR-everest-linux-l2, alobakin, netdev, kuba
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 30 Jul 2020 18:59:20 +0300
> Convert to %pM instead of using custom code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] qed: Use %pM format specifier for MAC addresses
2020-07-30 16:26 Alexander Lobakin
@ 2020-08-01 12:21 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2020-08-01 12:21 UTC (permalink / raw)
To: Alexander Lobakin
Cc: Ariel Elior, GR-everest-linux-l2, netdev, David S. Miller,
Jakub Kicinski, linux-kernel
On Thu, Jul 30, 2020 at 04:26:17PM +0000, Alexander Lobakin wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Thu, 30 Jul 2020 18:59:20 +0300
>
> > Convert to %pM instead of using custom code.
> Thanks!
>
> Acked-by: Alexander Lobakin <alobakin@pm.me>
Thanks, but no-one sees this properly (seems broken message-id -> in-reply-to
chain). You have to fix your email.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] qed: Use %pM format specifier for MAC addresses
@ 2020-07-30 16:26 Alexander Lobakin
2020-08-01 12:21 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Lobakin @ 2020-07-30 16:26 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Alexander Lobakin, Ariel Elior, GR-everest-linux-l2, netdev,
David S. Miller, Jakub Kicinski, linux-kernel
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 30 Jul 2020 18:59:20 +0300
> Convert to %pM instead of using custom code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_mcp.c | 5 ++---
> drivers/net/ethernet/qlogic/qed/qed_sriov.c | 6 ++----
> 2 files changed, 4 insertions(+), 7 deletions(-)
Thanks!
Acked-by: Alexander Lobakin <alobakin@pm.me>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> index 988d84564849..5be08f83e0aa 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> @@ -2518,11 +2518,10 @@ int qed_mcp_fill_shmem_func_info(struct qed_hwfn *p_hwfn,
> }
>
> DP_VERBOSE(p_hwfn, (QED_MSG_SP | NETIF_MSG_IFUP),
> - "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %02x:%02x:%02x:%02x:%02x:%02x wwn port %llx node %llx ovlan %04x wol %02x\n",
> + "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %pM wwn port %llx node %llx ovlan %04x wol %02x\n",
> info->pause_on_host, info->protocol,
> info->bandwidth_min, info->bandwidth_max,
> - info->mac[0], info->mac[1], info->mac[2],
> - info->mac[3], info->mac[4], info->mac[5],
> + info->mac,
> info->wwn_port, info->wwn_node,
> info->ovlan, (u8)p_hwfn->hw_info.b_wol_support);
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> index aa215eeeb4df..9489089706fe 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> @@ -3276,14 +3276,12 @@ static void qed_iov_vf_mbx_ucast_filter(struct qed_hwfn *p_hwfn,
>
> DP_VERBOSE(p_hwfn,
> QED_MSG_IOV,
> - "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %02x:%02x:%02x:%02x:%02x:%02x, vlan 0x%04x\n",
> + "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %pM, vlan 0x%04x\n",
> vf->abs_vf_id, params.opcode, params.type,
> params.is_rx_filter ? "RX" : "",
> params.is_tx_filter ? "TX" : "",
> params.vport_to_add_to,
> - params.mac[0], params.mac[1],
> - params.mac[2], params.mac[3],
> - params.mac[4], params.mac[5], params.vlan);
> + params.mac, params.vlan);
>
> if (!vf->vport_instance) {
> DP_VERBOSE(p_hwfn,
> --
> 2.27.0
Al
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-01 12:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 15:59 [PATCH v1] qed: Use %pM format specifier for MAC addresses Andy Shevchenko
2020-07-31 23:48 ` David Miller
2020-07-30 16:26 Alexander Lobakin
2020-08-01 12:21 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).