* [PATCH ethtool] ethtool.spec: Add bash completion script
@ 2020-08-03 13:23 Roi Dayan
2020-08-04 13:12 ` Michal Kubecek
0 siblings, 1 reply; 2+ messages in thread
From: Roi Dayan @ 2020-08-03 13:23 UTC (permalink / raw)
To: Michal Kubecek; +Cc: netdev, Roi Dayan
After the additon of the bash completion script, packaging
using the default spec file fails for installed but not packaged
error. so package it.
Fixes: 9b802643d7bd ("ethtool: Add bash-completion script")
Signed-off-by: Roi Dayan <roid@mellanox.com>
---
ethtool.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/ethtool.spec.in b/ethtool.spec.in
index 9c01b07abf2b..75f9be6aafa6 100644
--- a/ethtool.spec.in
+++ b/ethtool.spec.in
@@ -34,6 +34,7 @@ make install DESTDIR=${RPM_BUILD_ROOT}
%defattr(-,root,root)
%{_sbindir}/ethtool
%{_mandir}/man8/ethtool.8*
+%{_datadir}/bash-completion/completions/ethtool
%doc AUTHORS COPYING NEWS README
--
2.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ethtool] ethtool.spec: Add bash completion script
2020-08-03 13:23 [PATCH ethtool] ethtool.spec: Add bash completion script Roi Dayan
@ 2020-08-04 13:12 ` Michal Kubecek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Kubecek @ 2020-08-04 13:12 UTC (permalink / raw)
To: Roi Dayan; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Mon, Aug 03, 2020 at 04:23:38PM +0300, Roi Dayan wrote:
> After the additon of the bash completion script, packaging
> using the default spec file fails for installed but not packaged
> error. so package it.
>
> Fixes: 9b802643d7bd ("ethtool: Add bash-completion script")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
Applied, thank you. We are using a heavily modified specfile in openSUSE
so I never noticed. Added rpmbuild to my check script now.
Michal
> ---
> ethtool.spec.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ethtool.spec.in b/ethtool.spec.in
> index 9c01b07abf2b..75f9be6aafa6 100644
> --- a/ethtool.spec.in
> +++ b/ethtool.spec.in
> @@ -34,6 +34,7 @@ make install DESTDIR=${RPM_BUILD_ROOT}
> %defattr(-,root,root)
> %{_sbindir}/ethtool
> %{_mandir}/man8/ethtool.8*
> +%{_datadir}/bash-completion/completions/ethtool
> %doc AUTHORS COPYING NEWS README
>
>
> --
> 2.8.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-04 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 13:23 [PATCH ethtool] ethtool.spec: Add bash completion script Roi Dayan
2020-08-04 13:12 ` Michal Kubecek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).