netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Awogbemila <awogbemila@google.com>
To: netdev@vger.kernel.org
Cc: Kuo Zhao <kuozhao@google.com>, Yangchun Fu <yangchun@google.com>,
	David Awogbemila <awogbemila@google.com>
Subject: [PATCH net-next v2 1/9] gve: Get and set Rx copybreak via ethtool
Date: Tue,  1 Sep 2020 14:51:41 -0700	[thread overview]
Message-ID: <20200901215149.2685117-2-awogbemila@google.com> (raw)
In-Reply-To: <20200901215149.2685117-1-awogbemila@google.com>

From: Kuo Zhao <kuozhao@google.com>

This adds support for getting and setting the RX copybreak
value via ethtool.

Reviewed-by: Yangchun Fu <yangchun@google.com>
Signed-off-by: Kuo Zhao <kuozhao@google.com>
Signed-off-by: David Awogbemila <awogbemila@google.com>
---
 drivers/net/ethernet/google/gve/gve_ethtool.c | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
index d8fa816f4473..1a80d38e66ec 100644
--- a/drivers/net/ethernet/google/gve/gve_ethtool.c
+++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
@@ -230,6 +230,38 @@ static int gve_user_reset(struct net_device *netdev, u32 *flags)
 	return -EOPNOTSUPP;
 }
 
+static int gve_get_tunable(struct net_device *netdev,
+			   const struct ethtool_tunable *etuna, void *value)
+{
+	struct gve_priv *priv = netdev_priv(netdev);
+
+	switch (etuna->id) {
+	case ETHTOOL_RX_COPYBREAK:
+		*(u32 *)value = priv->rx_copybreak;
+		return 0;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
+static int gve_set_tunable(struct net_device *netdev,
+			   const struct ethtool_tunable *etuna, const void *value)
+{
+	struct gve_priv *priv = netdev_priv(netdev);
+	u32 len;
+
+	switch (etuna->id) {
+	case ETHTOOL_RX_COPYBREAK:
+		len = *(u32 *)value;
+		if (len > PAGE_SIZE / 2)
+			return -EINVAL;
+		priv->rx_copybreak = len;
+		return 0;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
 const struct ethtool_ops gve_ethtool_ops = {
 	.get_drvinfo = gve_get_drvinfo,
 	.get_strings = gve_get_strings,
@@ -242,4 +274,6 @@ const struct ethtool_ops gve_ethtool_ops = {
 	.get_link = ethtool_op_get_link,
 	.get_ringparam = gve_get_ringparam,
 	.reset = gve_user_reset,
+	.get_tunable = gve_get_tunable,
+	.set_tunable = gve_set_tunable,
 };
-- 
2.28.0.402.g5ffc5be6b7-goog


  reply	other threads:[~2020-09-01 21:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 21:51 [PATCH net-next v2 0/9] Add GVE Features David Awogbemila
2020-09-01 21:51 ` David Awogbemila [this message]
2020-09-01 22:06   ` [PATCH net-next v2 1/9] gve: Get and set Rx copybreak via ethtool Andrew Lunn
2020-09-01 21:51 ` [PATCH net-next v2 2/9] gve: Add stats for gve David Awogbemila
2020-09-02  0:28   ` Jakub Kicinski
2020-09-01 21:51 ` [PATCH net-next v2 3/9] gve: Use dev_info/err instead of netif_info/err David Awogbemila
2020-09-01 22:08   ` Andrew Lunn
2020-09-02 18:43     ` David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 4/9] gve: Add support for dma_mask register David Awogbemila
2020-09-02  0:34   ` Jakub Kicinski
2020-09-02 18:42     ` David Awogbemila
2020-09-02 23:08       ` David Miller
2020-09-03 16:31         ` David Awogbemila
2020-09-03 18:28           ` Jakub Kicinski
2020-09-01 21:51 ` [PATCH net-next v2 5/9] gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags David Awogbemila
2020-09-02  0:45   ` Jakub Kicinski
2020-09-02 20:39     ` David Awogbemila
2020-09-03  0:05   ` David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 6/9] gve: NIC stats for report-stats and for ethtool David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 7/9] gve: Batch AQ commands for creating and destroying queues David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 8/9] gve: Use link status register to report link status David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 9/9] gve: Enable Link Speed Reporting in the driver David Awogbemila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901215149.2685117-2-awogbemila@google.com \
    --to=awogbemila@google.com \
    --cc=kuozhao@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=yangchun@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).