From: David Awogbemila <awogbemila@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Catherine Sullivan <csully@google.com>,
Yangchun Fu <yangchun@google.com>
Subject: Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register
Date: Wed, 2 Sep 2020 11:42:37 -0700 [thread overview]
Message-ID: <CAL9ddJciz2MD8CYqdbFLhYCKFk=ouHzzEndQwmcfQ-UqNNgJxQ@mail.gmail.com> (raw)
In-Reply-To: <20200901173410.5ce6a087@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Tue, Sep 1, 2020 at 5:34 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 1 Sep 2020 14:51:44 -0700 David Awogbemila wrote:
> > From: Catherine Sullivan <csully@google.com>
> >
> > Add the dma_mask register and read it to set the dma_masks.
> > gve_alloc_page will alloc_page with:
> > GFP_DMA if priv->dma_mask is 24,
> > GFP_DMA32 if priv->dma_mask is 32.
>
> What about Andrew's request to CC someone who can review this for
> correctness?
I didn't realize I needed to CC someone. How may I find suitable reviewers?
>
> What's your use case here? Do you really have devices with 24bit
> addressing?
I don't think there is a specific 24-bit device in mind here, only
that we have seen 32-bit addressing use cases where the guest ran out
of SWIOTLB space and restricting to GFP_DMA32 helped.. so we thought
it would be natural for the driver to handle the 24 bit case in case
it ever came along.
next prev parent reply other threads:[~2020-09-02 18:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:51 [PATCH net-next v2 0/9] Add GVE Features David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 1/9] gve: Get and set Rx copybreak via ethtool David Awogbemila
2020-09-01 22:06 ` Andrew Lunn
2020-09-01 21:51 ` [PATCH net-next v2 2/9] gve: Add stats for gve David Awogbemila
2020-09-02 0:28 ` Jakub Kicinski
2020-09-01 21:51 ` [PATCH net-next v2 3/9] gve: Use dev_info/err instead of netif_info/err David Awogbemila
2020-09-01 22:08 ` Andrew Lunn
2020-09-02 18:43 ` David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 4/9] gve: Add support for dma_mask register David Awogbemila
2020-09-02 0:34 ` Jakub Kicinski
2020-09-02 18:42 ` David Awogbemila [this message]
2020-09-02 23:08 ` David Miller
2020-09-03 16:31 ` David Awogbemila
2020-09-03 18:28 ` Jakub Kicinski
2020-09-01 21:51 ` [PATCH net-next v2 5/9] gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags David Awogbemila
2020-09-02 0:45 ` Jakub Kicinski
2020-09-02 20:39 ` David Awogbemila
2020-09-03 0:05 ` David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 6/9] gve: NIC stats for report-stats and for ethtool David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 7/9] gve: Batch AQ commands for creating and destroying queues David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 8/9] gve: Use link status register to report link status David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 9/9] gve: Enable Link Speed Reporting in the driver David Awogbemila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL9ddJciz2MD8CYqdbFLhYCKFk=ouHzzEndQwmcfQ-UqNNgJxQ@mail.gmail.com' \
--to=awogbemila@google.com \
--cc=csully@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangchun@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).