netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Allen Pais <allen.lkml@gmail.com>
Subject: Re: [PATCH net-next] net/sched: get rid of qdisc->padded
Date: Thu, 8 Oct 2020 17:18:46 -0700	[thread overview]
Message-ID: <20201008171846.335b435a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201007165111.172419-1-eric.dumazet@gmail.com>

On Wed,  7 Oct 2020 09:51:11 -0700 Eric Dumazet wrote:
> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
> index 6c762457122fd0091cb0f2bf41bda73babc4ac12..d8fd8676fc724110630904909f64d7789f3a4b47 100644
> --- a/include/net/sch_generic.h
> +++ b/include/net/sch_generic.h
> @@ -91,7 +91,7 @@ struct Qdisc {
>  	struct net_rate_estimator __rcu *rate_est;
>  	struct gnet_stats_basic_cpu __percpu *cpu_bstats;
>  	struct gnet_stats_queue	__percpu *cpu_qstats;
> -	int			padded;
> +	int			pad;
>  	refcount_t		refcnt;
>  
>  	/*

Hi Eric!

Why keep the pad field? the member to lines down is
__cacheline_aligned, so we shouldn't have to manually 
push things out?

        struct gnet_stats_queue __percpu *cpu_qstats;                           
        int                     pad;                                            
        refcount_t              refcnt;                                         
                                                                                
        /*                                                                      
         * For performance sake on SMP, we put highly modified fields at the end                                                                               
         */                                                                     
        struct sk_buff_head     gso_skb ____cacheline_aligned_in_smp;  


  parent reply	other threads:[~2020-10-09  0:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 16:51 [PATCH net-next] net/sched: get rid of qdisc->padded Eric Dumazet
2020-10-08  1:42 ` Cong Wang
2020-10-09  0:18 ` Jakub Kicinski [this message]
2020-10-09  7:35   ` Eric Dumazet
2020-10-09 15:38     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008171846.335b435a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=allen.lkml@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).