From: Cong Wang <xiyou.wangcong@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Allen Pais <allen.lkml@gmail.com>
Subject: Re: [PATCH net-next] net/sched: get rid of qdisc->padded
Date: Wed, 7 Oct 2020 18:42:37 -0700 [thread overview]
Message-ID: <CAM_iQpXgjDwF0bO+vtJx7zqyApFRwkkL-qtakNCvwOp7c9pu3g@mail.gmail.com> (raw)
In-Reply-To: <20201007165111.172419-1-eric.dumazet@gmail.com>
On Wed, Oct 7, 2020 at 9:51 AM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> kmalloc() of sufficiently big portion of memory is cache-aligned
> in regular conditions. If some debugging options are used,
> there is no reason qdisc structures would need 64-byte alignment
> if most other kernel structures are not aligned.
>
> This get rid of QDISC_ALIGN and QDISC_ALIGNTO.
>
> Addition of privdata field will help implementing
> the reverse of qdisc_priv() and documents where
> the private data is.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Cong Wang <xiyou.wangcong@gmail.com>
> Cc: Allen Pais <allen.lkml@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks.
next prev parent reply other threads:[~2020-10-08 1:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 16:51 [PATCH net-next] net/sched: get rid of qdisc->padded Eric Dumazet
2020-10-08 1:42 ` Cong Wang [this message]
2020-10-09 0:18 ` Jakub Kicinski
2020-10-09 7:35 ` Eric Dumazet
2020-10-09 15:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpXgjDwF0bO+vtJx7zqyApFRwkkL-qtakNCvwOp7c9pu3g@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).