From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Robert Hancock <robert.hancock@calian.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config
Date: Wed, 21 Oct 2020 10:27:36 +0100 [thread overview]
Message-ID: <20201021092736.GI1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201020191249.756832-1-robert.hancock@calian.com>
On Tue, Oct 20, 2020 at 01:12:49PM -0600, Robert Hancock wrote:
> The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper
> operation in 1000BaseX mode. It should be safe to ensure this bit is
> disabled in phylink_mii_c22_pcs_config in all cases.
>
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Please re-send when netdev is open, thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-10-21 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 19:12 [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config Robert Hancock
2020-10-21 9:27 ` Russell King - ARM Linux admin [this message]
2020-10-21 17:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021092736.GI1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robert.hancock@calian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).