* [PATCH] net: dsa: mv88e6xxx: Fix memleak in mv88e6xxx_region_atu_snapshot
@ 2020-11-09 14:44 zhangxiaoxu
2020-11-09 14:46 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: zhangxiaoxu @ 2020-11-09 14:44 UTC (permalink / raw)
To: andrew, vivien.didelot, zhangxiaoxu5, f.fainelli, olteanv, davem,
kuba, netdev
When mv88e6xxx_fid_map return error, we lost free the table.
Fix it.
Fixes: bfb255428966 ("net: dsa: mv88e6xxx: Add devlink regions")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhangxiaoxu <zhangxiaoxu5@huawei.com>
---
drivers/net/dsa/mv88e6xxx/devlink.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/devlink.c b/drivers/net/dsa/mv88e6xxx/devlink.c
index 10cd1bfd81a0..ade04c036fd9 100644
--- a/drivers/net/dsa/mv88e6xxx/devlink.c
+++ b/drivers/net/dsa/mv88e6xxx/devlink.c
@@ -393,8 +393,10 @@ static int mv88e6xxx_region_atu_snapshot(struct devlink *dl,
mv88e6xxx_reg_lock(chip);
err = mv88e6xxx_fid_map(chip, fid_bitmap);
- if (err)
+ if (err) {
+ kfree(table);
goto out;
+ }
while (1) {
fid = find_next_bit(fid_bitmap, MV88E6XXX_N_FID, fid + 1);
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Fix memleak in mv88e6xxx_region_atu_snapshot
2020-11-09 14:44 [PATCH] net: dsa: mv88e6xxx: Fix memleak in mv88e6xxx_region_atu_snapshot zhangxiaoxu
@ 2020-11-09 14:46 ` Andrew Lunn
2020-11-11 1:50 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2020-11-09 14:46 UTC (permalink / raw)
To: zhangxiaoxu; +Cc: vivien.didelot, f.fainelli, olteanv, davem, kuba, netdev
On Mon, Nov 09, 2020 at 09:44:16AM -0500, zhangxiaoxu wrote:
> When mv88e6xxx_fid_map return error, we lost free the table.
>
> Fix it.
>
> Fixes: bfb255428966 ("net: dsa: mv88e6xxx: Add devlink regions")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhangxiaoxu <zhangxiaoxu5@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Fix memleak in mv88e6xxx_region_atu_snapshot
2020-11-09 14:46 ` Andrew Lunn
@ 2020-11-11 1:50 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-11 1:50 UTC (permalink / raw)
To: Andrew Lunn, zhangxiaoxu
Cc: vivien.didelot, f.fainelli, olteanv, davem, netdev
On Mon, 9 Nov 2020 15:46:57 +0100 Andrew Lunn wrote:
> On Mon, Nov 09, 2020 at 09:44:16AM -0500, zhangxiaoxu wrote:
> > When mv88e6xxx_fid_map return error, we lost free the table.
> >
> > Fix it.
> >
> > Fixes: bfb255428966 ("net: dsa: mv88e6xxx: Add devlink regions")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: zhangxiaoxu <zhangxiaoxu5@huawei.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-11 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 14:44 [PATCH] net: dsa: mv88e6xxx: Fix memleak in mv88e6xxx_region_atu_snapshot zhangxiaoxu
2020-11-09 14:46 ` Andrew Lunn
2020-11-11 1:50 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).