[PATCH net 1/1] qede: fix offload for IPIP tunnel packets

[PATCH net 1/1] qede: fix offload for IPIP tunnel packets

[Manish Chopra]

IPIP tunnels packets are unknown to device,
hence these packets are incorrectly parsed and
caused the packet corruption, so disable offlods
for such packets at run time.

Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c b/drivers/net/ethernet/qlogic/qede/qede_fp.c
index a2494bf..ca0ee29 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
@@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct sk_buff *skb,
 			      ntohs(udp_hdr(skb)->dest) != gnv_port))
 				return features & ~(NETIF_F_CSUM_MASK |
 						    NETIF_F_GSO_MASK);
+		} else if (l4_proto == IPPROTO_IPIP) {
+			/* IPIP tunnels are unknown to the device or at least unsupported natively,
+			 * offloads for them can't be done trivially, so disable them for such skb.
+			 */
+			return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK);
 		}
 	}
 
-- 
1.8.3.1

Re: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 21 Dec 2020 06:55:30 -0800 you wrote:
> IPIP tunnels packets are unknown to device,
> hence these packets are incorrectly parsed and
> caused the packet corruption, so disable offlods
> for such packets at run time.
> 
> Signed-off-by: Manish Chopra <manishc@marvell.com>
> Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> 
> [...]

Here is the summary with links:
  - [net,1/1] qede: fix offload for IPIP tunnel packets
    https://git.kernel.org/netdev/net/c/5d5647dad259

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

RE: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

[Manish Chopra]

> -----Original Message-----
> From: Manish Chopra <manishc@marvell.com>
> Sent: Monday, December 21, 2020 8:26 PM
> To: davem@davemloft.net
> Cc: netdev@vger.kernel.org; Ariel Elior <aelior@marvell.com>; Igor Russkikh
> <irusskikh@marvell.com>; Sudarsana Reddy Kalluru <skalluru@marvell.com>
> Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
> 
> IPIP tunnels packets are unknown to device, hence these packets are
> incorrectly parsed and caused the packet corruption, so disable offlods for
> such packets at run time.
> 
> Signed-off-by: Manish Chopra <manishc@marvell.com>
> Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> ---
>  drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> index a2494bf..ca0ee29 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> @@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct
> sk_buff *skb,
>  			      ntohs(udp_hdr(skb)->dest) != gnv_port))
>  				return features & ~(NETIF_F_CSUM_MASK |
>  						    NETIF_F_GSO_MASK);
> +		} else if (l4_proto == IPPROTO_IPIP) {
> +			/* IPIP tunnels are unknown to the device or at least
> unsupported natively,
> +			 * offloads for them can't be done trivially, so disable
> them for such skb.
> +			 */
> +			return features & ~(NETIF_F_CSUM_MASK |
> NETIF_F_GSO_MASK);
>  		}
>  	}
> 
> --
> 1.8.3.1

Hello Jakub,  can you please queue up for stable releases (specifically for long term linux 5.4)?

Thanks,
Manish

Re: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

[Jakub Kicinski]

On Thu, 24 Dec 2020 10:46:47 +0000 Manish Chopra wrote:
> > -----Original Message-----
> > From: Manish Chopra <manishc@marvell.com>
> > Sent: Monday, December 21, 2020 8:26 PM
> > To: davem@davemloft.net
> > Cc: netdev@vger.kernel.org; Ariel Elior <aelior@marvell.com>; Igor Russkikh
> > <irusskikh@marvell.com>; Sudarsana Reddy Kalluru <skalluru@marvell.com>
> > Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
> > 
> > IPIP tunnels packets are unknown to device, hence these packets are
> > incorrectly parsed and caused the packet corruption, so disable offlods for
> > such packets at run time.
> > 
> > Signed-off-by: Manish Chopra <manishc@marvell.com>
> > Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
> > Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> > ---
> >  drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > index a2494bf..ca0ee29 100644
> > --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > @@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct
> > sk_buff *skb,
> >  			      ntohs(udp_hdr(skb)->dest) != gnv_port))
> >  				return features & ~(NETIF_F_CSUM_MASK |
> >  						    NETIF_F_GSO_MASK);
> > +		} else if (l4_proto == IPPROTO_IPIP) {
> > +			/* IPIP tunnels are unknown to the device or at least
> > unsupported natively,
> > +			 * offloads for them can't be done trivially, so disable
> > them for such skb.
> > +			 */
> > +			return features & ~(NETIF_F_CSUM_MASK |
> > NETIF_F_GSO_MASK);
> >  		}
> >  	}
> 
> Hello Jakub,  can you please queue up for stable releases
> (specifically for long term linux 5.4)?

It's in the queue:

https://patchwork.kernel.org/bundle/netdev/stable/?state=*

I'll submit it later this week.