* [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
@ 2020-12-21 14:55 Manish Chopra
2020-12-23 3:50 ` patchwork-bot+netdevbpf
2020-12-24 10:46 ` Manish Chopra
0 siblings, 2 replies; 4+ messages in thread
From: Manish Chopra @ 2020-12-21 14:55 UTC (permalink / raw)
To: davem; +Cc: netdev, aelior, irusskikh, skalluru
IPIP tunnels packets are unknown to device,
hence these packets are incorrectly parsed and
caused the packet corruption, so disable offlods
for such packets at run time.
Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c b/drivers/net/ethernet/qlogic/qede/qede_fp.c
index a2494bf..ca0ee29 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
@@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct sk_buff *skb,
ntohs(udp_hdr(skb)->dest) != gnv_port))
return features & ~(NETIF_F_CSUM_MASK |
NETIF_F_GSO_MASK);
+ } else if (l4_proto == IPPROTO_IPIP) {
+ /* IPIP tunnels are unknown to the device or at least unsupported natively,
+ * offloads for them can't be done trivially, so disable them for such skb.
+ */
+ return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK);
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
2020-12-21 14:55 [PATCH net 1/1] qede: fix offload for IPIP tunnel packets Manish Chopra
@ 2020-12-23 3:50 ` patchwork-bot+netdevbpf
2020-12-24 10:46 ` Manish Chopra
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-12-23 3:50 UTC (permalink / raw)
To: Manish Chopra; +Cc: davem, netdev, aelior, irusskikh, skalluru
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 21 Dec 2020 06:55:30 -0800 you wrote:
> IPIP tunnels packets are unknown to device,
> hence these packets are incorrectly parsed and
> caused the packet corruption, so disable offlods
> for such packets at run time.
>
> Signed-off-by: Manish Chopra <manishc@marvell.com>
> Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
>
> [...]
Here is the summary with links:
- [net,1/1] qede: fix offload for IPIP tunnel packets
https://git.kernel.org/netdev/net/c/5d5647dad259
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
2020-12-21 14:55 [PATCH net 1/1] qede: fix offload for IPIP tunnel packets Manish Chopra
2020-12-23 3:50 ` patchwork-bot+netdevbpf
@ 2020-12-24 10:46 ` Manish Chopra
2020-12-28 19:01 ` Jakub Kicinski
1 sibling, 1 reply; 4+ messages in thread
From: Manish Chopra @ 2020-12-24 10:46 UTC (permalink / raw)
To: kuba; +Cc: netdev, Ariel Elior, Igor Russkikh, Sudarsana Reddy Kalluru, gregkh
> -----Original Message-----
> From: Manish Chopra <manishc@marvell.com>
> Sent: Monday, December 21, 2020 8:26 PM
> To: davem@davemloft.net
> Cc: netdev@vger.kernel.org; Ariel Elior <aelior@marvell.com>; Igor Russkikh
> <irusskikh@marvell.com>; Sudarsana Reddy Kalluru <skalluru@marvell.com>
> Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
>
> IPIP tunnels packets are unknown to device, hence these packets are
> incorrectly parsed and caused the packet corruption, so disable offlods for
> such packets at run time.
>
> Signed-off-by: Manish Chopra <manishc@marvell.com>
> Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> ---
> drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> index a2494bf..ca0ee29 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> @@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct
> sk_buff *skb,
> ntohs(udp_hdr(skb)->dest) != gnv_port))
> return features & ~(NETIF_F_CSUM_MASK |
> NETIF_F_GSO_MASK);
> + } else if (l4_proto == IPPROTO_IPIP) {
> + /* IPIP tunnels are unknown to the device or at least
> unsupported natively,
> + * offloads for them can't be done trivially, so disable
> them for such skb.
> + */
> + return features & ~(NETIF_F_CSUM_MASK |
> NETIF_F_GSO_MASK);
> }
> }
>
> --
> 1.8.3.1
Hello Jakub, can you please queue up for stable releases (specifically for long term linux 5.4)?
Thanks,
Manish
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
2020-12-24 10:46 ` Manish Chopra
@ 2020-12-28 19:01 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-12-28 19:01 UTC (permalink / raw)
To: Manish Chopra
Cc: netdev, Ariel Elior, Igor Russkikh, Sudarsana Reddy Kalluru, gregkh
On Thu, 24 Dec 2020 10:46:47 +0000 Manish Chopra wrote:
> > -----Original Message-----
> > From: Manish Chopra <manishc@marvell.com>
> > Sent: Monday, December 21, 2020 8:26 PM
> > To: davem@davemloft.net
> > Cc: netdev@vger.kernel.org; Ariel Elior <aelior@marvell.com>; Igor Russkikh
> > <irusskikh@marvell.com>; Sudarsana Reddy Kalluru <skalluru@marvell.com>
> > Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
> >
> > IPIP tunnels packets are unknown to device, hence these packets are
> > incorrectly parsed and caused the packet corruption, so disable offlods for
> > such packets at run time.
> >
> > Signed-off-by: Manish Chopra <manishc@marvell.com>
> > Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
> > Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> > ---
> > drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > index a2494bf..ca0ee29 100644
> > --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> > @@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct
> > sk_buff *skb,
> > ntohs(udp_hdr(skb)->dest) != gnv_port))
> > return features & ~(NETIF_F_CSUM_MASK |
> > NETIF_F_GSO_MASK);
> > + } else if (l4_proto == IPPROTO_IPIP) {
> > + /* IPIP tunnels are unknown to the device or at least
> > unsupported natively,
> > + * offloads for them can't be done trivially, so disable
> > them for such skb.
> > + */
> > + return features & ~(NETIF_F_CSUM_MASK |
> > NETIF_F_GSO_MASK);
> > }
> > }
>
> Hello Jakub, can you please queue up for stable releases
> (specifically for long term linux 5.4)?
It's in the queue:
https://patchwork.kernel.org/bundle/netdev/stable/?state=*
I'll submit it later this week.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-28 19:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 14:55 [PATCH net 1/1] qede: fix offload for IPIP tunnel packets Manish Chopra
2020-12-23 3:50 ` patchwork-bot+netdevbpf
2020-12-24 10:46 ` Manish Chopra
2020-12-28 19:01 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).