From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, jacob.e.keller@intel.com,
roopa@nvidia.com, mlxsw@nvidia.com
Subject: [patch net-next RFC 03/10] devlink: implement line card active state
Date: Wed, 13 Jan 2021 13:12:15 +0100 [thread overview]
Message-ID: <20210113121222.733517-4-jiri@resnulli.us> (raw)
In-Reply-To: <20210113121222.733517-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@nvidia.com>
Allow driver to mark a lin ecards as active. Expose this state to the
userspace over devlink netlink interface with proper notifications.
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
include/net/devlink.h | 4 ++++
include/uapi/linux/devlink.h | 1 +
net/core/devlink.c | 46 ++++++++++++++++++++++++++++++++++++
3 files changed, 51 insertions(+)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 854abd53e9ea..ec00cd94c626 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -149,6 +149,7 @@ struct devlink_linecard {
void *priv;
enum devlink_linecard_state state;
const char *provisioned_type;
+ bool active;
};
/**
@@ -1444,6 +1445,9 @@ void devlink_linecard_destroy(struct devlink_linecard *linecard);
void devlink_linecard_provision_set(struct devlink_linecard *linecard,
u32 type_index);
void devlink_linecard_provision_clear(struct devlink_linecard *linecard);
+void devlink_linecard_activate(struct devlink_linecard *linecard);
+void devlink_linecard_deactivate(struct devlink_linecard *linecard);
+bool devlink_linecard_is_active(struct devlink_linecard *linecard);
int devlink_sb_register(struct devlink *devlink, unsigned int sb_index,
u32 size, u16 ingress_pools_count,
u16 egress_pools_count, u16 ingress_tc_count,
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index 4111ddcc000b..d961d31fe288 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -338,6 +338,7 @@ enum devlink_linecard_state {
DEVLINK_LINECARD_STATE_UNPROVISIONING,
DEVLINK_LINECARD_STATE_PROVISIONING,
DEVLINK_LINECARD_STATE_PROVISIONED,
+ DEVLINK_LINECARD_STATE_ACTIVE,
__DEVLINK_LINECARD_STATE_MAX,
DEVLINK_LINECARD_STATE_MAX = __DEVLINK_LINECARD_STATE_MAX - 1
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 434eecc310c3..9c76edf8c8af 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -8790,6 +8790,52 @@ void devlink_linecard_provision_clear(struct devlink_linecard *linecard)
}
EXPORT_SYMBOL_GPL(devlink_linecard_provision_clear);
+/**
+ * devlink_linecard_activate - Set linecard active
+ *
+ * @devlink_linecard: devlink linecard
+ */
+void devlink_linecard_activate(struct devlink_linecard *linecard)
+{
+ mutex_lock(&linecard->devlink->lock);
+ WARN_ON(linecard->state != DEVLINK_LINECARD_STATE_PROVISIONED);
+ linecard->state = DEVLINK_LINECARD_STATE_ACTIVE;
+ devlink_linecard_notify(linecard, DEVLINK_CMD_LINECARD_NEW);
+ mutex_unlock(&linecard->devlink->lock);
+}
+EXPORT_SYMBOL_GPL(devlink_linecard_activate);
+
+/**
+ * devlink_linecard_deactivate - Set linecard deactive
+ *
+ * @devlink_linecard: devlink linecard
+ */
+void devlink_linecard_deactivate(struct devlink_linecard *linecard)
+{
+ mutex_lock(&linecard->devlink->lock);
+ WARN_ON(linecard->state != DEVLINK_LINECARD_STATE_ACTIVE);
+ linecard->state = DEVLINK_LINECARD_STATE_PROVISIONED;
+ devlink_linecard_notify(linecard, DEVLINK_CMD_LINECARD_NEW);
+ mutex_unlock(&linecard->devlink->lock);
+}
+EXPORT_SYMBOL_GPL(devlink_linecard_deactivate);
+
+/**
+ * devlink_linecard_is_active - Check if active
+ *
+ * @devlink_linecard: devlink linecard
+ */
+bool devlink_linecard_is_active(struct devlink_linecard *linecard)
+{
+ bool active;
+
+ mutex_lock(&linecard->devlink->lock);
+ active = linecard->state == DEVLINK_LINECARD_STATE_ACTIVE;
+ mutex_unlock(&linecard->devlink->lock);
+ return active;
+}
+EXPORT_SYMBOL_GPL(devlink_linecard_is_active);
+
int devlink_sb_register(struct devlink *devlink, unsigned int sb_index,
u32 size, u16 ingress_pools_count,
u16 egress_pools_count, u16 ingress_tc_count,
--
2.26.2
next prev parent reply other threads:[~2021-01-13 12:13 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 12:12 [patch net-next RFC 00/10] introduce line card support for modular switch Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 01/10] devlink: add support to create line card and expose to user Jiri Pirko
2021-01-15 15:47 ` Ido Schimmel
2021-01-13 12:12 ` [patch net-next RFC 02/10] devlink: implement line card provisioning Jiri Pirko
2021-01-15 16:03 ` Ido Schimmel
2021-01-15 16:51 ` Jiri Pirko
2021-01-15 18:09 ` Ido Schimmel
2021-01-18 12:50 ` Jiri Pirko
2021-01-13 12:12 ` Jiri Pirko [this message]
2021-01-15 16:06 ` [patch net-next RFC 03/10] devlink: implement line card active state Ido Schimmel
2021-01-15 16:52 ` Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 04/10] devlink: append split port number to the port name Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 05/10] devlink: add port to line card relationship set Jiri Pirko
2021-01-15 16:10 ` Ido Schimmel
2021-01-15 16:53 ` Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 06/10] netdevsim: introduce line card support Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 07/10] netdevsim: allow port objects to be linked with line cards Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 08/10] netdevsim: create devlink line card object and implement provisioning Jiri Pirko
2021-01-15 16:30 ` Ido Schimmel
2021-01-15 16:54 ` Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 09/10] netdevsim: implement line card activation Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 10/10] selftests: add netdevsim devlink lc test Jiri Pirko
2021-01-13 13:39 ` [patch iproute2/net-next RFC] devlink: add support for linecard show and provision Jiri Pirko
2021-01-14 2:07 ` [patch net-next RFC 00/10] introduce line card support for modular switch Andrew Lunn
2021-01-14 7:39 ` Jiri Pirko
2021-01-14 22:56 ` Jacob Keller
2021-01-15 14:19 ` Jiri Pirko
2021-01-19 11:56 ` Jiri Pirko
2021-01-19 14:51 ` Andrew Lunn
2021-01-20 8:36 ` Jiri Pirko
2021-01-20 13:56 ` Andrew Lunn
2021-01-20 23:41 ` Jakub Kicinski
2021-01-21 0:01 ` Andrew Lunn
2021-01-21 0:16 ` Jakub Kicinski
2021-01-21 15:34 ` Jiri Pirko
2021-01-21 15:32 ` Jiri Pirko
2021-01-21 16:38 ` David Ahern
2021-01-22 7:28 ` Jiri Pirko
2021-01-22 14:13 ` Andrew Lunn
2021-01-26 11:33 ` Jiri Pirko
2021-01-26 13:56 ` Andrew Lunn
2021-01-27 7:57 ` Jiri Pirko
2021-01-27 14:14 ` Andrew Lunn
2021-01-27 14:57 ` David Ahern
2021-01-28 8:14 ` Jiri Pirko
2021-01-28 14:17 ` Andrew Lunn
2021-01-29 7:20 ` Jiri Pirko
[not found] ` <YBQujIdnFtEhWqTF@lunn.ch>
2021-01-29 16:45 ` Vadim Pasternak
2021-01-29 17:31 ` Andrew Lunn
2021-01-30 14:19 ` Jiri Pirko
[not found] ` <251d1e12-1d61-0922-31f8-a8313f18f194@gmail.com>
2021-02-01 8:16 ` Jiri Pirko
2021-02-01 13:41 ` Andrew Lunn
2021-02-03 14:57 ` Jiri Pirko
2021-02-03 16:26 ` Andrew Lunn
2021-02-01 1:43 ` Andrew Lunn
2021-01-22 8:05 ` Jiri Pirko
2021-01-19 16:23 ` David Ahern
2021-01-20 8:37 ` Jiri Pirko
2021-01-14 2:27 ` Jakub Kicinski
2021-01-14 7:48 ` Jiri Pirko
2021-01-14 23:30 ` Jakub Kicinski
2021-01-15 14:39 ` Jiri Pirko
2021-01-15 19:26 ` Jakub Kicinski
2021-01-18 13:00 ` Jiri Pirko
2021-01-18 17:59 ` Jakub Kicinski
2021-01-19 11:51 ` Jiri Pirko
2021-01-18 22:55 ` David Ahern
2021-01-22 8:01 ` Jiri Pirko
2021-01-14 22:58 ` Jacob Keller
2021-01-14 23:20 ` Jakub Kicinski
2021-01-15 14:40 ` Jiri Pirko
2021-01-15 15:43 ` Ido Schimmel
2021-01-15 16:55 ` Jiri Pirko
2021-01-15 18:01 ` Ido Schimmel
2021-01-18 13:03 ` Jiri Pirko
2021-01-18 18:01 ` Edwin Peer
2021-01-18 22:57 ` David Ahern
2021-01-18 23:40 ` Edwin Peer
2021-01-19 2:39 ` David Ahern
2021-01-19 5:06 ` Edwin Peer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113121222.733517-4-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).