From: Ido Schimmel <idosch@idosch.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
jacob.e.keller@intel.com, roopa@nvidia.com, mlxsw@nvidia.com
Subject: Re: [patch net-next RFC 00/10] introduce line card support for modular switch
Date: Fri, 15 Jan 2021 20:01:45 +0200 [thread overview]
Message-ID: <20210115180145.GA2074023@shredder.lan> (raw)
In-Reply-To: <20210115165559.GS3565223@nanopsycho.orion>
On Fri, Jan 15, 2021 at 05:55:59PM +0100, Jiri Pirko wrote:
> Fri, Jan 15, 2021 at 04:43:57PM CET, idosch@idosch.org wrote:
> >On Wed, Jan 13, 2021 at 01:12:12PM +0100, Jiri Pirko wrote:
> >> # Create a new netdevsim device, with no ports and 2 line cards:
> >> $ echo "10 0 2" >/sys/bus/netdevsim/new_device
> >> $ devlink port # No ports are listed
> >> $ devlink lc
> >> netdevsim/netdevsim10:
> >> lc 0 state unprovisioned
> >> supported_types:
> >> card1port card2ports card4ports
> >> lc 1 state unprovisioned
> >> supported_types:
> >> card1port card2ports card4ports
> >>
> >> # Note that driver advertizes supported line card types. In case of
> >> # netdevsim, these are 3.
> >>
> >> $ devlink lc provision netdevsim/netdevsim10 lc 0 type card4ports
> >
> >Why do we need a separate command for that? You actually introduced
> >'DEVLINK_CMD_LINECARD_SET' in patch #1, but it's never used.
> >
> >I prefer:
> >
> >devlink lc set netdevsim/netdevsim10 index 0 state provision type card4ports
>
> This is misleading. This is actually not setting state. The state gets
> changed upon successful provisioning process. Also, one may think that
> he can set other states, but he can't. I don't like this at all :/
So make state a read-only attribute. You really only care about setting
the type.
To provision:
# devlink lc set netdevsim/netdevsim10 index 0 type card4ports
To unprovsion:
# devlink lc set netdevsim/netdevsim10 index 0 type none
Or:
# devlink lc set netdevsim/netdevsim10 index 0 notype
>
>
> >devlink lc set netdevsim/netdevsim10 index 0 state unprovision
> >
> >It is consistent with the GET/SET/NEW/DEL pattern used by other
> >commands.
>
> Not really, see split port for example. This is similar to that.
It's not. The split command creates new objects whereas this command
modifies an existing object.
>
> >
> >> $ devlink lc
> >> netdevsim/netdevsim10:
> >> lc 0 state provisioned type card4ports
> >> supported_types:
> >> card1port card2ports card4ports
> >> lc 1 state unprovisioned
> >> supported_types:
> >> card1port card2ports card4ports
> >> $ devlink port
> >> netdevsim/netdevsim10/1000: type eth netdev eni10nl0p1 flavour physical lc 0 port 1 splittable false
> >> netdevsim/netdevsim10/1001: type eth netdev eni10nl0p2 flavour physical lc 0 port 2 splittable false
> >> netdevsim/netdevsim10/1002: type eth netdev eni10nl0p3 flavour physical lc 0 port 3 splittable false
> >> netdevsim/netdevsim10/1003: type eth netdev eni10nl0p4 flavour physical lc 0 port 4 splittable false
> >> # ^^ ^^^^
> >> # netdev name adjusted index of a line card this port belongs to
> >>
> >> $ ip link set eni10nl0p1 up
> >> $ ip link show eni10nl0p1
> >> 165: eni10nl0p1: <NO-CARRIER,BROADCAST,NOARP,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
> >> link/ether 7e:2d:05:93:d3:d1 brd ff:ff:ff:ff:ff:ff
> >>
> >> # Now activate the line card using debugfs. That emulates plug-in event
> >> # on real hardware:
> >> $ echo "Y"> /sys/kernel/debug/netdevsim/netdevsim10/linecards/0/active
> >> $ ip link show eni10nl0p1
> >> 165: eni10nl0p1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
> >> link/ether 7e:2d:05:93:d3:d1 brd ff:ff:ff:ff:ff:ff
> >> # The carrier is UP now.
> >>
> >> Jiri Pirko (10):
> >> devlink: add support to create line card and expose to user
> >> devlink: implement line card provisioning
> >> devlink: implement line card active state
> >> devlink: append split port number to the port name
> >> devlink: add port to line card relationship set
> >> netdevsim: introduce line card support
> >> netdevsim: allow port objects to be linked with line cards
> >> netdevsim: create devlink line card object and implement provisioning
> >> netdevsim: implement line card activation
> >> selftests: add netdevsim devlink lc test
> >>
> >> drivers/net/netdevsim/bus.c | 21 +-
> >> drivers/net/netdevsim/dev.c | 370 ++++++++++++++-
> >> drivers/net/netdevsim/netdev.c | 2 +
> >> drivers/net/netdevsim/netdevsim.h | 23 +
> >> include/net/devlink.h | 44 ++
> >> include/uapi/linux/devlink.h | 25 +
> >> net/core/devlink.c | 443 +++++++++++++++++-
> >> .../drivers/net/netdevsim/devlink.sh | 62 ++-
> >> 8 files changed, 964 insertions(+), 26 deletions(-)
> >>
> >> --
> >> 2.26.2
> >>
next prev parent reply other threads:[~2021-01-15 18:02 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 12:12 [patch net-next RFC 00/10] introduce line card support for modular switch Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 01/10] devlink: add support to create line card and expose to user Jiri Pirko
2021-01-15 15:47 ` Ido Schimmel
2021-01-13 12:12 ` [patch net-next RFC 02/10] devlink: implement line card provisioning Jiri Pirko
2021-01-15 16:03 ` Ido Schimmel
2021-01-15 16:51 ` Jiri Pirko
2021-01-15 18:09 ` Ido Schimmel
2021-01-18 12:50 ` Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 03/10] devlink: implement line card active state Jiri Pirko
2021-01-15 16:06 ` Ido Schimmel
2021-01-15 16:52 ` Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 04/10] devlink: append split port number to the port name Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 05/10] devlink: add port to line card relationship set Jiri Pirko
2021-01-15 16:10 ` Ido Schimmel
2021-01-15 16:53 ` Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 06/10] netdevsim: introduce line card support Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 07/10] netdevsim: allow port objects to be linked with line cards Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 08/10] netdevsim: create devlink line card object and implement provisioning Jiri Pirko
2021-01-15 16:30 ` Ido Schimmel
2021-01-15 16:54 ` Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 09/10] netdevsim: implement line card activation Jiri Pirko
2021-01-13 12:12 ` [patch net-next RFC 10/10] selftests: add netdevsim devlink lc test Jiri Pirko
2021-01-13 13:39 ` [patch iproute2/net-next RFC] devlink: add support for linecard show and provision Jiri Pirko
2021-01-14 2:07 ` [patch net-next RFC 00/10] introduce line card support for modular switch Andrew Lunn
2021-01-14 7:39 ` Jiri Pirko
2021-01-14 22:56 ` Jacob Keller
2021-01-15 14:19 ` Jiri Pirko
2021-01-19 11:56 ` Jiri Pirko
2021-01-19 14:51 ` Andrew Lunn
2021-01-20 8:36 ` Jiri Pirko
2021-01-20 13:56 ` Andrew Lunn
2021-01-20 23:41 ` Jakub Kicinski
2021-01-21 0:01 ` Andrew Lunn
2021-01-21 0:16 ` Jakub Kicinski
2021-01-21 15:34 ` Jiri Pirko
2021-01-21 15:32 ` Jiri Pirko
2021-01-21 16:38 ` David Ahern
2021-01-22 7:28 ` Jiri Pirko
2021-01-22 14:13 ` Andrew Lunn
2021-01-26 11:33 ` Jiri Pirko
2021-01-26 13:56 ` Andrew Lunn
2021-01-27 7:57 ` Jiri Pirko
2021-01-27 14:14 ` Andrew Lunn
2021-01-27 14:57 ` David Ahern
2021-01-28 8:14 ` Jiri Pirko
2021-01-28 14:17 ` Andrew Lunn
2021-01-29 7:20 ` Jiri Pirko
[not found] ` <YBQujIdnFtEhWqTF@lunn.ch>
2021-01-29 16:45 ` Vadim Pasternak
2021-01-29 17:31 ` Andrew Lunn
2021-01-30 14:19 ` Jiri Pirko
[not found] ` <251d1e12-1d61-0922-31f8-a8313f18f194@gmail.com>
2021-02-01 8:16 ` Jiri Pirko
2021-02-01 13:41 ` Andrew Lunn
2021-02-03 14:57 ` Jiri Pirko
2021-02-03 16:26 ` Andrew Lunn
2021-02-01 1:43 ` Andrew Lunn
2021-01-22 8:05 ` Jiri Pirko
2021-01-19 16:23 ` David Ahern
2021-01-20 8:37 ` Jiri Pirko
2021-01-14 2:27 ` Jakub Kicinski
2021-01-14 7:48 ` Jiri Pirko
2021-01-14 23:30 ` Jakub Kicinski
2021-01-15 14:39 ` Jiri Pirko
2021-01-15 19:26 ` Jakub Kicinski
2021-01-18 13:00 ` Jiri Pirko
2021-01-18 17:59 ` Jakub Kicinski
2021-01-19 11:51 ` Jiri Pirko
2021-01-18 22:55 ` David Ahern
2021-01-22 8:01 ` Jiri Pirko
2021-01-14 22:58 ` Jacob Keller
2021-01-14 23:20 ` Jakub Kicinski
2021-01-15 14:40 ` Jiri Pirko
2021-01-15 15:43 ` Ido Schimmel
2021-01-15 16:55 ` Jiri Pirko
2021-01-15 18:01 ` Ido Schimmel [this message]
2021-01-18 13:03 ` Jiri Pirko
2021-01-18 18:01 ` Edwin Peer
2021-01-18 22:57 ` David Ahern
2021-01-18 23:40 ` Edwin Peer
2021-01-19 2:39 ` David Ahern
2021-01-19 5:06 ` Edwin Peer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115180145.GA2074023@shredder.lan \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).