Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
@ 2021-02-23 14:00 Wei Yongjun
  2021-02-26 21:06 ` Nathan Chancellor
  2021-02-26 21:37 ` vic.michel.web
  0 siblings, 2 replies; 8+ messages in thread
From: Wei Yongjun @ 2021-02-23 14:00 UTC (permalink / raw)
  To: Hulk Robot, Luca Coelho, Kalle Valo, Jakub Kicinski,
	Emmanuel Grumbach, Gil Adam, Mordechay Goodstein, Johannes Berg
  Cc: Wei Yongjun, linux-wireless, netdev

Make sure dmi_system_id tables are NULL terminated.

Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG feature")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 15e2773ce7e7..5ee64f7f3c85 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1083,6 +1083,7 @@ static const struct dmi_system_id dmi_ppag_approved_list[] = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTek COMPUTER INC."),
 		},
 	},
+	{}
 };
 
 static int iwl_mvm_ppag_init(struct iwl_mvm *mvm)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
  2021-02-23 14:00 [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables Wei Yongjun
@ 2021-02-26 21:06 ` Nathan Chancellor
  2021-02-27  6:39   ` Kalle Valo
  2021-02-26 21:37 ` vic.michel.web
  1 sibling, 1 reply; 8+ messages in thread
From: Nathan Chancellor @ 2021-02-26 21:06 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Hulk Robot, Luca Coelho, Kalle Valo, Jakub Kicinski,
	Emmanuel Grumbach, Gil Adam, Mordechay Goodstein, Johannes Berg,
	linux-wireless, netdev

On Tue, Feb 23, 2021 at 02:00:39PM +0000, Wei Yongjun wrote:
> Make sure dmi_system_id tables are NULL terminated.
> 
> Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG feature")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

We received a report about a crash in iwlwifi when compiled with LTO and
this fix resolves it.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> index 15e2773ce7e7..5ee64f7f3c85 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> @@ -1083,6 +1083,7 @@ static const struct dmi_system_id dmi_ppag_approved_list[] = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTek COMPUTER INC."),
>  		},
>  	},
> +	{}
>  };
>  
>  static int iwl_mvm_ppag_init(struct iwl_mvm *mvm)
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
  2021-02-23 14:00 [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables Wei Yongjun
  2021-02-26 21:06 ` Nathan Chancellor
@ 2021-02-26 21:37 ` vic.michel.web
  1 sibling, 0 replies; 8+ messages in thread
From: vic.michel.web @ 2021-02-26 21:37 UTC (permalink / raw)
  To: weiyongjun1
  Cc: emmanuel.grumbach, gil.adam, hulkci, johannes.berg, kuba, kvalo,
	linux-wireless, luciano.coelho, mordechay.goodstein, netdev,
	Victor Michel

This fixes a BUG triggered when loading the iwlwifi driver, which reproduces
consistently when I compile the kernel with LTO_CLANG_THIN.

Tested-by: Victor Michel <vic.michel.web@gmail.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
  2021-02-26 21:06 ` Nathan Chancellor
@ 2021-02-27  6:39   ` Kalle Valo
  2021-03-02 18:31     ` Coelho, Luciano
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2021-02-27  6:39 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Wei Yongjun, Hulk Robot, Luca Coelho, Jakub Kicinski,
	Emmanuel Grumbach, Gil Adam, Mordechay Goodstein, Johannes Berg,
	linux-wireless, netdev

Nathan Chancellor <nathan@kernel.org> writes:

> On Tue, Feb 23, 2021 at 02:00:39PM +0000, Wei Yongjun wrote:
>> Make sure dmi_system_id tables are NULL terminated.
>> 
>> Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG feature")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> We received a report about a crash in iwlwifi when compiled with LTO and
> this fix resolves it.

That information should be added to the commit log.

Luca, should I take this to wireless-drivers?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
  2021-02-27  6:39   ` Kalle Valo
@ 2021-03-02 18:31     ` Coelho, Luciano
  2021-03-02 19:05       ` Jakub Kicinski
  0 siblings, 1 reply; 8+ messages in thread
From: Coelho, Luciano @ 2021-03-02 18:31 UTC (permalink / raw)
  To: nathan, kvalo
  Cc: gil.adam, Berg, Johannes, weiyongjun1, linux-wireless, Goodstein,
	Mordechay, kuba, hulkci, Grumbach, Emmanuel, netdev

On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote:
> Nathan Chancellor <nathan@kernel.org> writes:
> 
> > On Tue, Feb 23, 2021 at 02:00:39PM +0000, Wei Yongjun wrote:
> > > Make sure dmi_system_id tables are NULL terminated.
> > > 
> > > Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG feature")
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > We received a report about a crash in iwlwifi when compiled with LTO and
> > this fix resolves it.
> 
> That information should be added to the commit log.
> 
> Luca, should I take this to wireless-drivers?

I just saw Jens' patch now and I don't remember if I acked this one?

In any, I assigned it to you in patchwork, so please take it directly
to w-d.

Thanks!

Acked-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
  2021-03-02 18:31     ` Coelho, Luciano
@ 2021-03-02 19:05       ` Jakub Kicinski
  2021-03-02 19:50         ` Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2021-03-02 19:05 UTC (permalink / raw)
  To: Coelho, Luciano
  Cc: nathan, kvalo, gil.adam, Berg, Johannes, weiyongjun1,
	linux-wireless, Goodstein, Mordechay, hulkci, Grumbach, Emmanuel,
	netdev

On Tue, 2 Mar 2021 18:31:11 +0000 Coelho, Luciano wrote:
> On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote:
> > Nathan Chancellor <nathan@kernel.org> writes:
> > > We received a report about a crash in iwlwifi when compiled with LTO and
> > > this fix resolves it.  
> > 
> > That information should be added to the commit log.
> > 
> > Luca, should I take this to wireless-drivers?  
> 
> I just saw Jens' patch now and I don't remember if I acked this one?
> 
> In any, I assigned it to you in patchwork, so please take it directly
> to w-d.
> 
> Acked-by: Luca Coelho <luciano.coelho@intel.com>

Thanks, I'm getting pinged, too. It sounded like Kalle would like to
see the commit log improved, if Wei doesn't respond could you please
step in to make sure this fix is part of Dave's next PR to Linus?

Thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
  2021-03-02 19:05       ` Jakub Kicinski
@ 2021-03-02 19:50         ` Kalle Valo
  2021-03-02 21:42           ` Jakub Kicinski
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2021-03-02 19:50 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Coelho, Luciano, nathan, gil.adam, Berg, Johannes, weiyongjun1,
	linux-wireless, Goodstein, Mordechay, hulkci, Grumbach, Emmanuel,
	netdev

Jakub Kicinski <kuba@kernel.org> writes:

> On Tue, 2 Mar 2021 18:31:11 +0000 Coelho, Luciano wrote:
>> On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote:
>> > Nathan Chancellor <nathan@kernel.org> writes:
>> > > We received a report about a crash in iwlwifi when compiled with LTO and
>> > > this fix resolves it.  
>> > 
>> > That information should be added to the commit log.
>> > 
>> > Luca, should I take this to wireless-drivers?  
>> 
>> I just saw Jens' patch now and I don't remember if I acked this one?
>> 
>> In any, I assigned it to you in patchwork, so please take it directly
>> to w-d.
>> 
>> Acked-by: Luca Coelho <luciano.coelho@intel.com>
>
> Thanks, I'm getting pinged, too. It sounded like Kalle would like to
> see the commit log improved

I wrote my comment hastily, I was trying to say that I can add the crash
information to the commit log.

> if Wei doesn't respond could you please step in to make sure this
> fix is part of Dave's next PR to Linus?

Will do. Related to this, what's your pull request schedule to Linus
nowadays? Do you submit it every Thursday?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
  2021-03-02 19:50         ` Kalle Valo
@ 2021-03-02 21:42           ` Jakub Kicinski
  0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2021-03-02 21:42 UTC (permalink / raw)
  To: Kalle Valo, David Miller
  Cc: Coelho, Luciano, nathan, gil.adam, Berg, Johannes, weiyongjun1,
	linux-wireless, Goodstein, Mordechay, hulkci, Grumbach, Emmanuel,
	netdev

On Tue, 02 Mar 2021 21:50:18 +0200 Kalle Valo wrote:
> > if Wei doesn't respond could you please step in to make sure this
> > fix is part of Dave's next PR to Linus?  
> 
> Will do. Related to this, what's your pull request schedule to Linus
> nowadays? Do you submit it every Thursday?

Fair question :) Dave is back full time now, so I think it will be more
merit based again.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 14:00 [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables Wei Yongjun
2021-02-26 21:06 ` Nathan Chancellor
2021-02-27  6:39   ` Kalle Valo
2021-03-02 18:31     ` Coelho, Luciano
2021-03-02 19:05       ` Jakub Kicinski
2021-03-02 19:50         ` Kalle Valo
2021-03-02 21:42           ` Jakub Kicinski
2021-02-26 21:37 ` vic.michel.web

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git