From: Hangbin Liu <liuhangbin@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: netdev@vger.kernel.org, "Jason A . Donenfeld" <Jason@zx2c4.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Ondrej Mosnacek" <omosnace@redhat.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode
Date: Fri, 9 Apr 2021 10:11:21 +0800 [thread overview]
Message-ID: <20210409021121.GK2900@Leo-laptop-t470s> (raw)
In-Reply-To: <YG8dJpEEWP3PxUIm@sol.localdomain>
On Thu, Apr 08, 2021 at 08:11:34AM -0700, Eric Biggers wrote:
> On Thu, Apr 08, 2021 at 07:58:08PM +0800, Hangbin Liu wrote:
> > On Thu, Apr 08, 2021 at 09:06:52AM +0800, Hangbin Liu wrote:
> > > > Also, couldn't you just consider WireGuard to be outside your FIPS module
> > > > boundary, which would remove it from the scope of the certification?
> > > >
> > > > And how do you handle all the other places in the kernel that use ChaCha20 and
> > > > SipHash? For example, drivers/char/random.c?
> > >
> > > Good question, I will check it and reply to you later.
> >
> > I just read the code. The drivers/char/random.c do has some fips specific
> > parts(seems not related to crypto). After commit e192be9d9a30 ("random: replace
> > non-blocking pool with a Chacha20-based CRNG") we moved part of chacha code to
> > lib/chacha20.c and make that code out of control.
> >
> So you are saying that you removed drivers/char/random.c and lib/chacha20.c from
> your FIPS module boundary? Why not do the same for WireGuard?
No, I mean this looks like a bug (using not allowed crypto in FIPS mode) and
we should fix it.
Thanks
Hangbin
next prev parent reply other threads:[~2021-04-09 2:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 11:39 [PATCH net-next] [RESEND] wireguard: disable in FIPS mode Hangbin Liu
2021-04-07 21:12 ` Eric Biggers
2021-04-08 1:06 ` Hangbin Liu
2021-04-08 11:58 ` Hangbin Liu
2021-04-08 15:11 ` Eric Biggers
2021-04-09 2:11 ` Hangbin Liu [this message]
2021-04-09 7:08 ` Stephan Mueller
2021-04-09 8:08 ` Hangbin Liu
2021-04-09 16:26 ` Simo Sorce
2021-04-09 18:29 ` Jason A. Donenfeld
2021-04-12 2:11 ` Hangbin Liu
2021-04-07 21:15 ` Jason A. Donenfeld
2021-04-08 6:52 ` Hangbin Liu
2021-04-08 7:36 ` Ondrej Mosnacek
2021-04-08 13:55 ` Simo Sorce
2021-04-08 21:55 ` Jason A. Donenfeld
2021-04-08 22:16 ` Simo Sorce
2021-04-09 2:41 ` Hangbin Liu
2021-04-09 2:44 ` Jason A. Donenfeld
2021-04-09 2:49 ` Hangbin Liu
2021-04-09 3:03 ` Jason A. Donenfeld
2021-04-09 6:02 ` Ard Biesheuvel
2021-04-09 12:47 ` Simo Sorce
2021-04-09 18:36 ` Jason A. Donenfeld
2021-04-09 18:56 ` Simo Sorce
2021-04-12 12:46 ` Simo Sorce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409021121.GK2900@Leo-laptop-t470s \
--to=liuhangbin@gmail.com \
--cc=Jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).