From: Jakub Kicinski <kuba@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Jon Hunter <jonathanh@nvidia.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back
Date: Tue, 13 Apr 2021 09:43:05 -0700 [thread overview]
Message-ID: <20210413094305.008854c5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YHXBj3rsEjf8Y+qn@orome.fritz.box>
On Tue, 13 Apr 2021 18:06:39 +0200 Thierry Reding wrote:
> given where we are in the release cycle, I think it'd be best to revert
> commit 9c63faaa931e ("net: stmmac: re-init rx buffers when mac resume
> back") for now.
>
> To summarize the discussion: the patch was meant as a workaround to fix
> an occasional suspend/resume failure on one board that was not fully
> root caused, and ends up causing fully reproducible suspend/resume
> failures on at least one other board.
>
> Joakim is looking at an alternative solution and Jon and I can provide
> testing from the Tegra side for any fixes.
>
> Do you want me to send a revert patch or can you revert directly on top
> of your tree?
Please send a revert with the justification in the commit log, and
perhaps also:
Link: https://lore.kernel.org/r/708edb92-a5df-ecc4-3126-5ab36707e275@nvidia.com/
for those who want to dig deeper in the history. Make sure you
CC relevant folks so they can review and express their opinions.
Thanks!
next prev parent reply other threads:[~2021-04-13 16:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 10:50 Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back Jon Hunter
2021-03-24 12:20 ` Joakim Zhang
2021-03-24 12:39 ` Jon Hunter
2021-03-25 7:53 ` Joakim Zhang
2021-03-25 8:00 ` Jon Hunter
2021-03-25 8:12 ` Joakim Zhang
2021-03-30 12:50 ` Jon Hunter
2021-03-31 7:43 ` Joakim Zhang
2021-03-31 11:10 ` Joakim Zhang
2021-03-31 11:29 ` Jon Hunter
2021-03-31 11:41 ` Joakim Zhang
2021-04-01 16:28 ` Jon Hunter
2021-04-13 8:41 ` Jon Hunter
2021-04-13 12:13 ` Joakim Zhang
2021-04-13 16:06 ` Thierry Reding
2021-04-13 16:43 ` Jakub Kicinski [this message]
2021-04-14 2:18 ` Joakim Zhang
2021-04-14 7:40 ` Thierry Reding
2021-04-14 8:06 ` Joakim Zhang
2021-04-14 12:22 ` Joakim Zhang
2021-03-31 11:11 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413094305.008854c5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).