From: Jon Hunter <jonathanh@nvidia.com>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
Jakub Kicinski <kuba@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back
Date: Wed, 31 Mar 2021 12:11:42 +0100 [thread overview]
Message-ID: <6ad03990-888d-7db6-8271-23c5ff673448@nvidia.com> (raw)
In-Reply-To: <DB8PR04MB6795F4333BCA9CE83C288FEEE67C9@DB8PR04MB6795.eurprd04.prod.outlook.com>
On 31/03/2021 08:43, Joakim Zhang wrote:
...
>>>>>>> You mean one of your boards? Does other boards with STMMAC can
>>>>>>> work
>>>>>> fine?
>>>>>>
>>>>>> We have two devices with the STMMAC and one works OK and the other
>>>> fails.
>>>>>> They are different generation of device and so there could be some
>>>>>> architectural differences which is causing this to only be seen on one
>> device.
>>>>> It's really strange, but I also don't know what architectural
>>>>> differences could
>>>> affect this. Sorry.
>>
>>
>> I realised that for the board which fails after this change is made, it has the
>> IOMMU enabled. The other board does not at the moment (although work is in
>> progress to enable). If I add 'iommu.passthrough=1' to cmdline for the failing
>> board, then it works again. So in my case, the problem is linked to the IOMMU
>> being enabled.
>>
>> Does you platform enable the IOMMU?
>
> Hi Jon,
>
> There is no IOMMU hardware available on our boards. But why IOMMU would affect it during suspend/resume, and no problem in normal mode?
I am not sure either and I don't see anything obvious.
Guiseppe, Alexandre, Jose, do you see anything that is wrong with
Joakim's change 9c63faaa931e? This is completely breaking resume from
suspend on one of our boards and I would like to get your inputs?
Thanks
Jon
--
nvpublic
prev parent reply other threads:[~2021-03-31 11:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 10:50 Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back Jon Hunter
2021-03-24 12:20 ` Joakim Zhang
2021-03-24 12:39 ` Jon Hunter
2021-03-25 7:53 ` Joakim Zhang
2021-03-25 8:00 ` Jon Hunter
2021-03-25 8:12 ` Joakim Zhang
2021-03-30 12:50 ` Jon Hunter
2021-03-31 7:43 ` Joakim Zhang
2021-03-31 11:10 ` Joakim Zhang
2021-03-31 11:29 ` Jon Hunter
2021-03-31 11:41 ` Joakim Zhang
2021-04-01 16:28 ` Jon Hunter
2021-04-13 8:41 ` Jon Hunter
2021-04-13 12:13 ` Joakim Zhang
2021-04-13 16:06 ` Thierry Reding
2021-04-13 16:43 ` Jakub Kicinski
2021-04-14 2:18 ` Joakim Zhang
2021-04-14 7:40 ` Thierry Reding
2021-04-14 8:06 ` Joakim Zhang
2021-04-14 12:22 ` Joakim Zhang
2021-03-31 11:11 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ad03990-888d-7db6-8271-23c5ff673448@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alexandre.torgue@st.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).