* [PATCH net] iavf: missing unlocks in iavf_watchdog_task()
@ 2021-11-10 8:13 Dan Carpenter
2021-11-10 8:53 ` [Intel-wired-lan] " Paul Menzel
2021-12-13 13:34 ` Jankowski, Konrad0
0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-11-10 8:13 UTC (permalink / raw)
To: Jesse Brandeburg, Mateusz Palczewski
Cc: Tony Nguyen, David S. Miller, Jakub Kicinski, Jan Sokolowski,
Jakub Pawlak, intel-wired-lan, netdev, kernel-janitors
This code was re-organized and there some unlocks missing now.
Fixes: 898ef1cb1cb2 ("iavf: Combine init and watchdog state machines")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 847d67e32a54..b97f685a5cf8 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2012,6 +2012,7 @@ static void iavf_watchdog_task(struct work_struct *work)
}
adapter->aq_required = 0;
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
+ mutex_unlock(&adapter->crit_lock);
queue_delayed_work(iavf_wq,
&adapter->watchdog_task,
msecs_to_jiffies(10));
@@ -2042,9 +2043,8 @@ static void iavf_watchdog_task(struct work_struct *work)
iavf_detect_recover_hung(&adapter->vsi);
break;
case __IAVF_REMOVE:
- mutex_unlock(&adapter->crit_lock);
- return;
default:
+ mutex_unlock(&adapter->crit_lock);
return;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Intel-wired-lan] [PATCH net] iavf: missing unlocks in iavf_watchdog_task()
2021-11-10 8:13 [PATCH net] iavf: missing unlocks in iavf_watchdog_task() Dan Carpenter
@ 2021-11-10 8:53 ` Paul Menzel
2021-11-10 9:05 ` Dan Carpenter
2021-12-13 13:34 ` Jankowski, Konrad0
1 sibling, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2021-11-10 8:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jakub Pawlak, netdev, kernel-janitors, Jakub Kicinski,
intel-wired-lan, David S. Miller, Jesse Brandeburg,
Mateusz Palczewski
Dear Dan,
Thank you for your patch.
For the future, just a nit for the commit message summary. Could you
make it a statement by adding a verb (in imperative mood) [1].
> iavf: Add missing unlocks in iavf_watchdog_task()
Kind regards,
Paul
[1]: https://chris.beams.io/posts/git-commit/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net] iavf: missing unlocks in iavf_watchdog_task()
2021-11-10 8:53 ` [Intel-wired-lan] " Paul Menzel
@ 2021-11-10 9:05 ` Dan Carpenter
2021-11-10 9:27 ` Paul Menzel
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2021-11-10 9:05 UTC (permalink / raw)
To: Paul Menzel
Cc: Jakub Pawlak, netdev, kernel-janitors, Jakub Kicinski,
intel-wired-lan, David S. Miller, Jesse Brandeburg,
Mateusz Palczewski
On Wed, Nov 10, 2021 at 09:53:50AM +0100, Paul Menzel wrote:
> Dear Dan,
>
>
> Thank you for your patch.
>
> For the future, just a nit for the commit message summary. Could you make it
> a statement by adding a verb (in imperative mood) [1].
>
> > iavf: Add missing unlocks in iavf_watchdog_task()
>
Imperative shmeritave.
When subsystems get taken over by fussy bureaucrats then I only send
them bug reports instead of patches.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net] iavf: missing unlocks in iavf_watchdog_task()
2021-11-10 9:05 ` Dan Carpenter
@ 2021-11-10 9:27 ` Paul Menzel
2021-11-10 9:36 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2021-11-10 9:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jakub Pawlak, netdev, kernel-janitors, Jakub Kicinski,
intel-wired-lan, David S. Miller, Jesse Brandeburg,
Mateusz Palczewski
Dear Dan,
Am 10.11.21 um 10:05 schrieb Dan Carpenter:
> On Wed, Nov 10, 2021 at 09:53:50AM +0100, Paul Menzel wrote:
>> Thank you for your patch.
>>
>> For the future, just a nit for the commit message summary. Could you make it
>> a statement by adding a verb (in imperative mood) [1].
>>
>>> iavf: Add missing unlocks in iavf_watchdog_task()
>
> Imperative shmeritave.
>
> When subsystems get taken over by fussy bureaucrats then I only send
> them bug reports instead of patches.
It was just a wish as the standard commit messages follow that format,
and any verb could be added. It’s not a requirement to my knowledge, and
I do not have any authority anyway. Sorry about that, and thank you for
your patches.
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH net] iavf: missing unlocks in iavf_watchdog_task()
2021-11-10 8:13 [PATCH net] iavf: missing unlocks in iavf_watchdog_task() Dan Carpenter
2021-11-10 8:53 ` [Intel-wired-lan] " Paul Menzel
@ 2021-12-13 13:34 ` Jankowski, Konrad0
1 sibling, 0 replies; 6+ messages in thread
From: Jankowski, Konrad0 @ 2021-12-13 13:34 UTC (permalink / raw)
To: Dan Carpenter, Brandeburg, Jesse, Palczewski, Mateusz
Cc: Pawlak, Jakub, netdev, kernel-janitors, Jakub Kicinski,
intel-wired-lan, David S. Miller
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Dan Carpenter
> Sent: środa, 10 listopada 2021 09:14
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Palczewski, Mateusz
> <mateusz.palczewski@intel.com>
> Cc: Pawlak, Jakub <jakub.pawlak@intel.com>; netdev@vger.kernel.org;
> kernel-janitors@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; intel-
> wired-lan@lists.osuosl.org; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net] iavf: missing unlocks in
> iavf_watchdog_task()
>
> This code was re-organized and there some unlocks missing now.
>
> Fixes: 898ef1cb1cb2 ("iavf: Combine init and watchdog state machines")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 847d67e32a54..b97f685a5cf8 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -2012,6 +2012,7 @@ static void iavf_watchdog_task(struct work_struct
> *work)
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-13 13:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 8:13 [PATCH net] iavf: missing unlocks in iavf_watchdog_task() Dan Carpenter
2021-11-10 8:53 ` [Intel-wired-lan] " Paul Menzel
2021-11-10 9:05 ` Dan Carpenter
2021-11-10 9:27 ` Paul Menzel
2021-11-10 9:36 ` Dan Carpenter
2021-12-13 13:34 ` Jankowski, Konrad0
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).