* [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
@ 2024-03-18 19:34 Andy Shevchenko
2024-03-19 10:25 ` Jiri Pirko
2024-03-19 14:25 ` Marc Kleine-Budde
0 siblings, 2 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-03-18 19:34 UTC (permalink / raw)
To: Andy Shevchenko, linux-can, netdev, linux-kernel
Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
This driver is including the legacy GPIO header <linux/gpio.h>
but the only thing it is using from that header is the wrong
define for GPIOF_DIR_OUT.
Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/can/spi/mcp251x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index 79c4bab5f724..643974b3f329 100644
--- a/drivers/net/can/spi/mcp251x.c
+++ b/drivers/net/can/spi/mcp251x.c
@@ -28,7 +28,6 @@
#include <linux/device.h>
#include <linux/ethtool.h>
#include <linux/freezer.h>
-#include <linux/gpio.h>
#include <linux/gpio/driver.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -482,9 +481,9 @@ static int mcp251x_gpio_get_direction(struct gpio_chip *chip,
unsigned int offset)
{
if (mcp251x_gpio_is_input(offset))
- return GPIOF_DIR_IN;
+ return GPIO_LINE_DIRECTION_IN;
- return GPIOF_DIR_OUT;
+ return GPIO_LINE_DIRECTION_OUT;
}
static int mcp251x_gpio_get(struct gpio_chip *chip, unsigned int offset)
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
2024-03-18 19:34 [PATCH net-next v1 1/1] can: mcp251x: Fix up includes Andy Shevchenko
@ 2024-03-19 10:25 ` Jiri Pirko
2024-03-20 10:25 ` Andy Shevchenko
2024-03-19 14:25 ` Marc Kleine-Budde
1 sibling, 1 reply; 8+ messages in thread
From: Jiri Pirko @ 2024-03-19 10:25 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-can, netdev, linux-kernel, Wolfgang Grandegger,
Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Mon, Mar 18, 2024 at 08:34:10PM CET, andriy.shevchenko@linux.intel.com wrote:
>This driver is including the legacy GPIO header <linux/gpio.h>
>but the only thing it is using from that header is the wrong
>define for GPIOF_DIR_OUT.
>
>Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
net-next is closed, send again next week.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
2024-03-18 19:34 [PATCH net-next v1 1/1] can: mcp251x: Fix up includes Andy Shevchenko
2024-03-19 10:25 ` Jiri Pirko
@ 2024-03-19 14:25 ` Marc Kleine-Budde
2024-03-20 10:26 ` Andy Shevchenko
1 sibling, 1 reply; 8+ messages in thread
From: Marc Kleine-Budde @ 2024-03-19 14:25 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-can, netdev, linux-kernel, Wolfgang Grandegger,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On 18.03.2024 21:34:10, Andy Shevchenko wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but the only thing it is using from that header is the wrong
> define for GPIOF_DIR_OUT.
>
> Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
No need to resend, added to linux-can-next.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
2024-03-19 10:25 ` Jiri Pirko
@ 2024-03-20 10:25 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-03-20 10:25 UTC (permalink / raw)
To: Jiri Pirko
Cc: linux-can, netdev, linux-kernel, Wolfgang Grandegger,
Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Tue, Mar 19, 2024 at 11:25:19AM +0100, Jiri Pirko wrote:
> Mon, Mar 18, 2024 at 08:34:10PM CET, andriy.shevchenko@linux.intel.com wrote:
> >This driver is including the legacy GPIO header <linux/gpio.h>
> >but the only thing it is using from that header is the wrong
> >define for GPIOF_DIR_OUT.
> >
> >Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
>
> net-next is closed, send again next week.
Thank you for the reminder. I have a question though.
Can net adapt to the existence of lore.kernel.org please?
I mean it's not big deal to me to resend, but:
1) it adds too much noise in already noisy mailing lists;
2) it brings no value since we have lore.kernel.org archive;
3) last but not least, it saves a lot of resources and becomes
environment friendly when we send _less_ emails.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
2024-03-19 14:25 ` Marc Kleine-Budde
@ 2024-03-20 10:26 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-03-20 10:26 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: linux-can, netdev, linux-kernel, Wolfgang Grandegger,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Tue, Mar 19, 2024 at 03:25:24PM +0100, Marc Kleine-Budde wrote:
> On 18.03.2024 21:34:10, Andy Shevchenko wrote:
> > This driver is including the legacy GPIO header <linux/gpio.h>
> > but the only thing it is using from that header is the wrong
> > define for GPIOF_DIR_OUT.
> >
> > Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
> No need to resend, added to linux-can-next.
Thank you for taking care, although it doesn't cancel my question to
the net subsystem flow in general.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
2024-04-12 17:33 Andy Shevchenko
2024-04-13 9:01 ` Vincent MAILHOL
@ 2024-05-07 16:31 ` Andy Shevchenko
1 sibling, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-05-07 16:31 UTC (permalink / raw)
To: linux-can, netdev, linux-kernel
Cc: Marc Kleine-Budde, Vincent Mailhol, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Fri, Apr 12, 2024 at 08:33:32PM +0300, Andy Shevchenko wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but the only thing it is using from that header is the wrong
> define for GPIOF_DIR_OUT.
>
> Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
Marc, any comments on this?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
2024-04-12 17:33 Andy Shevchenko
@ 2024-04-13 9:01 ` Vincent MAILHOL
2024-05-07 16:31 ` Andy Shevchenko
1 sibling, 0 replies; 8+ messages in thread
From: Vincent MAILHOL @ 2024-04-13 9:01 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-can, netdev, linux-kernel, Marc Kleine-Budde,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Sat. 13 Apr. 2024 at 02:33, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but the only thing it is using from that header is the wrong
> define for GPIOF_DIR_OUT.
>
> Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you for the patch.
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next v1 1/1] can: mcp251x: Fix up includes
@ 2024-04-12 17:33 Andy Shevchenko
2024-04-13 9:01 ` Vincent MAILHOL
2024-05-07 16:31 ` Andy Shevchenko
0 siblings, 2 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-04-12 17:33 UTC (permalink / raw)
To: Andy Shevchenko, linux-can, netdev, linux-kernel
Cc: Marc Kleine-Budde, Vincent Mailhol, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
This driver is including the legacy GPIO header <linux/gpio.h>
but the only thing it is using from that header is the wrong
define for GPIOF_DIR_OUT.
Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/can/spi/mcp251x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index 79c4bab5f724..643974b3f329 100644
--- a/drivers/net/can/spi/mcp251x.c
+++ b/drivers/net/can/spi/mcp251x.c
@@ -28,7 +28,6 @@
#include <linux/device.h>
#include <linux/ethtool.h>
#include <linux/freezer.h>
-#include <linux/gpio.h>
#include <linux/gpio/driver.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -482,9 +481,9 @@ static int mcp251x_gpio_get_direction(struct gpio_chip *chip,
unsigned int offset)
{
if (mcp251x_gpio_is_input(offset))
- return GPIOF_DIR_IN;
+ return GPIO_LINE_DIRECTION_IN;
- return GPIOF_DIR_OUT;
+ return GPIO_LINE_DIRECTION_OUT;
}
static int mcp251x_gpio_get(struct gpio_chip *chip, unsigned int offset)
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-05-07 16:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-18 19:34 [PATCH net-next v1 1/1] can: mcp251x: Fix up includes Andy Shevchenko
2024-03-19 10:25 ` Jiri Pirko
2024-03-20 10:25 ` Andy Shevchenko
2024-03-19 14:25 ` Marc Kleine-Budde
2024-03-20 10:26 ` Andy Shevchenko
2024-04-12 17:33 Andy Shevchenko
2024-04-13 9:01 ` Vincent MAILHOL
2024-05-07 16:31 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).