From: Marek Vasut <marex@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH 1/2] net: phy: micrel: Add KS8851 PHY support
Date: Sun, 3 Jan 2021 19:44:33 +0100 [thread overview]
Message-ID: <252db93a-f52d-a5d4-505a-bf4a82328981@denx.de> (raw)
In-Reply-To: <X/H3H1hr66tU0g7V@lunn.ch>
On 1/3/21 5:55 PM, Andrew Lunn wrote:
> On Sun, Jan 03, 2021 at 01:55:22PM +0100, Marek Vasut wrote:
>> On 12/30/20 4:43 PM, Andrew Lunn wrote:
>>> On Wed, Dec 30, 2020 at 01:53:57PM +0100, Marek Vasut wrote:
>>>> The KS8851 has a reduced internal PHY, which is accessible through its
>>>> registers at offset 0xe4. The PHY is compatible with KS886x PHY present
>>>> in Micrel switches, except the PHY ID Low/High registers are swapped.
>>>
>>> Can you intercept the reads in the KS8851 driver and swap them back
>>> again? The mv88e6xxx driver does something similar. The mv88e6393
>>> family of switches have PHYs with the Marvell OUI but no device ID. So
>>> the code traps these reads and provides an ID.
>>
>> I would prefer to keep this as-is, since then the PHY driver can match on
>> these swapped IDs and discern the PHY from PHY present in the KS886x switch.
>
> The problem is, this ID contains an OUI. Well, part of an OUI, the top
> two bits of the OUI are removed, leaving 22 bits of a 24 bit
> OUI. These OUIs are assigned to companies, well organisations. If you
> look at the reversed PHY ID, what are the 4 possible OUIs? Who are
> they assigned to? Are they ever likely to manufacture a PHY?
Are these OUIs used for anything else than identifying the PHY though ?
prev parent reply other threads:[~2021-01-03 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 12:53 [PATCH 1/2] net: phy: micrel: Add KS8851 PHY support Marek Vasut
2020-12-30 12:53 ` [PATCH 2/2] net: ks8851: Register MDIO bus and the internal PHY Marek Vasut
2020-12-30 16:00 ` Andrew Lunn
2021-01-03 12:58 ` Marek Vasut
2021-01-03 16:25 ` Andrew Lunn
2020-12-31 1:23 ` kernel test robot
2020-12-30 15:43 ` [PATCH 1/2] net: phy: micrel: Add KS8851 PHY support Andrew Lunn
2021-01-03 12:55 ` Marek Vasut
2021-01-03 16:55 ` Andrew Lunn
2021-01-03 18:44 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=252db93a-f52d-a5d4-505a-bf4a82328981@denx.de \
--to=marex@denx.de \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).