From: Marek Vasut <marex@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH 2/2] net: ks8851: Register MDIO bus and the internal PHY
Date: Sun, 3 Jan 2021 13:58:09 +0100 [thread overview]
Message-ID: <4139341d-86b7-db39-6586-d61fd41d8be7@denx.de> (raw)
In-Reply-To: <X+ykIqQhtjkuDQk9@lunn.ch>
On 12/30/20 5:00 PM, Andrew Lunn wrote:
>> +static int ks8851_mdio_read(struct mii_bus *bus, int phy_id, int reg)
>> +{
>> + struct ks8851_net *ks = bus->priv;
>> +
>> + if (phy_id != 0)
>> + return 0xffffffff;
>> +
>
> Please check for C45 and return -EOPNOTSUPP.
The ks8851_reg_read() does all the register checking already.
next prev parent reply other threads:[~2021-01-03 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 12:53 [PATCH 1/2] net: phy: micrel: Add KS8851 PHY support Marek Vasut
2020-12-30 12:53 ` [PATCH 2/2] net: ks8851: Register MDIO bus and the internal PHY Marek Vasut
2020-12-30 16:00 ` Andrew Lunn
2021-01-03 12:58 ` Marek Vasut [this message]
2021-01-03 16:25 ` Andrew Lunn
2020-12-31 1:23 ` kernel test robot
2020-12-30 15:43 ` [PATCH 1/2] net: phy: micrel: Add KS8851 PHY support Andrew Lunn
2021-01-03 12:55 ` Marek Vasut
2021-01-03 16:55 ` Andrew Lunn
2021-01-03 18:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4139341d-86b7-db39-6586-d61fd41d8be7@denx.de \
--to=marex@denx.de \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).