From: "Zhu, Lingshan" <lingshan.zhu@intel.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>,
Parav Pandit <parav@nvidia.com>, Jason Wang <jasowang@redhat.com>,
"mst@redhat.com" <mst@redhat.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xieyongji@bytedance.com" <xieyongji@bytedance.com>,
"gautam.dawar@amd.com" <gautam.dawar@amd.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH V3 3/6] vDPA: allow userspace to query features of a vDPA device
Date: Wed, 27 Jul 2022 19:38:27 +0800 [thread overview]
Message-ID: <35d6c4e1-6d04-7e77-9060-bf7256a5b60d@intel.com> (raw)
In-Reply-To: <a1bb599c-63be-a85e-5cff-6eed28abd347@oracle.com>
On 7/27/2022 4:15 PM, Si-Wei Liu wrote:
>
>
> On 7/5/2022 4:56 AM, Parav Pandit via Virtualization wrote:
>>> From: Zhu, Lingshan <lingshan.zhu@intel.com>
>>> Sent: Tuesday, July 5, 2022 3:59 AM
>>>
>>>
>>> On 7/4/2022 8:53 PM, Parav Pandit wrote:
>>>>> From: Jason Wang <jasowang@redhat.com>
>>>>> Sent: Monday, July 4, 2022 12:47 AM
>>>>>
>>>>>
>>>>> 在 2022/7/2 06:02, Parav Pandit 写道:
>>>>>>> From: Zhu Lingshan <lingshan.zhu@intel.com>
>>>>>>> Sent: Friday, July 1, 2022 9:28 AM
>>>>>>>
>>>>>>> This commit adds a new vDPA netlink attribution
>>>>>>> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query
>>>>> features
>>>>>>> of vDPA devices through this new attr.
>>>>>>>
>>>>>>> Fixes: a64917bc2e9b vdpa: (Provide interface to read driver
>>>>>>> feature)
>>>>>> Missing the "" in the line.
>>>>>> I reviewed the patches again.
>>>>>>
>>>>>> However, this is not the fix.
>>>>>> A fix cannot add a new UAPI.
>>>>>>
>>>>>> Code is already considering negotiated driver features to return the
>>>>>> device
>>>>> config space.
>>>>>> Hence it is fine.
>>>>>>
>>>>>> This patch intents to provide device features to user space.
>>>>>> First what vdpa device are capable of, are already returned by
>>>>>> features
>>>>> attribute on the management device.
>>>>>> This is done in commit [1].
>>>>>>
>>>>>> The only reason to have it is, when one management device indicates
>>>>>> that
>>>>> feature is supported, but device may end up not supporting this
>>>>> feature if such feature is shared with other devices on same
>>>>> physical device.
>>>>>> For example all VFs may not be symmetric after large number of them
>>>>>> are
>>>>> in use. In such case features bit of management device can differ
>>>>> (more
>>>>> features) than the vdpa device of this VF.
>>>>>> Hence, showing on the device is useful.
>>>>>>
>>>>>> As mentioned before in V2, commit [1] has wrongly named the
>>>>>> attribute to
>>>>> VDPA_ATTR_DEV_SUPPORTED_FEATURES.
>>>>>> It should have been,
>>>>> VDPA_ATTR_DEV_MGMTDEV_SUPPORTED_FEATURES.
>>>>>> Because it is in UAPI, and since we don't want to break compilation
>>>>>> of iproute2, It cannot be renamed anymore.
>>>>>>
>>>>>> Given that, we do not want to start trend of naming device
>>>>>> attributes with
>>>>> additional _VDPA_ to it as done in this patch.
>>>>>> Error in commit [1] was exception.
>>>>>>
>>>>>> Hence, please reuse VDPA_ATTR_DEV_SUPPORTED_FEATURES to return
>>>>> for device features too.
>>>>>
>>>>>
>>>>> This will probably break or confuse the existing userspace?
>>>>>
>>>> It shouldn't break, because its new attribute on the device.
>>>> All attributes are per command, so old one will not be confused
>>>> either.
>>> A netlink attr should has its own and unique purpose, that's why we
>>> don't need
>>> locks for the attrs, only one consumer and only one producer.
>>> I am afraid re-using (for both management device and the vDPA
>>> device) the attr
>>> VDPA_ATTR_DEV_SUPPORTED_FEATURES would lead to new race condition.
>>> E.g., There are possibilities of querying FEATURES of a management
>>> device and
>>> a vDPA device simultaneously, or can there be a syncing issue in a
>>> tick?
>> Both can be queried simultaneously. Each will return their own
>> feature bits using same attribute.
>> It wont lead to the race.
> Agreed. Multiple userspace callers would do recv() calls on different
> netlink sockets. Looks to me shouldn't involve any race.
oh yes, thanks for pointing this out, they are on different sockets
belonging to different userspace programs.
>>
>>> IMHO, I don't see any advantages of re-using this attr.
>> We don’t want to continue this mess of VDPA_DEV prefix for new
>> attributes due to previous wrong naming.
> Well, you can say it's a mess but since the attr name can be reused
> for different command, I didn't care that much while reviewing this.
> Actually, it was initially named this way to show the device features
> in "vdpa dev config ..." output, but later on it had been moved to
> mgmtdev to show parent's capability.
yes there is a buggy commit, but we can not change it now, because we
are not expected to break current uapi, so I think it is better to add a
new attr, no benefits to reuse another attr.
>
> -Siwei
>> _______________________________________________
>> Virtualization mailing list
>> Virtualization@lists.linux-foundation.org
>> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
>
next prev parent reply other threads:[~2022-07-27 11:39 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 13:28 [PATCH V3 0/6] ifcvf/vDPA: support query device config space through netlink Zhu Lingshan
2022-07-01 13:28 ` [PATCH V3 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation Zhu Lingshan
2022-07-04 4:39 ` Jason Wang
2022-07-08 6:44 ` Zhu, Lingshan
2022-07-13 5:44 ` Michael S. Tsirkin
2022-07-13 7:52 ` Zhu, Lingshan
2022-07-13 5:31 ` Michael S. Tsirkin
2022-07-13 7:48 ` Zhu, Lingshan
2022-07-01 13:28 ` [PATCH V3 2/6] vDPA/ifcvf: support userspace to query features and MQ of a management device Zhu Lingshan
2022-07-04 4:43 ` Jason Wang
2022-07-08 6:54 ` Zhu, Lingshan
2022-07-01 13:28 ` [PATCH V3 3/6] vDPA: allow userspace to query features of a vDPA device Zhu Lingshan
2022-07-01 22:02 ` Parav Pandit
2022-07-04 4:46 ` Jason Wang
2022-07-04 12:53 ` Parav Pandit
2022-07-05 7:59 ` Zhu, Lingshan
2022-07-05 11:56 ` Parav Pandit
2022-07-05 16:56 ` Zhu, Lingshan
2022-07-05 17:01 ` Parav Pandit
2022-07-06 2:25 ` Zhu, Lingshan
2022-07-06 2:28 ` Parav Pandit
2022-07-23 11:27 ` Zhu, Lingshan
2022-07-24 15:23 ` Parav Pandit
2022-07-27 8:15 ` Si-Wei Liu
2022-07-27 11:38 ` Zhu, Lingshan [this message]
2022-07-08 6:16 ` Zhu, Lingshan
2022-07-08 16:13 ` Parav Pandit
2022-07-11 2:18 ` Zhu, Lingshan
2022-07-01 13:28 ` [PATCH V3 4/6] vDPA: !FEATURES_OK should not block querying device config space Zhu Lingshan
2022-07-01 22:12 ` Parav Pandit
2022-07-08 6:22 ` Zhu, Lingshan
2022-07-13 5:23 ` Michael S. Tsirkin
2022-07-13 7:46 ` Zhu, Lingshan
[not found] ` <00889067-50ac-d2cd-675f-748f171e5c83@oracle.com>
[not found] ` <63242254-ba84-6810-dad8-34f900b97f2f@intel.com>
[not found] ` <8002554a-a77c-7b25-8f99-8d68248a741d@oracle.com>
2022-07-28 2:06 ` Jason Wang
2022-07-28 7:08 ` Si-Wei Liu
2022-07-28 7:36 ` Jason Wang
2022-07-28 7:44 ` Zhu, Lingshan
[not found] ` <2dfff5f3-3100-4a63-6da3-3e3d21ffb364@oracle.com>
2022-07-28 11:28 ` spec clarification (was Re: [PATCH V3 4/6] vDPA: !FEATURES_OK should not block querying device config space) Michael S. Tsirkin
2022-07-28 11:35 ` [PATCH V3 4/6] vDPA: !FEATURES_OK should not block querying device config space Michael S. Tsirkin
2022-07-28 22:12 ` Si-Wei Liu
[not found] ` <00e2e07e-1a2e-7af8-a060-cc9034e0d33f@intel.com>
[not found] ` <b58dba25-3258-d600-ea06-879094639852@oracle.com>
[not found] ` <c143e2da-208e-b046-9b8f-1780f75ed3e6@intel.com>
2022-07-29 20:55 ` Si-Wei Liu
2022-08-01 4:44 ` Jason Wang
2022-08-01 22:53 ` Si-Wei Liu
2022-08-01 22:58 ` Si-Wei Liu
2022-08-02 6:33 ` Jason Wang
2022-08-03 1:26 ` Si-Wei Liu
2022-08-03 2:30 ` Zhu, Lingshan
2022-08-03 23:09 ` Si-Wei Liu
2022-08-04 1:41 ` Zhu, Lingshan
2022-08-04 1:41 ` Zhu, Lingshan
2022-07-01 13:28 ` [PATCH V3 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0 Zhu Lingshan
2022-07-01 22:07 ` Parav Pandit
2022-07-08 6:21 ` Zhu, Lingshan
2022-07-08 16:23 ` Parav Pandit
2022-07-11 2:29 ` Zhu, Lingshan
2022-07-12 16:48 ` Parav Pandit
2022-07-13 3:03 ` Zhu, Lingshan
2022-07-13 3:06 ` Parav Pandit
2022-07-13 3:45 ` Zhu, Lingshan
2022-07-26 15:56 ` Parav Pandit
2022-07-26 19:52 ` Michael S. Tsirkin
2022-07-26 20:49 ` Parav Pandit
2022-07-27 2:14 ` Zhu, Lingshan
2022-07-27 2:17 ` Parav Pandit
2022-07-27 2:53 ` Zhu, Lingshan
2022-07-27 3:47 ` Parav Pandit
2022-07-27 4:24 ` Zhu, Lingshan
2022-07-27 6:01 ` Michael S. Tsirkin
2022-07-27 6:25 ` Zhu, Lingshan
2022-07-27 6:56 ` Jason Wang
2022-07-27 9:05 ` Michael S. Tsirkin
2022-07-27 6:54 ` Jason Wang
2022-07-27 9:02 ` Michael S. Tsirkin
2022-07-27 9:50 ` Jason Wang
2022-07-27 15:45 ` Michael S. Tsirkin
2022-07-28 1:21 ` Jason Wang
2022-07-28 3:46 ` Zhu, Lingshan
2022-07-28 5:53 ` Jason Wang
2022-07-28 6:02 ` Zhu, Lingshan
2022-07-28 6:41 ` Michael S. Tsirkin
2022-08-01 4:50 ` Jason Wang
2022-07-27 7:50 ` Si-Wei Liu
2022-07-27 9:01 ` Michael S. Tsirkin
2022-07-27 10:09 ` Si-Wei Liu
2022-07-27 11:54 ` Zhu, Lingshan
2022-07-28 1:41 ` Si-Wei Liu
2022-07-28 2:44 ` Zhu, Lingshan
2022-07-28 21:54 ` Si-Wei Liu
2022-07-29 2:07 ` Zhu, Lingshan
2022-07-27 15:48 ` Michael S. Tsirkin
2022-07-13 5:26 ` Michael S. Tsirkin
2022-07-13 7:47 ` Zhu, Lingshan
2022-07-26 15:54 ` Parav Pandit
2022-07-26 19:48 ` Michael S. Tsirkin
2022-07-26 20:53 ` Parav Pandit
2022-07-27 1:56 ` Zhu, Lingshan
2022-07-27 2:11 ` Zhu, Lingshan
2022-07-01 13:28 ` [PATCH V3 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa.c Zhu Lingshan
2022-07-01 22:18 ` Parav Pandit
2022-07-08 6:25 ` Zhu, Lingshan
2022-07-08 16:08 ` Parav Pandit
2022-07-29 8:53 ` Michael S. Tsirkin
2022-07-29 9:07 ` Zhu, Lingshan
2022-07-29 9:17 ` Michael S. Tsirkin
2022-07-29 9:20 ` Zhu, Lingshan
2022-07-29 9:23 ` Michael S. Tsirkin
2022-07-29 9:35 ` Zhu, Lingshan
2022-07-29 9:39 ` Michael S. Tsirkin
2022-07-29 10:01 ` Zhu, Lingshan
2022-07-29 10:16 ` Michael S. Tsirkin
2022-07-29 10:18 ` Zhu, Lingshan
2022-08-01 4:33 ` Jason Wang
2022-08-01 6:25 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d6c4e1-6d04-7e77-9060-bf7256a5b60d@intel.com \
--to=lingshan.zhu@intel.com \
--cc=gautam.dawar@amd.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).