From: Paolo Abeni <pabeni@redhat.com>
To: Alexander H Duyck <alexander.duyck@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Alexander Duyck <alexanderduyck@fb.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs
Date: Thu, 08 Sep 2022 13:00:50 +0200 [thread overview]
Message-ID: <498a25e4f7ba4e21d688ca74f335b28cadcb3381.camel@redhat.com> (raw)
In-Reply-To: <dcffcf6fde8272975e44124f55fba3936833360e.camel@gmail.com>
On Wed, 2022-09-07 at 14:36 -0700, Alexander H Duyck wrote:
> On Wed, 2022-09-07 at 22:19 +0200, Paolo Abeni wrote:
> > What outlined above will allow for 10 min size frags in page_order0, as
> > (SKB_DATA_ALIGN(0) + SKB_DATA_ALIGN(struct skb_shared_info) == 384. I'm
> > not sure that anything will allocate such small frags.
> > With a more reasonable GRO_MAX_HEAD, there will be 6 frags per page.
>
> That doesn't account for any headroom though.
Yes, the 0-size data packet was just a theoretical example to make the
really worst case scenario.
> Most of the time you have
> to reserve some space for headroom so that if this buffer ends up
> getting routed off somewhere to be tunneled there is room for adding to
> the header. I think the default ends up being NET_SKB_PAD, though many
> NICs use larger values. So adding any data onto that will push you up
> to a minimum of 512 per skb for the first 64B for header data.
>
> With that said it would probably put you in the range of 8 or fewer
> skbs per page assuming at least 1 byte for data:
> 512 = SKB_DATA_ALIGN(NET_SKB_PAD + 1) +
> SKB_DATA_ALIGN(struct skb_shared_info)
In most build GRO_MAX_HEAD packets are even larger (should be 640)
> > The maximum truesize underestimation in both cases will be lower than
> > what we can get with the current code in the worst case (almost 32x
> > AFAICS).
> >
> > Is the above schema safe enough or should the requested size
> > artificially inflatted to fit at most 4 allocations per page_order0?
> > Am I miss something else? Apart from omitting a good deal of testing in
> > the above list ;)
>
> If we are working with an order 0 page we may just want to split it up
> into a fixed 1K fragments and not bother with a variable pagecnt bias.
> Doing that we would likely simplify this quite a bit and avoid having
> to do as much page count manipulation which could get expensive if we
> are not getting many uses out of the page. An added advantage is that
> we can get rid of the pagecnt_bias and just work based on the page
> offset.
>
> As such I am not sure the page frag cache would really be that good of
> a fit since we have quite a bit of overhead in terms of maintaining the
> pagecnt_bias which assumes the page is a bit longer lived so the ratio
> of refcnt updates vs pagecnt_bias updates is better.
I see. With the above schema there will be 4-6 frags per packet. I'm
wild guessing that the pagecnt_bias optimization still give some gain
in that case, but I really shold collect some data points.
If the pagecnt optimization should be dropped, it would be probably
more straight-forward to use/adapt 'page_frag' for the page_order0
allocator.
BTW it's quite strange/confusing having to very similar APIs (page_frag
and page_frag_cache) with very similar names and no references between
them.
Thanks!
Paolo
next prev parent reply other threads:[~2022-09-08 11:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 16:18 [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs Eric Dumazet
2021-01-13 18:00 ` Alexander Duyck
2021-01-13 19:19 ` Michael S. Tsirkin
2021-01-13 22:23 ` David Laight
2021-01-14 5:16 ` Eric Dumazet
2021-01-14 9:29 ` David Laight
2021-01-14 19:00 ` patchwork-bot+netdevbpf
[not found] ` <1617007696.5731978-1-xuanzhuo@linux.alibaba.com>
2021-03-29 9:06 ` Eric Dumazet
2021-03-31 8:11 ` Michael S. Tsirkin
2021-03-31 8:36 ` Eric Dumazet
2021-03-31 8:46 ` Eric Dumazet
2021-03-31 8:49 ` Eric Dumazet
2021-03-31 8:54 ` Eric Dumazet
[not found] ` <1617248264.4993114-2-xuanzhuo@linux.alibaba.com>
2021-04-01 5:06 ` Eric Dumazet
[not found] ` <1617357110.3822439-1-xuanzhuo@linux.alibaba.com>
2021-04-02 12:52 ` Eric Dumazet
2021-04-01 13:51 ` Michael S. Tsirkin
2021-04-01 14:08 ` Eric Dumazet
2021-04-01 7:14 ` Jason Wang
[not found] ` <1617267183.5697193-1-xuanzhuo@linux.alibaba.com>
2021-04-01 9:58 ` Eric Dumazet
2021-04-02 2:52 ` Jason Wang
[not found] ` <1617361253.1788838-2-xuanzhuo@linux.alibaba.com>
2021-04-02 12:53 ` Eric Dumazet
2021-04-06 2:04 ` Jason Wang
[not found] ` <1617190239.1035674-1-xuanzhuo@linux.alibaba.com>
2021-03-31 12:08 ` Eric Dumazet
2021-04-01 13:36 ` Michael S. Tsirkin
2022-09-07 20:19 ` Paolo Abeni
2022-09-07 20:40 ` Eric Dumazet
2022-09-08 10:48 ` Paolo Abeni
2022-09-08 12:20 ` Eric Dumazet
2022-09-08 14:26 ` Paolo Abeni
2022-09-08 16:00 ` Eric Dumazet
2022-09-07 21:36 ` Alexander H Duyck
2022-09-08 11:00 ` Paolo Abeni [this message]
2022-09-08 14:53 ` Alexander H Duyck
2022-09-08 18:01 ` Paolo Abeni
2022-09-08 19:26 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498a25e4f7ba4e21d688ca74f335b28cadcb3381.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gthelen@google.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).