[PATCH] bcma: don't fail for bad SPROM CRC

* [PATCH] bcma: don't fail for bad SPROM CRC
@ 2012-02-06 13:26 Henrik Rydberg
  2012-02-06 13:34 ` Arend van Spriel
  2012-02-06 17:08 ` Rafał Miłecki
  0 siblings, 2 replies; 6+ messages in thread
From: Henrik Rydberg @ 2012-02-06 13:26 UTC (permalink / raw)
  To: John W. Linville
  Cc: netdev, Henrik Rydberg, Arend van Spriel, Franky (Zhenhui) Lin,
	Rafał Miłecki

The brcmsmac driver is now checking the bcma SPROM CRCs, leaving some
chipsets unrecognized that were functional prior to the switch. In
particular, the current code bails out on recent Macbooks. This patch
simply ignores the outcome of the CRC check, with the argument that an
unrecognized SPROM should be treated similarly to a non-existing one.

Cc: Arend van Spriel <arend@broadcom.com>
Cc: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Cc: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
Hi John,

It seems this patch may have gotten lost, at least I have not seen it
on any of the net/wireless parties. Arend, are you ok with the final
wording?

Thanks,
Henrik

 drivers/bcma/main.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index febbc0a..ec31f7d 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -169,10 +169,8 @@ int bcma_bus_register(struct bcma_bus *bus)
 	err = bcma_sprom_get(bus);
 	if (err == -ENOENT) {
 		pr_err("No SPROM available\n");
-	} else if (err) {
+	} else if (err)
 		pr_err("Failed to get SPROM: %d\n", err);
-		return -ENOENT;
-	}
 
 	/* Register found cores */
 	bcma_register_cores(bus);
-- 
1.7.9

^ permalink raw reply related	[flat|nested] 6+ messages in thread