* RE: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping [not found] <7D3B6706FA74174B8C1AC24710890745136F1A0C15@USNAVSXCHMBSA1.ndc.alcatel-lucent.com> @ 2012-02-02 17:00 ` Cloutier, Joseph (Joseph) 2012-02-06 20:54 ` Cloutier, Joseph (Joseph) 1 sibling, 0 replies; 5+ messages in thread From: Cloutier, Joseph (Joseph) @ 2012-02-02 17:00 UTC (permalink / raw) To: 'YOSHIFUJI Hideaki' Cc: 'netdev@vger.kernel.org', 'Linus Torvalds' Yoshifuji- was this submission ok? Can you tell me the status of it? I am giving a talk to Verizon Wireless Engineers on trouble shooting again and would like to give them a status update on the "-w deadline" change. Thanks, Joe -----Original Message----- From: Cloutier, Joseph (Joseph) Sent: Tuesday, January 10, 2012 1:01 PM To: 'YOSHIFUJI Hideaki' Cc: 'netdev@vger.kernel.org'; 'Linus Torvalds' Subject: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping From: Joseph Cloutier <jcloutier@alcatel-lucent.com> 2 changes to ping & ping6. Only ping_common.c affected. 1- changed "-w deadline" to start deadline after "-c" pings have been transmitted, instead of from start of run. 2- fixed bug where > "-c" pings are sent in flood ping mode when "-w deadline" option is also used. Reason: Linux flood ping is an invaluable tool to finding duplex bugs, fiber problems, NE config problems- especially when used to trouble shoot wireless system backhaul problems. ANY dropped pings are red flag indicators. Current ping problem is that it terminates sometimes when outstanding pings are in transit, giving FALSE red flags. Change "-w deadline" to start after last "-c" transmitted ping allows cleanup of stragglers. Second fix is when "-f" option is running, "-c" is not rigorously checked when generating pings A more rigorous check was added. Signed-off-by: Joseph Cloutier <jcloutier@alcatel-lucent.com> --- --- iputils-s20101006/ping_common.c.orig 2012-01-10 10:37:40.399719858 -0500 +++ iputils-s20101006/ping_common.c 2012-01-10 11:33:37.084662882 -0500 @@ -523,16 +523,6 @@ void setup(int icmp_sock) gettimeofday(&start_time, NULL); - if (deadline) { - struct itimerval it; - - it.it_interval.tv_sec = 0; - it.it_interval.tv_usec = 0; - it.it_value.tv_sec = deadline; - it.it_value.tv_usec = 0; - setitimer(ITIMER_REAL, &it, NULL); - } - if (isatty(STDOUT_FILENO)) { struct winsize w; @@ -553,6 +543,7 @@ void main_loop(int icmp_sock, __u8 *pack int cc; int next; int polling; + int sig_deadline = 0; iov.iov_base = (char *)packet; @@ -567,9 +558,22 @@ void main_loop(int icmp_sock, __u8 *pack /* Check for and do special actions. */ if (status_snapshot) status(); + if((npackets == ntransmitted) && deadline && + (sig_deadline == 0)){ + sig_deadline++; + struct itimerval it; + + it.it_interval.tv_sec = 0; + it.it_interval.tv_usec = 0; + it.it_value.tv_sec = deadline; + it.it_value.tv_usec = 0; + setitimer(ITIMER_REAL, &it, NULL); + } /* Send probes scheduled to this time. */ do { + if(npackets == ntransmitted) + break; next = pinger(); next = schedule_exit(next); } while (next <= 0); ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping [not found] <7D3B6706FA74174B8C1AC24710890745136F1A0C15@USNAVSXCHMBSA1.ndc.alcatel-lucent.com> 2012-02-02 17:00 ` [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Cloutier, Joseph (Joseph) @ 2012-02-06 20:54 ` Cloutier, Joseph (Joseph) 2012-02-21 12:21 ` YOSHIFUJI Hideaki 1 sibling, 1 reply; 5+ messages in thread From: Cloutier, Joseph (Joseph) @ 2012-02-06 20:54 UTC (permalink / raw) To: 'YOSHIFUJI Hideaki' Cc: 'netdev@vger.kernel.org', 'Linus Torvalds' Hideaki, can you give me any status on this request? Was it rejected, is it pending? Thanks, Joe Cloutier -----Original Message----- From: Cloutier, Joseph (Joseph) Sent: Tuesday, January 10, 2012 1:01 PM To: 'YOSHIFUJI Hideaki' Cc: 'netdev@vger.kernel.org'; 'Linus Torvalds' Subject: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping From: Joseph Cloutier <jcloutier@alcatel-lucent.com> 2 changes to ping & ping6. Only ping_common.c affected. 1- changed "-w deadline" to start deadline after "-c" pings have been transmitted, instead of from start of run. 2- fixed bug where > "-c" pings are sent in flood ping mode when "-w deadline" option is also used. Reason: Linux flood ping is an invaluable tool to finding duplex bugs, fiber problems, NE config problems- especially when used to trouble shoot wireless system backhaul problems. ANY dropped pings are red flag indicators. Current ping problem is that it terminates sometimes when outstanding pings are in transit, giving FALSE red flags. Change "-w deadline" to start after last "-c" transmitted ping allows cleanup of stragglers. Second fix is when "-f" option is running, "-c" is not rigorously checked when generating pings A more rigorous check was added. Signed-off-by: Joseph Cloutier <jcloutier@alcatel-lucent.com> --- --- iputils-s20101006/ping_common.c.orig 2012-01-10 10:37:40.399719858 -0500 +++ iputils-s20101006/ping_common.c 2012-01-10 11:33:37.084662882 -0500 @@ -523,16 +523,6 @@ void setup(int icmp_sock) gettimeofday(&start_time, NULL); - if (deadline) { - struct itimerval it; - - it.it_interval.tv_sec = 0; - it.it_interval.tv_usec = 0; - it.it_value.tv_sec = deadline; - it.it_value.tv_usec = 0; - setitimer(ITIMER_REAL, &it, NULL); - } - if (isatty(STDOUT_FILENO)) { struct winsize w; @@ -553,6 +543,7 @@ void main_loop(int icmp_sock, __u8 *pack int cc; int next; int polling; + int sig_deadline = 0; iov.iov_base = (char *)packet; @@ -567,9 +558,22 @@ void main_loop(int icmp_sock, __u8 *pack /* Check for and do special actions. */ if (status_snapshot) status(); + if((npackets == ntransmitted) && deadline && + (sig_deadline == 0)){ + sig_deadline++; + struct itimerval it; + + it.it_interval.tv_sec = 0; + it.it_interval.tv_usec = 0; + it.it_value.tv_sec = deadline; + it.it_value.tv_usec = 0; + setitimer(ITIMER_REAL, &it, NULL); + } /* Send probes scheduled to this time. */ do { + if(npackets == ntransmitted) + break; next = pinger(); next = schedule_exit(next); } while (next <= 0); ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping 2012-02-06 20:54 ` Cloutier, Joseph (Joseph) @ 2012-02-21 12:21 ` YOSHIFUJI Hideaki 2012-02-21 14:08 ` Cloutier, Joseph (Joseph) 0 siblings, 1 reply; 5+ messages in thread From: YOSHIFUJI Hideaki @ 2012-02-21 12:21 UTC (permalink / raw) To: Cloutier, Joseph (Joseph) Cc: 'netdev@vger.kernel.org', 'Linus Torvalds', YOSHIFUJI Hideaki Joseph, Cloutier, Joseph (Joseph) wrote: > Hideaki, can you give me any status on this request? Was it rejected, is it pending? Thanks, Joe Cloutier I asked you to tell me if -W is okay for your purpose. If -W is not suitable, please introduce new option (maybe -ww?). Regards, --yoshfuji > -----Original Message----- > From: Cloutier, Joseph (Joseph) > Sent: Tuesday, January 10, 2012 1:01 PM > To: 'YOSHIFUJI Hideaki' > Cc: 'netdev@vger.kernel.org'; 'Linus Torvalds' > Subject: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after > "-c" xmitted, and "-c" was exceeded for flood ping > > > From: Joseph Cloutier<jcloutier@alcatel-lucent.com> > > 2 changes to ping& ping6. Only ping_common.c affected. > 1- changed "-w deadline" to start deadline after "-c" pings have been transmitted, instead of from start of run. > 2- fixed bug where> "-c" pings are sent in flood ping mode when "-w deadline" option is also used. > Reason: > Linux flood ping is an invaluable tool to finding duplex bugs, fiber problems, NE config problems- especially > when used to trouble shoot wireless system backhaul problems. ANY dropped pings are red flag indicators. > Current ping problem is that it terminates sometimes when outstanding pings are in transit, giving FALSE red > flags. Change "-w deadline" to start after last "-c" transmitted ping allows cleanup of stragglers. Second fix is > when "-f" option is running, "-c" is not rigorously checked when generating pings A more rigorous check was > added. > > Signed-off-by: Joseph Cloutier<jcloutier@alcatel-lucent.com> > > --- > --- iputils-s20101006/ping_common.c.orig 2012-01-10 10:37:40.399719858 -0500 > +++ iputils-s20101006/ping_common.c 2012-01-10 11:33:37.084662882 -0500 > @@ -523,16 +523,6 @@ void setup(int icmp_sock) > > gettimeofday(&start_time, NULL); > > - if (deadline) { > - struct itimerval it; > - > - it.it_interval.tv_sec = 0; > - it.it_interval.tv_usec = 0; > - it.it_value.tv_sec = deadline; > - it.it_value.tv_usec = 0; > - setitimer(ITIMER_REAL,&it, NULL); > - } > - > if (isatty(STDOUT_FILENO)) { > struct winsize w; > > @@ -553,6 +543,7 @@ void main_loop(int icmp_sock, __u8 *pack > int cc; > int next; > int polling; > + int sig_deadline = 0; > > iov.iov_base = (char *)packet; > > @@ -567,9 +558,22 @@ void main_loop(int icmp_sock, __u8 *pack > /* Check for and do special actions. */ > if (status_snapshot) > status(); > + if((npackets == ntransmitted)&& deadline&& > + (sig_deadline == 0)){ > + sig_deadline++; > + struct itimerval it; > + > + it.it_interval.tv_sec = 0; > + it.it_interval.tv_usec = 0; > + it.it_value.tv_sec = deadline; > + it.it_value.tv_usec = 0; > + setitimer(ITIMER_REAL,&it, NULL); > + } > > /* Send probes scheduled to this time. */ > do { > + if(npackets == ntransmitted) > + break; > next = pinger(); > next = schedule_exit(next); > } while (next<= 0); ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping 2012-02-21 12:21 ` YOSHIFUJI Hideaki @ 2012-02-21 14:08 ` Cloutier, Joseph (Joseph) 0 siblings, 0 replies; 5+ messages in thread From: Cloutier, Joseph (Joseph) @ 2012-02-21 14:08 UTC (permalink / raw) To: 'YOSHIFUJI Hideaki' Cc: 'netdev@vger.kernel.org', 'Linus Torvalds' I tried "ping -f -c 1000 -s 1472 -l 20 135.112.91.184 -W 5" and it seems "-W 5" is not working; it might be disabled by "-f". I will submit a change using a new feature "-ww". I agree it is probably best not to try to redefine an existing option. Yoshfuji- I am giving a talk to our major Customer Thursday and they are asking about this. Can I say that we will be adding a new command line option to Linux ping that will give them the feature they need? Thanks, Joe -----Original Message----- From: YOSHIFUJI Hideaki [mailto:yoshfuji@linux-ipv6.org] Sent: Tuesday, February 21, 2012 7:22 AM To: Cloutier, Joseph (Joseph) Cc: 'netdev@vger.kernel.org'; 'Linus Torvalds'; YOSHIFUJI Hideaki Subject: Re: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Joseph, Cloutier, Joseph (Joseph) wrote: > Hideaki, can you give me any status on this request? Was it rejected, is it pending? Thanks, Joe Cloutier I asked you to tell me if -W is okay for your purpose. If -W is not suitable, please introduce new option (maybe -ww?). Regards, --yoshfuji > -----Original Message----- > From: Cloutier, Joseph (Joseph) > Sent: Tuesday, January 10, 2012 1:01 PM > To: 'YOSHIFUJI Hideaki' > Cc: 'netdev@vger.kernel.org'; 'Linus Torvalds' > Subject: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after > "-c" xmitted, and "-c" was exceeded for flood ping > > > From: Joseph Cloutier<jcloutier@alcatel-lucent.com> > > 2 changes to ping& ping6. Only ping_common.c affected. > 1- changed "-w deadline" to start deadline after "-c" pings have been transmitted, instead of from start of run. > 2- fixed bug where> "-c" pings are sent in flood ping mode when "-w deadline" option is also used. > Reason: > Linux flood ping is an invaluable tool to finding duplex bugs, fiber problems, NE config problems- especially > when used to trouble shoot wireless system backhaul problems. ANY dropped pings are red flag indicators. > Current ping problem is that it terminates sometimes when outstanding pings are in transit, giving FALSE red > flags. Change "-w deadline" to start after last "-c" transmitted ping allows cleanup of stragglers. Second fix is > when "-f" option is running, "-c" is not rigorously checked when generating pings A more rigorous check was > added. > > Signed-off-by: Joseph Cloutier<jcloutier@alcatel-lucent.com> > > --- > --- iputils-s20101006/ping_common.c.orig 2012-01-10 10:37:40.399719858 -0500 > +++ iputils-s20101006/ping_common.c 2012-01-10 11:33:37.084662882 -0500 > @@ -523,16 +523,6 @@ void setup(int icmp_sock) > > gettimeofday(&start_time, NULL); > > - if (deadline) { > - struct itimerval it; > - > - it.it_interval.tv_sec = 0; > - it.it_interval.tv_usec = 0; > - it.it_value.tv_sec = deadline; > - it.it_value.tv_usec = 0; > - setitimer(ITIMER_REAL,&it, NULL); > - } > - > if (isatty(STDOUT_FILENO)) { > struct winsize w; > > @@ -553,6 +543,7 @@ void main_loop(int icmp_sock, __u8 *pack > int cc; > int next; > int polling; > + int sig_deadline = 0; > > iov.iov_base = (char *)packet; > > @@ -567,9 +558,22 @@ void main_loop(int icmp_sock, __u8 *pack > /* Check for and do special actions. */ > if (status_snapshot) > status(); > + if((npackets == ntransmitted)&& deadline&& > + (sig_deadline == 0)){ > + sig_deadline++; > + struct itimerval it; > + > + it.it_interval.tv_sec = 0; > + it.it_interval.tv_usec = 0; > + it.it_value.tv_sec = deadline; > + it.it_value.tv_usec = 0; > + setitimer(ITIMER_REAL,&it, NULL); > + } > > /* Send probes scheduled to this time. */ > do { > + if(npackets == ntransmitted) > + break; > next = pinger(); > next = schedule_exit(next); > } while (next<= 0); ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "-w deadline" bug in ping/iputils- i will provide fix if you can tell me where owner of iputils is. Thanks.
@ 2012-01-10 3:54 YOSHIFUJI Hideaki
2012-01-10 18:00 ` [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Cloutier, Joseph (Joseph)
0 siblings, 1 reply; 5+ messages in thread
From: YOSHIFUJI Hideaki @ 2012-01-10 3:54 UTC (permalink / raw)
To: Cloutier, Joseph (Joseph)
Cc: 'netdev@vger.kernel.org',
YOSHIFUJI Hideaki, 'Linus Torvalds'
Hello.
Cloutier, Joseph (Joseph) wrote:
> I have made a fix for the "-w deadline" issue to iputils-s20101006.tar.bz2. There are 4 places in the code with the fix, identified by my name, Joe Cloutier- ALU.
>>
>> There are 2 bugs fixed:
>> * For flood pings if the "-w" option is set then more pings than "-c x" are sent out.
>> * The "-w x" timer should be set after he last "-c x" ping is sent out.
Is this a real bug?
If both of -c COUNT and -w TIMEOUT are specified, ping exits by
timer _OR_ by the counter regardless of -f option.
If you want to ping really COUNT times, try -W TIMEOUT option.
... And please send your changes in the patch (or unified diff;
diff -u) format with your appropriate "sign-off" line, next time.
Thanks.
--yoshfuji
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping 2012-01-10 3:54 "-w deadline" bug in ping/iputils- i will provide fix if you can tell me where owner of iputils is. Thanks YOSHIFUJI Hideaki @ 2012-01-10 18:00 ` Cloutier, Joseph (Joseph) 0 siblings, 0 replies; 5+ messages in thread From: Cloutier, Joseph (Joseph) @ 2012-01-10 18:00 UTC (permalink / raw) To: 'YOSHIFUJI Hideaki' Cc: 'netdev@vger.kernel.org', 'Linus Torvalds' From: Joseph Cloutier <jcloutier@alcatel-lucent.com> 2 changes to ping & ping6. Only ping_common.c affected. 1- changed "-w deadline" to start deadline after "-c" pings have been transmitted, instead of from start of run. 2- fixed bug where > "-c" pings are sent in flood ping mode when "-w deadline" option is also used. Reason: Linux flood ping is an invaluable tool to finding duplex bugs, fiber problems, NE config problems- especially when used to trouble shoot wireless system backhaul problems. ANY dropped pings are red flag indicators. Current ping problem is that it terminates sometimes when outstanding pings are in transit, giving FALSE red flags. Change "-w deadline" to start after last "-c" transmitted ping allows cleanup of stragglers. Second fix is when "-f" option is running, "-c" is not rigorously checked when generating pings A more rigorous check was added. Signed-off-by: Joseph Cloutier <jcloutier@alcatel-lucent.com> --- --- iputils-s20101006/ping_common.c.orig 2012-01-10 10:37:40.399719858 -0500 +++ iputils-s20101006/ping_common.c 2012-01-10 11:33:37.084662882 -0500 @@ -523,16 +523,6 @@ void setup(int icmp_sock) gettimeofday(&start_time, NULL); - if (deadline) { - struct itimerval it; - - it.it_interval.tv_sec = 0; - it.it_interval.tv_usec = 0; - it.it_value.tv_sec = deadline; - it.it_value.tv_usec = 0; - setitimer(ITIMER_REAL, &it, NULL); - } - if (isatty(STDOUT_FILENO)) { struct winsize w; @@ -553,6 +543,7 @@ void main_loop(int icmp_sock, __u8 *pack int cc; int next; int polling; + int sig_deadline = 0; iov.iov_base = (char *)packet; @@ -567,9 +558,22 @@ void main_loop(int icmp_sock, __u8 *pack /* Check for and do special actions. */ if (status_snapshot) status(); + if((npackets == ntransmitted) && deadline && + (sig_deadline == 0)){ + sig_deadline++; + struct itimerval it; + + it.it_interval.tv_sec = 0; + it.it_interval.tv_usec = 0; + it.it_value.tv_sec = deadline; + it.it_value.tv_usec = 0; + setitimer(ITIMER_REAL, &it, NULL); + } /* Send probes scheduled to this time. */ do { + if(npackets == ntransmitted) + break; next = pinger(); next = schedule_exit(next); } while (next <= 0); ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-21 14:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <7D3B6706FA74174B8C1AC24710890745136F1A0C15@USNAVSXCHMBSA1.ndc.alcatel-lucent.com>
2012-02-02 17:00 ` [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Cloutier, Joseph (Joseph)
2012-02-06 20:54 ` Cloutier, Joseph (Joseph)
2012-02-21 12:21 ` YOSHIFUJI Hideaki
2012-02-21 14:08 ` Cloutier, Joseph (Joseph)
2012-01-10 3:54 "-w deadline" bug in ping/iputils- i will provide fix if you can tell me where owner of iputils is. Thanks YOSHIFUJI Hideaki
2012-01-10 18:00 ` [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Cloutier, Joseph (Joseph)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).