From: Sean Nyekjaer <sean@geanix.com>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
"mkl@pengutronix.de" <mkl@pengutronix.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe stage
Date: Wed, 27 Nov 2019 10:58:24 +0100 [thread overview]
Message-ID: <5fe4918e-2ec1-0b88-1f02-3c2d39c99e07@geanix.com> (raw)
In-Reply-To: <20191127055334.1476-3-qiangqing.zhang@nxp.com>
On 27/11/2019 06.56, Joakim Zhang wrote:
> CAN controller could be stucked in stop mode once it enters stop mode
> when suspend, and then it fails to exit stop mode when resume. Only code
> reset can get CAN out of stop mode, so add stop mode remove request
> during probe stage for other methods(soft reset from chip level,
> unbind/bind driver, etc) to let CAN active again. MCR[LPMACK] will be
> checked when enable CAN in register_flexcandev().
>
> Suggested-by: Sean Nyekjaer <sean@geanix.com>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Tested-by: Sean Nyekjaer <sean@geanix.com>
> ------
> ChangeLog:
> V1->V2: new add.
> ---
> drivers/net/can/flexcan.c | 28 ++++++++++++++++++++++------
> 1 file changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 2297663cacb2..5d5ed28d3005 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -449,6 +449,13 @@ static inline int flexcan_exit_stop_mode(struct flexcan_priv *priv)
> return 0;
> }
>
> +static void flexcan_try_exit_stop_mode(struct flexcan_priv *priv)
> +{
> + /* remove stop request */
> + regmap_update_bits(priv->stm.gpr, priv->stm.req_gpr,
> + 1 << priv->stm.req_bit, 0);
> +}
> +
> static inline void flexcan_error_irq_enable(const struct flexcan_priv *priv)
> {
> struct flexcan_regs __iomem *regs = priv->regs;
> @@ -1649,6 +1656,21 @@ static int flexcan_probe(struct platform_device *pdev)
> priv->devtype_data = devtype_data;
> priv->reg_xceiver = reg_xceiver;
>
> + if (priv->devtype_data->quirks & FLEXCAN_QUIRK_SETUP_STOP_MODE) {
> + err = flexcan_setup_stop_mode(pdev);
> + if (err)
> + dev_dbg(&pdev->dev, "failed to setup stop-mode\n");
> +
> + /* CAN controller could be stucked in stop mode once it enters
> + * stop mode when suspend, and then it fails to exit stop
> + * mode when resume. Only code reset can get CAN out of stop
> + * mode, so add stop mode remove request here for other methods
> + * (soft reset, bind, etc) to let CAN active again. MCR[LPMACK]
> + * will be checked when enable CAN in register_flexcandev().
> + */
> + flexcan_try_exit_stop_mode(priv);
> + }
> +
> pm_runtime_get_noresume(&pdev->dev);
> pm_runtime_set_active(&pdev->dev);
> pm_runtime_enable(&pdev->dev);
> @@ -1661,12 +1683,6 @@ static int flexcan_probe(struct platform_device *pdev)
>
> devm_can_led_init(dev);
>
> - if (priv->devtype_data->quirks & FLEXCAN_QUIRK_SETUP_STOP_MODE) {
> - err = flexcan_setup_stop_mode(pdev);
> - if (err)
> - dev_dbg(&pdev->dev, "failed to setup stop-mode\n");
> - }
> -
> return 0;
>
> failed_register:
>
next prev parent reply other threads:[~2019-11-27 9:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 5:56 [PATCH V2 0/4] can: flexcan: fixes for stop mode Joakim Zhang
2019-11-27 5:56 ` [PATCH V2 1/4] can: flexcan: fix deadlock when using self wakeup Joakim Zhang
2019-11-27 9:58 ` Sean Nyekjaer
2019-12-03 17:25 ` Marc Kleine-Budde
2019-12-03 17:42 ` Marc Kleine-Budde
2019-12-04 1:58 ` Joakim Zhang
2019-12-04 8:31 ` Marc Kleine-Budde
2019-12-04 8:35 ` Joakim Zhang
2019-11-27 5:56 ` [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe stage Joakim Zhang
2019-11-27 9:58 ` Sean Nyekjaer [this message]
2019-12-03 18:14 ` Marc Kleine-Budde
2019-12-04 2:22 ` Joakim Zhang
2019-12-04 8:45 ` Marc Kleine-Budde
2019-12-04 9:58 ` Joakim Zhang
2019-12-05 8:46 ` Joakim Zhang
2019-12-05 9:21 ` Sean Nyekjaer
2019-12-05 11:04 ` Joakim Zhang
2019-12-05 11:11 ` Sean Nyekjaer
2019-12-05 11:19 ` Joakim Zhang
2019-12-05 11:32 ` Sean Nyekjaer
2019-12-07 20:32 ` Marc Kleine-Budde
2019-12-08 10:47 ` Sean Nyekjaer
2019-12-08 10:56 ` Marc Kleine-Budde
2019-11-27 5:56 ` [PATCH V2 3/4] can: flexcan: change the way of stop mode acknowledgment Joakim Zhang
2019-11-27 9:58 ` Sean Nyekjaer
2019-12-03 18:21 ` Marc Kleine-Budde
2019-12-04 2:23 ` Joakim Zhang
2019-11-27 5:56 ` [PATCH V2 4/4] can: flexcan: add LPSR mode support Joakim Zhang
2019-12-04 2:25 ` Joakim Zhang
2019-12-04 8:59 ` Marc Kleine-Budde
2019-12-04 9:58 ` Joakim Zhang
2019-12-04 9:20 ` Marc Kleine-Budde
2019-12-04 9:59 ` Joakim Zhang
2019-12-04 10:58 ` Joakim Zhang
2019-11-27 6:12 ` [PATCH V2 0/4] can: flexcan: fixes for stop mode Sean Nyekjaer
2019-11-27 8:12 ` Sean Nyekjaer
2019-11-27 9:36 ` Joakim Zhang
2019-11-27 9:48 ` Joakim Zhang
2019-11-27 9:52 ` Sean Nyekjaer
2019-11-27 9:58 ` Joakim Zhang
2019-11-27 9:59 ` Sean Nyekjaer
2019-11-27 10:04 ` Joakim Zhang
2019-12-03 10:16 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fe4918e-2ec1-0b88-1f02-3c2d39c99e07@geanix.com \
--to=sean@geanix.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).