From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Sean Nyekjaer <sean@geanix.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe stage
Date: Sat, 7 Dec 2019 21:32:05 +0100 [thread overview]
Message-ID: <2c8f83aa-e7e6-ba15-1e42-2cb834da1c48@pengutronix.de> (raw)
In-Reply-To: <3a4102bc-8a86-3425-e227-590c005df044@geanix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1113 bytes --]
On 12/5/19 12:32 PM, Sean Nyekjaer wrote:
>> If yes, I think we don't need check stop mode in probe stage, since
>> issue has disappeared automatically.
>
> If one have devices deployed where:
> "can: flexcan: fix deadlock when using self wakeup" isn't applied.
> They could have devices stuck in stop-mode.
Ok.
But both patches:
can: flexcan: fix deadlock when using self wakeup
can: flexcan: try to exit stop mode during probe stage
are not yet mainline, so if "can: flexcan: fix deadlock when using self
wakeup" fixes the problem and goes into stable we don't need "can:
flexcan: try to exit stop mode during probe stage", right?
> That's what i meant by this patch doesn't do any harm to have the check
> included.
I don't want to have code in the driver that serves no purpose.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-12-08 10:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 5:56 [PATCH V2 0/4] can: flexcan: fixes for stop mode Joakim Zhang
2019-11-27 5:56 ` [PATCH V2 1/4] can: flexcan: fix deadlock when using self wakeup Joakim Zhang
2019-11-27 9:58 ` Sean Nyekjaer
2019-12-03 17:25 ` Marc Kleine-Budde
2019-12-03 17:42 ` Marc Kleine-Budde
2019-12-04 1:58 ` Joakim Zhang
2019-12-04 8:31 ` Marc Kleine-Budde
2019-12-04 8:35 ` Joakim Zhang
2019-11-27 5:56 ` [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe stage Joakim Zhang
2019-11-27 9:58 ` Sean Nyekjaer
2019-12-03 18:14 ` Marc Kleine-Budde
2019-12-04 2:22 ` Joakim Zhang
2019-12-04 8:45 ` Marc Kleine-Budde
2019-12-04 9:58 ` Joakim Zhang
2019-12-05 8:46 ` Joakim Zhang
2019-12-05 9:21 ` Sean Nyekjaer
2019-12-05 11:04 ` Joakim Zhang
2019-12-05 11:11 ` Sean Nyekjaer
2019-12-05 11:19 ` Joakim Zhang
2019-12-05 11:32 ` Sean Nyekjaer
2019-12-07 20:32 ` Marc Kleine-Budde [this message]
2019-12-08 10:47 ` Sean Nyekjaer
2019-12-08 10:56 ` Marc Kleine-Budde
2019-11-27 5:56 ` [PATCH V2 3/4] can: flexcan: change the way of stop mode acknowledgment Joakim Zhang
2019-11-27 9:58 ` Sean Nyekjaer
2019-12-03 18:21 ` Marc Kleine-Budde
2019-12-04 2:23 ` Joakim Zhang
2019-11-27 5:56 ` [PATCH V2 4/4] can: flexcan: add LPSR mode support Joakim Zhang
2019-12-04 2:25 ` Joakim Zhang
2019-12-04 8:59 ` Marc Kleine-Budde
2019-12-04 9:58 ` Joakim Zhang
2019-12-04 9:20 ` Marc Kleine-Budde
2019-12-04 9:59 ` Joakim Zhang
2019-12-04 10:58 ` Joakim Zhang
2019-11-27 6:12 ` [PATCH V2 0/4] can: flexcan: fixes for stop mode Sean Nyekjaer
2019-11-27 8:12 ` Sean Nyekjaer
2019-11-27 9:36 ` Joakim Zhang
2019-11-27 9:48 ` Joakim Zhang
2019-11-27 9:52 ` Sean Nyekjaer
2019-11-27 9:58 ` Joakim Zhang
2019-11-27 9:59 ` Sean Nyekjaer
2019-11-27 10:04 ` Joakim Zhang
2019-12-03 10:16 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c8f83aa-e7e6-ba15-1e42-2cb834da1c48@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).