From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Cc: Ido Schimmel <idosch@mellanox.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>,
jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [PATCH net-next v2 0/9] net: Get rid of switchdev_port_attr_get()
Date: Fri, 15 Feb 2019 16:37:38 -0800 [thread overview]
Message-ID: <77c28e2d-cd29-4932-5cfe-64799c730ede@gmail.com> (raw)
In-Reply-To: <20190215225313.32303-1-f.fainelli@gmail.com>
On 2/15/19 2:53 PM, Florian Fainelli wrote:
> Hi all,
>
> This patch series splits the removal of the switchdev_ops that was
> proposed a few times before and first tackles the easy part which is the
> removal of the single call to switchdev_port_attr_get() within the
> bridge code.
>
> As suggestd by Ido, this patch series adds a
> SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS which is used in the same
> context as the caller of switchdev_port_attr_set(), so not deferred, and
> then the operation is carried out in deferred context with setting a
> support bridge port flag.
>
> Follow-up patches will do the switchdev_ops removal after introducing
> the proper helpers for the switchdev blocking notifier to work across
> stacked devices (unlike the previous submissions).
David, please ignore this version, I will repost one that actually
builds, need to keep mangling with my kernel configuration and keep
those drivers enabled...
>
> Changes in v2:
>
> - differentiate callers not supporting switchdev_port_attr_set() from
> the driver not being able to support specific bridge flags
>
> - pass "mask" instead of "flags" for the PRE_BRIDGE_FLAGS check
>
> - skip prepare phase for PRE_BRIDGE_FLAGS
>
> - corrected documentation a bit more
>
> - tested bridge_vlan_aware.sh with veth/VRF
>
> Florian Fainelli (9):
> Documentation: networking: switchdev: Update port parent ID section
> net: switchdev: Add PORT_PRE_BRIDGE_FLAGS
> mlxsw: spectrum: Handle PORT_PRE_BRIDGE_FLAGS
> staging: fsl-dpaa2: ethsw: Handle PORT_PRE_BRIDGE_FLAGS
> net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
> rocker: Check Handle PORT_PRE_BRIDGE_FLAGS
> net: bridge: Stop calling switchdev_port_attr_get()
> net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT
> net: Get rid of switchdev_port_attr_get()
>
> Documentation/networking/switchdev.txt | 16 ++--
> .../mellanox/mlxsw/spectrum_switchdev.c | 38 +++++-----
> drivers/net/ethernet/rocker/rocker_main.c | 75 +++++++++++--------
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 32 ++++----
> include/net/switchdev.h | 13 +---
> net/bridge/br_switchdev.c | 11 ++-
> net/dsa/dsa_priv.h | 6 ++
> net/dsa/port.c | 17 +++++
> net/dsa/slave.c | 24 +++---
> 9 files changed, 128 insertions(+), 104 deletions(-)
>
--
Florian
next prev parent reply other threads:[~2019-02-16 0:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 22:53 [PATCH net-next v2 0/9] net: Get rid of switchdev_port_attr_get() Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 1/9] Documentation: networking: switchdev: Update port parent ID section Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 2/9] net: switchdev: Add PORT_PRE_BRIDGE_FLAGS Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 3/9] mlxsw: spectrum: Handle PORT_PRE_BRIDGE_FLAGS Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 4/9] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 5/9] net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 6/9] rocker: Check Handle PORT_PRE_BRIDGE_FLAGS Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 7/9] net: bridge: Stop calling switchdev_port_attr_get() Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 8/9] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT Florian Fainelli
2019-02-15 22:53 ` [PATCH net-next v2 9/9] net: Get rid of switchdev_port_attr_get() Florian Fainelli
2019-02-16 0:37 ` Florian Fainelli [this message]
2019-02-16 4:49 ` [PATCH net-next v2 0/9] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77c28e2d-cd29-4932-5cfe-64799c730ede@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).