Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

From: Petr Machata <petrm@mellanox.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Ido Schimmel <idosch@idosch.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Jiri Pirko <jiri@mellanox.com>,
	Shalom Toledo <shalomt@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations
Date: Wed, 5 Jun 2019 09:00:09 +0000	[thread overview]
Message-ID: <87muiwxv8o.fsf@mellanox.com> (raw)
In-Reply-To: <20190604170349.wqsocilmlaisyzar@localhost>

Richard Cochran <richardcochran@gmail.com> writes:

> On Mon, Jun 03, 2019 at 03:12:42PM +0300, Ido Schimmel wrote:
>> +struct mlxsw_sp_ptp_clock *
>> +mlxsw_sp1_ptp_clock_init(struct mlxsw_sp *mlxsw_sp, struct device *dev)

[...]

>> +	clock->ptp_info = mlxsw_sp1_ptp_clock_info;
>> +	clock->ptp = ptp_clock_register(&clock->ptp_info, dev);
>> +	if (IS_ERR(clock->ptp)) {
>> +		err = PTR_ERR(clock->ptp);
>> +		dev_err(dev, "ptp_clock_register failed %d\n", err);
>> +		goto err_ptp_clock_register;
>> +	}
>> +
>> +	return clock;
>
> You need to handle the case where ptp_clock_register() returns NULL...
>
> /**
>  * ptp_clock_register() - register a PTP hardware clock driver
>  *
>  * @info:   Structure describing the new clock.
>  * @parent: Pointer to the parent device of the new clock.
>  *
>  * Returns a valid pointer on success or PTR_ERR on failure.  If PHC
>  * support is missing at the configuration level, this function
>  * returns NULL, and drivers are expected to gracefully handle that
>  * case separately.
>  */

We don't build the PTP module at all unless CONFIG_PTP_1588_CLOCK is
enabled, and fall back to inline stubs unless it IS_REACHABLE. I believe
this should be OK.