From: "Bjørn Mork" <bjorn@mork.no>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: johan@kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, Matthew Garrett <mgarrett@aurora.tech>
Subject: Re: [PATCH V2 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration
Date: Wed, 04 Jan 2023 20:53:56 +0100 [thread overview]
Message-ID: <87y1qikre3.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20221226234751.444917-3-mjg59@srcf.ucam.org> (Matthew Garrett's message of "Mon, 26 Dec 2022 15:47:50 -0800")
Matthew Garrett <mjg59@srcf.ucam.org> writes:
> The Orbic Speed RC400L presents as a generic MDM9207 device that supports
> multiple configurations with different USB IDs. One exposes a QMI interface.
> Add the ID for that.
>
> Signed-off-by: Matthew Garrett <mgarrett@aurora.tech>
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index a808d718c012..bf05b7feacc0 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1223,6 +1223,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x05c6, 0x90b2, 3)}, /* ublox R410M */
> {QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
> {QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
> + {QMI_FIXED_INTF(0x05c6, 0xf601, 5)},
> {QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */
> {QMI_FIXED_INTF(0x0846, 0x68a2, 8)},
> {QMI_FIXED_INTF(0x0846, 0x68d3, 8)}, /* Netgear Aircard 779S */
Looks good to me, but checkpatch warns about
WARNING: From:/Signed-off-by: email address mismatch: 'From: Matthew Garrett <mjg59@srcf.ucam.org>' != 'Signed-off-by: Matthew Garrett <mgarrett@aurora.tech>'
which you might want to consider, unless this was intentional for some
reason? In any case:
Acked-by: Bjørn Mork <bjorn@mork.no>
next prev parent reply other threads:[~2023-01-04 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 23:47 [PATCH V2] Add some USB hotspot IDs Matthew Garrett
2022-12-26 23:47 ` [PATCH V2 1/3] USB: serial: option: Add generic MDM9207 configurations Matthew Garrett
2023-01-12 16:28 ` Johan Hovold
2022-12-26 23:47 ` [PATCH V2 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration Matthew Garrett
2023-01-04 19:53 ` Bjørn Mork [this message]
2022-12-26 23:47 ` [PATCH V2 3/3] USB: serial: option: Add Novatel MiFi 8800L diag endpoint Matthew Garrett
2023-01-12 16:29 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1qikre3.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgarrett@aurora.tech \
--cc=mjg59@srcf.ucam.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).