From: Johan Hovold <johan@kernel.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: bjorn@mork.no, netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH V2 3/3] USB: serial: option: Add Novatel MiFi 8800L diag endpoint
Date: Thu, 12 Jan 2023 17:29:03 +0100 [thread overview]
Message-ID: <Y8A1TzUO9JB5c+lQ@hovoldconsulting.com> (raw)
In-Reply-To: <20221226234751.444917-4-mjg59@srcf.ucam.org>
On Mon, Dec 26, 2022 at 03:47:51PM -0800, Matthew Garrett wrote:
> The Novatel MiFi 8800L can be configured into exposing additional
> endpoints by sending four bytes of 0s to the HID endpoint it exposes by
> default. One of the additional exposed endpoints is a Qualcomm DIAG protocol
> interface. Add the information for that in order to allow it to be used.
Could you include usb-devices output here too?
> Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
> ---
> drivers/usb/serial/option.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 5025810db8c9..40a4ccb888f9 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -161,6 +161,7 @@ static void option_instat_callback(struct urb *urb);
> #define NOVATELWIRELESS_PRODUCT_U620L 0x9022
> #define NOVATELWIRELESS_PRODUCT_G2 0xA010
> #define NOVATELWIRELESS_PRODUCT_MC551 0xB001
> +#define NOVATELWIRELESS_PRODUCT_8800L 0xB023
>
> #define UBLOX_VENDOR_ID 0x1546
>
> @@ -1055,6 +1056,7 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E362, 0xff, 0xff, 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E371, 0xff, 0xff, 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_U620L, 0xff, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_8800L, 0xff, 0xff, 0xff) },
>
> { USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01) },
> { USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01A) },
Johan
prev parent reply other threads:[~2023-01-12 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 23:47 [PATCH V2] Add some USB hotspot IDs Matthew Garrett
2022-12-26 23:47 ` [PATCH V2 1/3] USB: serial: option: Add generic MDM9207 configurations Matthew Garrett
2023-01-12 16:28 ` Johan Hovold
2022-12-26 23:47 ` [PATCH V2 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration Matthew Garrett
2023-01-04 19:53 ` Bjørn Mork
2022-12-26 23:47 ` [PATCH V2 3/3] USB: serial: option: Add Novatel MiFi 8800L diag endpoint Matthew Garrett
2023-01-12 16:29 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8A1TzUO9JB5c+lQ@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).