From: Johan Hovold <johan@kernel.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: bjorn@mork.no, netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Matthew Garrett <mgarrett@aurora.tech>
Subject: Re: [PATCH V2 1/3] USB: serial: option: Add generic MDM9207 configurations
Date: Thu, 12 Jan 2023 17:28:40 +0100 [thread overview]
Message-ID: <Y8A1OCqtqdSVQPf9@hovoldconsulting.com> (raw)
In-Reply-To: <20221226234751.444917-2-mjg59@srcf.ucam.org>
On Mon, Dec 26, 2022 at 03:47:49PM -0800, Matthew Garrett wrote:
> The Orbic Speed RC400L presents as a generic MDM9207 device that supports
> multiple configurations. Add support for the two that expose a set of serial
> ports.
Would you mind including the output of usb-devices for this device here
for completeness?
> Signed-off-by: Matthew Garrett <mgarrett@aurora.tech>
> ---
> drivers/usb/serial/option.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index dee79c7d82d5..5025810db8c9 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1119,6 +1119,12 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
> .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
> + /* Qualcomm MDM9207 - 0: DIAG, 1: modem, 2: AT, 3: NMEA, 4: adb, 5: QMI */
We typically just include the port layout in the commit message (along
with usb-devices output). Then you can move the device comment to the
end of the USB_DEVICE() line (cf. ONYX 3G device above).
> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf601),
> + .driver_info = RSVD(4) | RSVD(5) },
> + /* Qualcomm MDM9207 - 0,1: RNDIS, 2: DIAG, 3: modem, 4: AT, 5: NMEA, 6: adb */
> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf622),
> + .driver_info = RSVD(0) | RSVD(1) | RSVD(6) },
> /* Quectel products using Qualcomm vendor ID */
> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),
Johan
next prev parent reply other threads:[~2023-01-12 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 23:47 [PATCH V2] Add some USB hotspot IDs Matthew Garrett
2022-12-26 23:47 ` [PATCH V2 1/3] USB: serial: option: Add generic MDM9207 configurations Matthew Garrett
2023-01-12 16:28 ` Johan Hovold [this message]
2022-12-26 23:47 ` [PATCH V2 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration Matthew Garrett
2023-01-04 19:53 ` Bjørn Mork
2022-12-26 23:47 ` [PATCH V2 3/3] USB: serial: option: Add Novatel MiFi 8800L diag endpoint Matthew Garrett
2023-01-12 16:29 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8A1OCqtqdSVQPf9@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=mgarrett@aurora.tech \
--cc=mjg59@srcf.ucam.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).