netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Georgi Djakov <djakov@kernel.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Alex Elder <elder@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	iommu@lists.linux.dev, linux-gpio@vger.kernel.org,
	netdev@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 06/18] dt-bindings: interconnect: qcom: document the interconnects for sa8775p
Date: Mon, 9 Jan 2023 19:19:52 +0100	[thread overview]
Message-ID: <8b634315-ae4e-1710-bebd-17f30620e52b@linaro.org> (raw)
In-Reply-To: <20230109174511.1740856-7-brgl@bgdev.pl>

On 09/01/2023 18:44, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Add a set of new compatibles and DT include defines for the sa8775p
> platforms.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  .../bindings/interconnect/qcom,rpmh.yaml      |  14 ++
>  .../dt-bindings/interconnect/qcom,sa8775p.h   | 231 ++++++++++++++++++
>  2 files changed, 245 insertions(+)
>  create mode 100644 include/dt-bindings/interconnect/qcom,sa8775p.h
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> index a429a1ed1006..ad3e0c7e9430 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> @@ -27,6 +27,20 @@ properties:
>  
>    compatible:
>      enum:
> +      - qcom,sa8775p-aggre1-noc
> +      - qcom,sa8775p-aggre2-noc
> +      - qcom,sa8775p-clk-virt

Are you sure they come with IO address space? IOW, was the binding and
DTS tested against each other?

All recent bindings are split into their own file:

https://lore.kernel.org/all/20221223132040.80858-3-krzysztof.kozlowski@linaro.org/

https://lore.kernel.org/all/20221202232054.2666830-2-abel.vesa@linaro.org/


> +      - qcom,sa8775p-config-noc
> +      - qcom,sa8775p-dc-noc
> +      - qcom,sa8775p-gem-noc
> +      - qcom,sa8775p-gpdsp-anoc
> +      - qcom,sa8775p-lpass-ag-noc
> +      - qcom,sa8775p-mc-virt
> +      - qcom,sa8775p-mmss-noc
> +      - qcom,sa8775p-nspa-noc
> +      - qcom,sa8775p-nspb-noc
> +      - qcom,sa8775p-pcie-anoc
> +      - qcom,sa8775p-system-noc
>        - qcom,sc7180-aggre1-noc
>        - qcom,sc7180-aggre2-noc
>        - qcom,sc7180-camnoc-virt
> diff --git a/include/dt-bindings/interconnect/qcom,sa8775p.h b/include/dt-bindings/interconnect/qcom,sa8775p.h
> new file mode 100644
> index 000000000000..8d5968854187
> --- /dev/null
> +++ b/include/dt-bindings/interconnect/qcom,sa8775p.h

Filename matching family/compatible style, so just like sm8550.

> @@ -0,0 +1,231 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */

Dual license.

Best regards,
Krzysztof


  reply	other threads:[~2023-01-09 18:21 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 17:44 [PATCH 00/18] arm64: qcom: add support for sa8775p-ride Bartosz Golaszewski
2023-01-09 17:44 ` [PATCH 01/18] dt-bindings: clock: sa8775p: add bindings for Qualcomm gcc-sa8775p Bartosz Golaszewski
2023-01-09 18:15   ` Krzysztof Kozlowski
2023-01-09 18:16   ` Krzysztof Kozlowski
2023-01-09 20:13   ` Rob Herring
2023-01-09 17:44 ` [PATCH 02/18] clk: qcom: add the GCC driver for sa8775p Bartosz Golaszewski
2023-01-09 17:58   ` Konrad Dybcio
2023-01-09 18:18     ` Konrad Dybcio
2023-01-09 21:06     ` Dmitry Baryshkov
2023-01-17 12:44       ` Bartosz Golaszewski
2023-01-17 12:45         ` Dmitry Baryshkov
2023-01-09 17:44 ` [PATCH 03/18] arm64: defconfig: enable the clock driver for Qualcomm SA8775P platforms Bartosz Golaszewski
2023-01-09 17:59   ` Konrad Dybcio
2023-01-09 17:44 ` [PATCH 04/18] dt-bindings: clock: qcom-rpmhcc: document the clock for sa8775p Bartosz Golaszewski
2023-01-09 18:16   ` Krzysztof Kozlowski
2023-01-09 17:44 ` [PATCH 05/18] clk: qcom: rpmh: add clocks " Bartosz Golaszewski
2023-01-09 18:01   ` Konrad Dybcio
2023-01-09 17:44 ` [PATCH 06/18] dt-bindings: interconnect: qcom: document the interconnects " Bartosz Golaszewski
2023-01-09 18:19   ` Krzysztof Kozlowski [this message]
2023-01-09 17:45 ` [PATCH 07/18] interconnect: qcom: add a driver " Bartosz Golaszewski
2023-01-09 18:03   ` Konrad Dybcio
2023-01-09 18:22   ` Krzysztof Kozlowski
2023-01-09 17:45 ` [PATCH 08/18] arm64: defconfig: enable the interconnect driver for Qualcomm SA8775P Bartosz Golaszewski
2023-01-09 18:04   ` Konrad Dybcio
2023-01-09 17:45 ` [PATCH 09/18] dt-bindings: pinctrl: sa8775p: add bindings for qcom,sa8775p-tlmm Bartosz Golaszewski
2023-01-09 18:09   ` Krzysztof Kozlowski
2023-01-10 16:22   ` Bjorn Andersson
2023-01-09 17:45 ` [PATCH 10/18] pinctrl: qcom: sa8775p: add the pinctrl driver for the sa8775p platform Bartosz Golaszewski
2023-01-09 18:07   ` Konrad Dybcio
2023-01-10  8:18   ` Linus Walleij
2023-01-10 16:26   ` Bjorn Andersson
2023-01-19  8:43     ` Bartosz Golaszewski
2023-01-09 17:45 ` [PATCH 11/18] arm64: defconfig: enable the pinctrl driver for Qualcomm SA8775P platforms Bartosz Golaszewski
2023-01-09 18:08   ` Konrad Dybcio
2023-01-09 18:11   ` Krzysztof Kozlowski
2023-01-09 17:45 ` [PATCH 12/18] dt-bindings: mailbox: qcom-ipcc: document the sa8775p platform Bartosz Golaszewski
2023-01-09 18:22   ` Krzysztof Kozlowski
2023-01-09 17:45 ` [PATCH 13/18] dt-bindings: power: qcom,rpmpd: document sa8775p Bartosz Golaszewski
2023-01-09 18:23   ` Krzysztof Kozlowski
2023-01-09 17:45 ` [PATCH 14/18] soc: qcom: rmphpd: add power domains for sa8775p Bartosz Golaszewski
2023-01-09 18:08   ` Konrad Dybcio
2023-01-09 20:10   ` Dmitry Baryshkov
2023-01-09 17:45 ` [PATCH 15/18] dt-bindings: arm-smmu: document the smmu on Qualcomm SA8775P Bartosz Golaszewski
2023-01-09 18:24   ` Krzysztof Kozlowski
2023-01-09 17:45 ` [PATCH 16/18] iommu: arm-smmu: qcom: add support for sa8775p Bartosz Golaszewski
2023-01-09 18:10   ` Konrad Dybcio
2023-01-09 18:41     ` Krzysztof Kozlowski
2023-01-09 17:45 ` [PATCH 17/18] dt-bindings: arm: qcom: document the sa8775p reference board Bartosz Golaszewski
2023-01-09 18:26   ` Krzysztof Kozlowski
2023-01-09 17:45 ` [PATCH 18/18] arm64: dts: qcom: add initial support for qcom sa8775p-ride Bartosz Golaszewski
2023-01-09 18:29   ` Konrad Dybcio
2023-01-09 18:34   ` Krzysztof Kozlowski
2023-01-13 16:58     ` Prasad Sodagudi
2023-01-26 20:35   ` Eric Chanudet
2023-01-09 20:13 ` [PATCH 00/18] arm64: qcom: add support for sa8775p-ride Dmitry Baryshkov
2023-01-09 20:59   ` Konrad Dybcio
2023-01-09 21:03     ` Dmitry Baryshkov
2023-01-10 17:17 ` (subset) " Bjorn Andersson
2023-01-19  2:16 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b634315-ae4e-1710-bebd-17f30620e52b@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=elder@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=jassisinghbrar@gmail.com \
    --cc=joro@8bytes.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sboyd@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).