From: Jacob Keller <jacob.e.keller@intel.com>
To: Yunsheng Lin <linyunsheng@huawei.com>, Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, valex@mellanox.com
Subject: Re: [PATCH v2 0/3] devlink region trigger support
Date: Tue, 14 Jan 2020 12:04:04 -0800 [thread overview]
Message-ID: <98206413-81d3-211c-c9c4-916770f5e859@intel.com> (raw)
In-Reply-To: <a8bdbb3f-35d3-efc0-0a9c-ca5546397032@huawei.com>
On 1/14/2020 12:33 AM, Yunsheng Lin wrote:
> On 2020/1/14 2:22, Jacob Keller wrote:
>>
>>
>> On 1/13/2020 8:58 AM, Jiri Pirko wrote:
>>> Why? That is the purpose of the dpipe, but make the hw
>>> pipeline visible and show you the content of individual nodes.
>>>
>>
>> I agree. dpipe seems to be focused specifically on dumping nodes of the
>> tables that represent the hardware's pipeline. I think it's unrelated to
>> this discussion about regions vs health API.
>
> Sorry for bringing up a not really unrelated question in the thread,
>
No problem here :) I've been investigating devlink for our products, and
am working towards implementations for several features. Further
discussion is definitely welcome!
> For the hns3 hw mac table, it seems the hns3 hw is pretty simple, it mainly
> contain the port bitmaps of a mac address, then the hw can forward the packet
> based on the dst mac' port bitamp.
>
Right.
> It seems a litte hard to match to the dpipe API the last time I tried to
> use dpipe API to dump that.
dpipe is primarily targeted towards dumping complex hardware pipelines.
>
> So maybe it would be good to have the support of table dumping (both structured
> and binary table) for health API natively, so that we use it to dump some hw
> table for both driver and user triggering cases.
>
Maybe dpipe needs additional mechanism for presenting tables?
> I am not sure if other driver has the above requirement, and if the requirement
> makes any sense?
>
I think there's value in the ability to express this kind of contents.
Regions could work.
In regards to using devlink-health, I do believe the health API should
remain focused as the area you use for dumping data gathered
specifically in relation to an event such as an error condition.
Regions make sense when you want to allow access to a section of
addressable contents on demand.
A binary table could be dumped via a region, but I'm not 100% sure it
would make sense for structured tables.
Thanks,
Jake
next prev parent reply other threads:[~2020-01-14 20:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:33 [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/3] devlink: add callback to trigger region snapshots Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/1] devlink: add support for DEVLINK_CMD_REGION_TRIGGER Jacob Keller
2020-01-09 19:33 ` [PATCH v2 2/3] devlink: introduce command to trigger region snapshot Jacob Keller
2020-01-09 19:33 ` [PATCH v2 3/3] netdevsim: support triggering snapshot through devlink Jacob Keller
2020-01-09 20:13 ` [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-10 4:10 ` Yunsheng Lin
2020-01-10 17:52 ` Jacob Keller
2020-01-11 1:51 ` Yunsheng Lin
2020-01-12 20:45 ` Jakub Kicinski
2020-01-12 21:18 ` Alex Vesker
2020-01-13 1:39 ` Yunsheng Lin
2020-01-13 11:34 ` Jakub Kicinski
2020-01-13 18:16 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko
2020-01-13 16:58 ` Jiri Pirko
2020-01-13 18:22 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko
2020-01-14 8:33 ` Yunsheng Lin
2020-01-14 20:04 ` Jacob Keller [this message]
2020-01-15 8:36 ` Yunsheng Lin
2020-01-10 9:40 ` Jiri Pirko
2020-01-10 17:54 ` Jacob Keller
2020-01-10 18:47 ` Jakub Kicinski
2020-01-10 18:57 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98206413-81d3-211c-c9c4-916770f5e859@intel.com \
--to=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).