From: Jacob Keller <jacob.e.keller@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, valex@mellanox.com
Subject: Re: [PATCH v2 0/3] devlink region trigger support
Date: Fri, 10 Jan 2020 09:54:20 -0800 [thread overview]
Message-ID: <c5fe026b-d29f-7be2-78b5-c54ec6d2f549@intel.com> (raw)
In-Reply-To: <20200110094027.GL2235@nanopsycho.orion>
On 1/10/2020 1:40 AM, Jiri Pirko wrote:
> Thu, Jan 09, 2020 at 08:33:07PM CET, jacob.e.keller@intel.com wrote:
>> This series consists of patches to enable devlink to request a snapshot via
>> a new DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT.
>>
>> A reviewer might notice that the devlink health API already has such support
>> for handling a similar case. However, the health API does not make sense in
>> cases where the data is not related to an error condition.
>>
>> In this case, using the health API only for the dumping feels incorrect.
>> Regions make sense when the addressable content is not captured
>> automatically on error conditions, but only upon request by the devlink API.
>>
>> The netdevsim driver is modified to support the new trigger_snapshot
>> callback as an example of how this can be used.
>
> I don't think that the netdevsim usecase is enough to merge this in. You
> need a real-driver user as well.
>
Sure. But this direction and implementation seems reasonable?
I am making progress on a driver implementation for this, and I am fine
holding onto these patches until I am ready to submit the full series to
the list with the driver..
Mostly I wanted to make sure the direction was looking good earlier than
the time frame for completing that work.
Thanks,
Jake
next prev parent reply other threads:[~2020-01-10 17:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:33 [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/3] devlink: add callback to trigger region snapshots Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/1] devlink: add support for DEVLINK_CMD_REGION_TRIGGER Jacob Keller
2020-01-09 19:33 ` [PATCH v2 2/3] devlink: introduce command to trigger region snapshot Jacob Keller
2020-01-09 19:33 ` [PATCH v2 3/3] netdevsim: support triggering snapshot through devlink Jacob Keller
2020-01-09 20:13 ` [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-10 4:10 ` Yunsheng Lin
2020-01-10 17:52 ` Jacob Keller
2020-01-11 1:51 ` Yunsheng Lin
2020-01-12 20:45 ` Jakub Kicinski
2020-01-12 21:18 ` Alex Vesker
2020-01-13 1:39 ` Yunsheng Lin
2020-01-13 11:34 ` Jakub Kicinski
2020-01-13 18:16 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko
2020-01-13 16:58 ` Jiri Pirko
2020-01-13 18:22 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko
2020-01-14 8:33 ` Yunsheng Lin
2020-01-14 20:04 ` Jacob Keller
2020-01-15 8:36 ` Yunsheng Lin
2020-01-10 9:40 ` Jiri Pirko
2020-01-10 17:54 ` Jacob Keller [this message]
2020-01-10 18:47 ` Jakub Kicinski
2020-01-10 18:57 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5fe026b-d29f-7be2-78b5-c54ec6d2f549@intel.com \
--to=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).