From: Joe Perches <joe@perches.com>
To: trix@redhat.com, m.grzeschik@pengutronix.de, davem@davemloft.net,
kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arcnet: fix macro name when DEBUG is defined
Date: Sun, 17 Jan 2021 10:27:01 -0800 [thread overview]
Message-ID: <9fd72be8e628dba40fa83aeef65d80877ede86ca.camel@perches.com> (raw)
In-Reply-To: <20210117181519.527625-1-trix@redhat.com>
On Sun, 2021-01-17 at 10:15 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> When DEBUG is defined this error occurs
>
> drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’
> undeclared (first use in this function);
> did you mean ‘COM20020_REG_W_ADDR_HI’?
> ioaddr, com20020_REG_W_ADDR_HI);
> ^~~~~~~~~~~~~~~~~~~~~~
>
> From reviewing the context, the suggestion is what is meant.
>
> Fixes: 0fec65130b9f ("arcnet: com20020: Use arcnet_<I/O> routines")
Nice find thanks, especially seeing as how this hasn't been tested or
compiled in 5+ years...
commit 0fec65130b9f11a73d74f47025491f97f82ba070
Author: Joe Perches <joe@perches.com>
Date: Tue May 5 10:06:06 2015 -0700
Acked-by: Joe Perches <joe@perches.com>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/net/arcnet/com20020_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/arcnet/com20020_cs.c b/drivers/net/arcnet/com20020_cs.c
> index cf607ffcf358..81223f6bebcc 100644
> --- a/drivers/net/arcnet/com20020_cs.c
> +++ b/drivers/net/arcnet/com20020_cs.c
> @@ -67,7 +67,7 @@ static void regdump(struct net_device *dev)
> /* set up the address register */
> count = 0;
> arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag,
> - ioaddr, com20020_REG_W_ADDR_HI);
> + ioaddr, COM20020_REG_W_ADDR_HI);
> arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO);
>
>
> for (count = 0; count < 256 + 32; count++) {
next prev parent reply other threads:[~2021-01-17 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 18:15 [PATCH] arcnet: fix macro name when DEBUG is defined trix
2021-01-17 18:27 ` Joe Perches [this message]
2021-01-19 5:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fd72be8e628dba40fa83aeef65d80877ede86ca.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).