From: Soheil Hassas Yeganeh <soheil@google.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Yuchung Cheng <ycheng@google.com>,
soukjin bae <soukjin.bae@samsung.com>
Subject: Re: [PATCH net 2/2] tcp: tcp_v4_err() should be more careful
Date: Fri, 15 Feb 2019 21:31:21 -0500 [thread overview]
Message-ID: <CACSApvb5nTBSn54CqsNjvAFfLN2Hjf9MO3smiCNp3m94DytXnA@mail.gmail.com> (raw)
In-Reply-To: <CADVnQymt=dtyQDhMNFz4Wmbeqbies_nwvU7fxawyizOji5H7eg@mail.gmail.com>
On Fri, Feb 15, 2019 at 9:21 PM Neal Cardwell <ncardwell@google.com> wrote:
>
> On Fri, Feb 15, 2019 at 4:36 PM Eric Dumazet <edumazet@google.com> wrote:
> >
> > ICMP handlers are not very often stressed, we should
> > make them more resilient to bugs that might surface in
> > the future.
> >
> > If there is no packet in retransmit queue, we should
> > avoid a NULL deref.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Reported-by: soukjin bae <soukjin.bae@samsung.com>
> > ---
> > net/ipv4/tcp_ipv4.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Thanks you for the fix, Eric!
>
> Thanks!
>
> neal
next prev parent reply other threads:[~2019-02-16 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 21:36 [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() Eric Dumazet
2019-02-15 21:36 ` [PATCH net 1/2] tcp: clear icsk_backoff in tcp_write_queue_purge() Eric Dumazet
2019-02-16 2:21 ` Neal Cardwell
2019-02-15 21:36 ` [PATCH net 2/2] tcp: tcp_v4_err() should be more careful Eric Dumazet
2019-02-16 2:21 ` Neal Cardwell
2019-02-16 2:31 ` Soheil Hassas Yeganeh [this message]
2019-02-17 23:47 ` [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() David Miller
2019-02-18 2:20 ` Eric Dumazet
2019-02-18 19:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSApvb5nTBSn54CqsNjvAFfLN2Hjf9MO3smiCNp3m94DytXnA@mail.gmail.com \
--to=soheil@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soukjin.bae@samsung.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).