netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: edumazet@google.com, netdev@vger.kernel.org,
	ncardwell@google.com, ycheng@google.com, soukjin.bae@samsung.com
Subject: Re: [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err()
Date: Mon, 18 Feb 2019 11:59:42 -0800 (PST)	[thread overview]
Message-ID: <20190218.115942.2123254635644904862.davem@davemloft.net> (raw)
In-Reply-To: <8e6280f3-ea5b-48bd-4dc0-da134d4125d2@gmail.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 17 Feb 2019 18:20:21 -0800

> 
> 
> On 02/17/2019 03:47 PM, David Miller wrote:
>> From: Eric Dumazet <edumazet@google.com>
>> Date: Fri, 15 Feb 2019 13:36:19 -0800
>> 
>>> soukjin bae reported a crash in tcp_v4_err() that we
>>> root caused to a missing initialization.
>>>
>>> Second patch adds a sanity check in tcp_v4_err() to avoid
>>> future potential problems. Ignoring an ICMP message
>>> is probably better than crashing a machine.
>> 
>> Series applied, thanks Eric.
>> 
>> Want me to queue these up for -stable?
>> 
> 
> Yes please, I put no Fixes: tag because it seemed to be a day-0 bug.

Done.

      reply	other threads:[~2019-02-18 19:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 21:36 [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() Eric Dumazet
2019-02-15 21:36 ` [PATCH net 1/2] tcp: clear icsk_backoff in tcp_write_queue_purge() Eric Dumazet
2019-02-16  2:21   ` Neal Cardwell
2019-02-15 21:36 ` [PATCH net 2/2] tcp: tcp_v4_err() should be more careful Eric Dumazet
2019-02-16  2:21   ` Neal Cardwell
2019-02-16  2:31     ` Soheil Hassas Yeganeh
2019-02-17 23:47 ` [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() David Miller
2019-02-18  2:20   ` Eric Dumazet
2019-02-18 19:59     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218.115942.2123254635644904862.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=soukjin.bae@samsung.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).