From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>,
soukjin bae <soukjin.bae@samsung.com>
Subject: [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err()
Date: Fri, 15 Feb 2019 13:36:19 -0800 [thread overview]
Message-ID: <20190215213621.183537-1-edumazet@google.com> (raw)
soukjin bae reported a crash in tcp_v4_err() that we
root caused to a missing initialization.
Second patch adds a sanity check in tcp_v4_err() to avoid
future potential problems. Ignoring an ICMP message
is probably better than crashing a machine.
Eric Dumazet (2):
tcp: clear icsk_backoff in tcp_write_queue_purge()
tcp: tcp_v4_err() should be more careful
net/ipv4/tcp.c | 2 +-
net/ipv4/tcp_ipv4.c | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
--
2.21.0.rc0.258.g878e2cd30e-goog
next reply other threads:[~2019-02-15 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 21:36 Eric Dumazet [this message]
2019-02-15 21:36 ` [PATCH net 1/2] tcp: clear icsk_backoff in tcp_write_queue_purge() Eric Dumazet
2019-02-16 2:21 ` Neal Cardwell
2019-02-15 21:36 ` [PATCH net 2/2] tcp: tcp_v4_err() should be more careful Eric Dumazet
2019-02-16 2:21 ` Neal Cardwell
2019-02-16 2:31 ` Soheil Hassas Yeganeh
2019-02-17 23:47 ` [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() David Miller
2019-02-18 2:20 ` Eric Dumazet
2019-02-18 19:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215213621.183537-1-edumazet@google.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soukjin.bae@samsung.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).