From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 00/17] BPF static linker: support externs
Date: Wed, 14 Apr 2021 17:21:35 -0700 [thread overview]
Message-ID: <CAEf4BzaR5WyZ8h_6-0D91wvu2OOHAFAsWTMKEHkUbVqducLy_Q@mail.gmail.com> (raw)
In-Reply-To: <20210414200146.2663044-1-andrii@kernel.org>
On Wed, Apr 14, 2021 at 1:02 PM Andrii Nakryiko <andrii@kernel.org> wrote:
>
> Add BPF static linker support for extern resolution of global variables,
> functions, and BTF-defined maps.
>
> This patch set consists of 4 parts:
> - few patches are extending bpftool to simplify working with BTF dump;
> - libbpf object loading logic is extended to support __hidden functions and
> overriden (unused) __weak functions; also BTF-defined map parsing logic is
> refactored to be re-used by linker;
> - the crux of the patch set is BPF static linker logic extension to perform
> extern resolution for three categories: global variables, BPF
> sub-programs, BTF-defined maps;
> - a set of selftests that validate that all the combinations of
> extern/weak/__hidden are working as expected.
>
> See respective patches for more details.
>
> One aspect hasn't been addressed yet and is going to be resolved in the next
> patch set, but is worth mentioning. With BPF static linking of multiple .o
> files, dealing with static everything becomes more problematic for BPF
> skeleton and in general for any by name look up APIs. This is due to static
> entities are allowed to have non-unique name. Historically this was never
> a problem due to BPF programs were always confined to a single C file. That
> changes now and needs to be addressed. The thinking so far is for BPF static
> linker to prepend filename to each static variable and static map (which is
> currently not supported by libbpf, btw), so that they can be unambiguously
> resolved by (mostly) unique name. Mostly, because even filenames can be
> duplicated, but that should be rare and easy to address by wiser choice of
> filenames by users. Fortunately, static BPF subprograms don't suffer from this
> issues, as they are not independent entities and are neither exposed in BPF
> skeleton, nor is lookup-able by any of libbpf APIs (and there is little reason
> to do that anyways).
>
> This and few other things will be the topic of the next set of patches.
>
I forgot to mention that selftests are relying on Clang fix [0], which
is not yet in nightly builds, so kernel-patches CI is currently
failing a test. So, when/if testing locally, please make sure to build
Clang from latest main.
[0] https://reviews.llvm.org/D100362
> Andrii Nakryiko (17):
> bpftool: support dumping BTF VAR's "extern" linkage
> bpftool: dump more info about DATASEC members
> libbpf: suppress compiler warning when using SEC() macro with externs
> libbpf: mark BPF subprogs with hidden visibility as static for BPF
> verifier
> libbpf: allow gaps in BPF program sections to support overriden weak
> functions
> libbpf: refactor BTF map definition parsing
> libbpf: factor out symtab and relos sanity checks
> libbpf: make few internal helpers available outside of libbpf.c
> libbpf: extend sanity checking ELF symbols with externs validation
> libbpf: tighten BTF type ID rewriting with error checking
> libbpf: add linker extern resolution support for functions and global
> variables
> libbpf: support extern resolution for BTF-defined maps in .maps
> section
> selftests/bpf: use -O0 instead of -Og in selftests builds
> selftests/bpf: omit skeleton generation for multi-linked BPF object
> files
> selftests/bpf: add function linking selftest
> selftests/bpf: add global variables linking selftest
> sleftests/bpf: add map linking selftest
>
> tools/bpf/bpftool/btf.c | 30 +-
> tools/lib/bpf/bpf_helpers.h | 19 +-
> tools/lib/bpf/btf.c | 5 -
> tools/lib/bpf/libbpf.c | 370 +++--
> tools/lib/bpf/libbpf_internal.h | 45 +
> tools/lib/bpf/linker.c | 1292 ++++++++++++++---
> tools/testing/selftests/bpf/Makefile | 18 +-
> .../selftests/bpf/prog_tests/linked_funcs.c | 42 +
> .../selftests/bpf/prog_tests/linked_maps.c | 33 +
> .../selftests/bpf/prog_tests/linked_vars.c | 43 +
> .../selftests/bpf/progs/linked_funcs1.c | 73 +
> .../selftests/bpf/progs/linked_funcs2.c | 73 +
> .../selftests/bpf/progs/linked_maps1.c | 102 ++
> .../selftests/bpf/progs/linked_maps2.c | 112 ++
> .../selftests/bpf/progs/linked_vars1.c | 60 +
> .../selftests/bpf/progs/linked_vars2.c | 61 +
> 16 files changed, 2028 insertions(+), 350 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/linked_funcs.c
> create mode 100644 tools/testing/selftests/bpf/prog_tests/linked_maps.c
> create mode 100644 tools/testing/selftests/bpf/prog_tests/linked_vars.c
> create mode 100644 tools/testing/selftests/bpf/progs/linked_funcs1.c
> create mode 100644 tools/testing/selftests/bpf/progs/linked_funcs2.c
> create mode 100644 tools/testing/selftests/bpf/progs/linked_maps1.c
> create mode 100644 tools/testing/selftests/bpf/progs/linked_maps2.c
> create mode 100644 tools/testing/selftests/bpf/progs/linked_vars1.c
> create mode 100644 tools/testing/selftests/bpf/progs/linked_vars2.c
>
> --
> 2.30.2
>
prev parent reply other threads:[~2021-04-15 0:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 20:01 [PATCH bpf-next 00/17] BPF static linker: support externs Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 01/17] bpftool: support dumping BTF VAR's "extern" linkage Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 02/17] bpftool: dump more info about DATASEC members Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 03/17] libbpf: suppress compiler warning when using SEC() macro with externs Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 04/17] libbpf: mark BPF subprogs with hidden visibility as static for BPF verifier Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 05/17] libbpf: allow gaps in BPF program sections to support overriden weak functions Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 06/17] libbpf: refactor BTF map definition parsing Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 07/17] libbpf: factor out symtab and relos sanity checks Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 08/17] libbpf: make few internal helpers available outside of libbpf.c Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 09/17] libbpf: extend sanity checking ELF symbols with externs validation Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 10/17] libbpf: tighten BTF type ID rewriting with error checking Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 11/17] libbpf: add linker extern resolution support for functions and global variables Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 12/17] libbpf: support extern resolution for BTF-defined maps in .maps section Andrii Nakryiko
2021-04-14 22:00 ` Alexei Starovoitov
2021-04-14 23:48 ` Andrii Nakryiko
2021-04-15 2:01 ` Alexei Starovoitov
2021-04-15 20:35 ` Andrii Nakryiko
2021-04-15 20:57 ` Alexei Starovoitov
2021-04-14 20:01 ` [PATCH bpf-next 13/17] selftests/bpf: use -O0 instead of -Og in selftests builds Andrii Nakryiko
2021-04-14 22:02 ` Alexei Starovoitov
2021-04-14 22:15 ` David Laight
2021-04-15 0:03 ` Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 14/17] selftests/bpf: omit skeleton generation for multi-linked BPF object files Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 15/17] selftests/bpf: add function linking selftest Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 16/17] selftests/bpf: add global variables " Andrii Nakryiko
2021-04-14 20:01 ` [PATCH bpf-next 17/17] sleftests/bpf: add map " Andrii Nakryiko
2021-04-15 0:21 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzaR5WyZ8h_6-0D91wvu2OOHAFAsWTMKEHkUbVqducLy_Q@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).