From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, michal.kubiak@intel.com,
rkannoth@marvell.com, shenjian15@huawei.com,
wangjie125@huawei.com, liuyonglong@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 net 1/3] net: hns3: fix index limit to support all queue stats
Date: Mon, 18 Mar 2024 20:06:40 +0530 [thread overview]
Message-ID: <CAH-L+nPtgMUXve82iVq_q8yTpzDuwR4bHyz+Tv_xb9tYGR=83Q@mail.gmail.com> (raw)
In-Reply-To: <20240318132948.3624333-2-shaojijie@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]
On Mon, Mar 18, 2024 at 7:05 PM Jijie Shao <shaojijie@huawei.com> wrote:
>
> From: Jie Wang <wangjie125@huawei.com>
>
> Currently, hns hardware supports more than 512 queues and the index limit
> in hclge_comm_tqps_update_stats is wrong. So this patch removes it.
>
> Fixes: 287db5c40d15 ("net: hns3: create new set of common tqp stats APIs for PF and VF reuse")
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Only question I have is whether this is a fix or an enhancement.
Nevertheless changes look good to me.
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> ---
> .../ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> index f3c9395d8351..618f66d9586b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> @@ -85,7 +85,7 @@ int hclge_comm_tqps_update_stats(struct hnae3_handle *handle,
> hclge_comm_cmd_setup_basic_desc(&desc, HCLGE_OPC_QUERY_TX_STATS,
> true);
>
> - desc.data[0] = cpu_to_le32(tqp->index & 0x1ff);
> + desc.data[0] = cpu_to_le32(tqp->index);
> ret = hclge_comm_cmd_send(hw, &desc, 1);
> if (ret) {
> dev_err(&hw->cmq.csq.pdev->dev,
> --
> 2.30.0
>
>
--
Regards,
Kalesh A P
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
next prev parent reply other threads:[~2024-03-18 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 13:29 [PATCH V3 net 0/3] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 1/3] net: hns3: fix index limit to support all queue stats Jijie Shao
2024-03-18 14:26 ` Michal Kubiak
2024-03-18 14:36 ` Kalesh Anakkur Purayil [this message]
2024-03-25 12:55 ` Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization Jijie Shao
2024-03-18 14:25 ` Michal Kubiak
2024-03-19 11:17 ` Jiri Pirko
2024-03-25 12:51 ` Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED Jijie Shao
2024-03-18 14:16 ` Michal Kubiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH-L+nPtgMUXve82iVq_q8yTpzDuwR4bHyz+Tv_xb9tYGR=83Q@mail.gmail.com' \
--to=kalesh-anakkur.purayil@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).