From: Jijie Shao <shaojijie@huawei.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<michal.kubiak@intel.com>, <rkannoth@marvell.com>,
<shenjian15@huawei.com>, <wangjie125@huawei.com>,
<liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization
Date: Mon, 25 Mar 2024 20:51:10 +0800 [thread overview]
Message-ID: <ed3f0650-1c27-4daf-9f92-0fe0927acea9@huawei.com> (raw)
In-Reply-To: <Zfl0Xz3vNNH_3Mfo@nanopsycho>
on 2024/3/19 19:17, Jiri Pirko wrote:
> Mon, Mar 18, 2024 at 02:29:47PM CET, shaojijie@huawei.com wrote:
>> From: Yonglong Liu <liuyonglong@huawei.com>
>>
>> The devlink reload process will access the hardware resources,
>> but the register operation is done before the hardware is initialized.
>> so, if process the devlink reload during initialization, may lead to kernel
>> crash. This patch fixes this by checking whether the NIC is initialized.
> Fix your locking, you should take devl_lock during your init. That would
> disallow reload to race with it.
>
> pw-bot: cr
Thanks，
We have fixed this in v4.
Jijie Shao
next prev parent reply other threads:[~2024-03-25 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 13:29 [PATCH V3 net 0/3] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 1/3] net: hns3: fix index limit to support all queue stats Jijie Shao
2024-03-18 14:26 ` Michal Kubiak
2024-03-18 14:36 ` Kalesh Anakkur Purayil
2024-03-25 12:55 ` Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization Jijie Shao
2024-03-18 14:25 ` Michal Kubiak
2024-03-19 11:17 ` Jiri Pirko
2024-03-25 12:51 ` Jijie Shao [this message]
2024-03-18 13:29 ` [PATCH V3 net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED Jijie Shao
2024-03-18 14:16 ` Michal Kubiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3f0650-1c27-4daf-9f92-0fe0927acea9@huawei.com \
--to=shaojijie@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).